Skip to content

Commit f716328

Browse files
committed
relax busy/idle ordering on reconnect
nudge can leak idle messages, so it could be busy->idle, or idle->busy->idle. The important thing is that we get at least one idle message
1 parent b4f5f6b commit f716328

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

notebook/tests/services/kernel.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,8 +242,9 @@ casper.notebook_test(function () {
242242
'kernel_disconnected.Kernel',
243243
'kernel_reconnecting.Kernel',
244244
'kernel_connected.Kernel',
245-
'kernel_busy.Kernel',
246-
'kernel_idle.Kernel'
245+
// note: there will be a 'busy' in here, too,
246+
// but we can't guarantee which will come first
247+
'kernel_idle.Kernel',
247248
],
248249
function () {
249250
this.thenEvaluate(function () {
@@ -262,8 +263,7 @@ casper.notebook_test(function () {
262263
'kernel_connection_failed.Kernel',
263264
'kernel_reconnecting.Kernel',
264265
'kernel_connected.Kernel',
265-
'kernel_busy.Kernel',
266-
'kernel_idle.Kernel'
266+
'kernel_idle.Kernel',
267267
],
268268
function () {
269269
this.thenEvaluate(function () {

0 commit comments

Comments
 (0)