Skip to content

Commit db1d473

Browse files
authored
fix:fix pyre check (#7)
1 parent 68a51db commit db1d473

File tree

7 files changed

+23
-21
lines changed

7 files changed

+23
-21
lines changed

.pyre_configuration

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
{
1111
"site-package": "msgpack"
1212
},
13+
{
14+
"site-package": "msgpack_numpy.py"
15+
},
1316
{
1417
"site-package": "numpy"
1518
}

megstore/indexed/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ def __init__(
287287
def name(self) -> str:
288288
if hasattr(self._file_object, "name"):
289289
return self._file_object.name
290-
return self._file_object
290+
return type(self._file_object).__name__
291291

292292
def _close(self):
293293
if self._close_fileobj_when_close:

megstore/indexed/jsonline.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def _read_jsonline(self, file_object: BinaryIO, lineno: Optional[int] = None):
5858

5959
@classmethod
6060
def _build_index(
61-
self,
61+
cls,
6262
file_object: BinaryIO,
6363
offsets: Union[IndexHandler, array],
6464
index_build_callback: Optional[Callable[[Any], None]] = None,

megstore/indexed/txt.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def __init__(
5050

5151
@classmethod
5252
def _build_index(
53-
self,
53+
cls,
5454
file_object: BinaryIO,
5555
offsets: Union[IndexHandler, array],
5656
index_build_callback: Optional[Callable[[Any], None]] = None,

megstore/interface.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
Generic,
99
Iterable,
1010
Iterator,
11-
List,
1211
TextIO,
1312
Tuple,
1413
TypeVar,
@@ -90,7 +89,7 @@ def __iter__(self):
9089

9190
class SliceAccessible(Generic[VT], Countable, ABC):
9291
@abstractmethod
93-
def get(self, key: int) -> VT:
92+
def get(self, index: int) -> VT:
9493
pass
9594

9695
def _batch_get(self, index_slice: slice) -> Iterator[VT]:
@@ -104,7 +103,7 @@ def batch_get(self, index: slice) -> IterableValue[VT]:
104103
batch_get_func=self._batch_get,
105104
)
106105

107-
def __getitem__(self, index: Union[int, slice]) -> Union[VT, List[VT]]:
106+
def __getitem__(self, index: Union[int, slice]) -> Union[VT, IterableValue[VT]]:
108107
if isinstance(index, slice):
109108
return self.batch_get(index)
110109
return self.get(index)

tests/indexed/test_base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ def test_index_handler_name(self):
158158
"""Test IndexHandler name property"""
159159
file_obj = BytesIO()
160160
handler = IndexHandler(file_obj, typecode=INDEX_FILE_FORMAT)
161-
assert handler.name == file_obj
161+
assert handler.name == "BytesIO"
162162
handler.close()
163163

164164
def test_index_handler_mode(self):

tests/test_interface.py

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,8 @@ class ConcreteSliceAccessible(SliceAccessible):
157157
def __init__(self, data):
158158
self._data = data
159159

160-
def get(self, key):
161-
return self._data[key]
160+
def get(self, index):
161+
return self._data[index]
162162

163163
def count(self):
164164
return len(self._data)
@@ -175,8 +175,8 @@ class ConcreteSliceAccessible(SliceAccessible):
175175
def __init__(self, data):
176176
self._data = data
177177

178-
def get(self, key):
179-
return self._data[key]
178+
def get(self, index):
179+
return self._data[index]
180180

181181
def count(self):
182182
return len(self._data)
@@ -193,8 +193,8 @@ class ConcreteSliceAccessible(SliceAccessible):
193193
def __init__(self, data):
194194
self._data = data
195195

196-
def get(self, key):
197-
return self._data[key]
196+
def get(self, index):
197+
return self._data[index]
198198

199199
def count(self):
200200
return len(self._data)
@@ -210,8 +210,8 @@ class ConcreteSliceAccessible(SliceAccessible):
210210
def __init__(self, data):
211211
self._data = data
212212

213-
def get(self, key):
214-
return self._data[key]
213+
def get(self, index):
214+
return self._data[index]
215215

216216
def count(self):
217217
return len(self._data)
@@ -246,8 +246,8 @@ def test_base_reader_mode(self):
246246
"""Test BaseReader mode property"""
247247

248248
class ConcreteReader(BaseReader):
249-
def get(self, key):
250-
return key
249+
def get(self, index):
250+
return index
251251

252252
def count(self):
253253
return 0
@@ -261,8 +261,8 @@ def test_base_reader_name_with_name_attr(self):
261261
"""Test BaseReader name property when file has name"""
262262

263263
class ConcreteReader(BaseReader):
264-
def get(self, key):
265-
return key
264+
def get(self, index):
265+
return index
266266

267267
def count(self):
268268
return 0
@@ -276,8 +276,8 @@ def test_base_reader_name_without_name_attr(self):
276276
"""Test BaseReader name property when file has no name"""
277277

278278
class ConcreteReader(BaseReader):
279-
def get(self, key):
280-
return key
279+
def get(self, index):
280+
return index
281281

282282
def count(self):
283283
return 0

0 commit comments

Comments
 (0)