feat: add VSCode terminal environment inheritance setting (RooCodeInc#2862)

Co-authored-by: Eric Wheeler <[email protected]>

Author: 2 people

src/core/webview/webviewMessageHandler.ts

@@ -592,6 +592,37 @@ export const webviewMessageHandler = async (provider: ClineProvider, message: We
 			await updateGlobalState("fuzzyMatchThreshold", message.value)
 			await provider.postStateToWebview()
 			break
+		case "updateVSCodeSetting": {
+			// Allowlist of VSCode settings that can be updated
+			// Add new settings here when needed for future expansion
+			const ALLOWED_VSCODE_SETTINGS = ["terminal.integrated.inheritEnv"] as const
+
+			if (message.setting && message.value !== undefined) {
+				if (!ALLOWED_VSCODE_SETTINGS.includes(message.setting as (typeof ALLOWED_VSCODE_SETTINGS)[number])) {
+					provider.log(`Attempted to update restricted VSCode setting: ${message.setting}`)
+					vscode.window.showErrorMessage(`Cannot update restricted VSCode setting: ${message.setting}`)
+					break
+				}
+				await vscode.workspace.getConfiguration().update(message.setting, message.value, true)
+			}
+			break
+		}
+		case "getVSCodeSetting":
+			if (message.setting) {
+				try {
+					const value = vscode.workspace.getConfiguration().get(message.setting)
+					await provider.postMessageToWebview({ type: "vsCodeSetting", setting: message.setting, value })
+				} catch (error) {
+					console.error(`Failed to get VSCode setting ${message.setting}:`, error)
+					await provider.postMessageToWebview({
+						type: "vsCodeSetting",
+						setting: message.setting,
+						error: `Failed to get setting: ${error.message}`,
+						value: undefined,
+					})
+				}
+			}
+			break
 		case "alwaysApproveResubmit":
 			await updateGlobalState("alwaysApproveResubmit", message.bool ?? false)
 			await provider.postStateToWebview()

src/shared/ExtensionMessage.ts

@@ -68,6 +68,7 @@ export interface ExtensionMessage {
 		| "acceptInput"
 		| "setHistoryPreviewCollapsed"
 		| "commandExecutionStatus"
+		| "vsCodeSetting"
 	text?: string
 	action?:
 		| "chatButtonClicked"
@@ -104,6 +105,9 @@ export interface ExtensionMessage {
 	promptText?: string
 	results?: { path: string; type: "file" | "folder"; label?: string }[]
 	error?: string
+	setting?: string
+	value?: any
+	vscodeSettingValue?: unknown
 }
 
 export type ExtensionState = Pick<

src/shared/WebviewMessage.ts

@@ -51,6 +51,9 @@ export interface WebviewMessage {
 		| "openFile"
 		| "openMention"
 		| "cancelTask"
+		| "updateVSCodeSetting"
+		| "getVSCodeSetting"
+		| "vsCodeSetting"
 		| "alwaysAllowBrowser"
 		| "alwaysAllowMcp"
 		| "alwaysAllowModeSwitch"
@@ -134,6 +137,7 @@ export interface WebviewMessage {
 	images?: string[]
 	bool?: boolean
 	value?: number
+	vscodeSettingValue?: unknown
 	commands?: string[]
 	audioType?: AudioType
 	serverName?: string
@@ -145,6 +149,7 @@ export interface WebviewMessage {
 	dataUrls?: string[]
 	values?: Record<string, any>
 	query?: string
+	setting?: string
 	slug?: string
 	modeConfig?: ModeConfig
 	timeout?: number