Merge pull request #8

Change return type of insert functions to Result<bool>

Author: mehrantsi

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "feoxdb"
-version = "0.4.2"
+version = "0.5.0"
 edition = "2021"
 authors = ["Mehran Toosi <dev@mehran.dk>"]
 description = "Iron-oxide fast embedded database - nanosecond-level key-value storage"

src/core/store/internal.rs

@@ -18,7 +18,7 @@ impl FeoxStore {
         value: &[u8],
         timestamp: u64,
         ttl_expiry: u64,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         let new_record = if ttl_expiry > 0 && self.enable_ttl {
             Arc::new(Record::new_with_timestamp_ttl(
                 old_record.key.clone(),
@@ -84,7 +84,7 @@ impl FeoxStore {
             }
         }
 
-        Ok(())
+        Ok(false)
     }
 
     /// Update an existing record with a new value (Bytes version for zero-copy).
@@ -94,7 +94,7 @@ impl FeoxStore {
         value: Bytes,
         timestamp: u64,
         ttl_expiry: u64,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         let new_record = if ttl_expiry > 0 && self.enable_ttl {
             Arc::new(Record::new_from_bytes_with_ttl(
                 old_record.key.clone(),
@@ -160,7 +160,7 @@ impl FeoxStore {
             }
         }
 
-        Ok(())
+        Ok(false)
     }
 
     /// Get access to hash table (for TTL cleaner)

src/core/store/json_patch.rs

@@ -95,6 +95,7 @@ impl FeoxStore {
         let new_value = crate::utils::json_patch::apply_json_patch(&current_value, patch)?;
 
         // Now update without holding any references
-        self.insert_with_timestamp(key, &new_value, Some(timestamp))
+        self.insert_with_timestamp(key, &new_value, Some(timestamp))?;
+        Ok(())
     }
 }

src/core/store/operations.rs

@@ -23,7 +23,7 @@ impl FeoxStore {
     ///
     /// # Returns
     ///
-    /// Returns `Ok(())` if successful.
+    /// Returns `Ok(true)` if a new key was inserted, `Ok(false)` if an existing key was updated.
     ///
     /// # Errors
     ///
@@ -47,7 +47,7 @@ impl FeoxStore {
     ///
     /// * Memory mode: ~600ns
     /// * Persistent mode: ~800ns (buffered write)
-    pub fn insert(&self, key: &[u8], value: &[u8]) -> Result<()> {
+    pub fn insert(&self, key: &[u8], value: &[u8]) -> Result<bool> {
         self.insert_with_timestamp(key, value, None)
     }
 
@@ -70,7 +70,7 @@ impl FeoxStore {
         key: &[u8],
         value: &[u8],
         timestamp: Option<u64>,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         self.insert_with_timestamp_and_ttl_internal(key, value, timestamp, 0)
     }
 
@@ -90,7 +90,7 @@ impl FeoxStore {
     ///
     /// # Returns
     ///
-    /// Returns `Ok(())` if successful.
+    /// Returns `Ok(true)` if a new key was inserted, `Ok(false)` if an existing key was updated.
     ///
     /// # Errors
     ///
@@ -116,7 +116,7 @@ impl FeoxStore {
     ///
     /// * Memory mode: ~600ns (avoids value copy)
     /// * Persistent mode: ~800ns (buffered write, avoids value copy)
-    pub fn insert_bytes(&self, key: &[u8], value: Bytes) -> Result<()> {
+    pub fn insert_bytes(&self, key: &[u8], value: Bytes) -> Result<bool> {
         self.insert_bytes_with_timestamp(key, value, None)
     }
 
@@ -139,7 +139,7 @@ impl FeoxStore {
         key: &[u8],
         value: Bytes,
         timestamp: Option<u64>,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         self.insert_bytes_with_timestamp_and_ttl_internal(key, value, timestamp, 0)
     }
 
@@ -149,7 +149,7 @@ impl FeoxStore {
         value: &[u8],
         timestamp: Option<u64>,
         ttl_expiry: u64,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         let start = std::time::Instant::now();
         let timestamp = match timestamp {
             Some(0) | None => self.get_timestamp(),
@@ -217,7 +217,7 @@ impl FeoxStore {
             }
         }
 
-        Ok(())
+        Ok(!is_update)
     }
 
     /// Internal method to insert a Bytes value with timestamp and TTL (zero-copy)
@@ -227,7 +227,7 @@ impl FeoxStore {
         value: Bytes,
         timestamp: Option<u64>,
         ttl_seconds: u64,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         let start = std::time::Instant::now();
         // Get timestamp before any operations
         let timestamp = match timestamp {
@@ -242,6 +242,7 @@ impl FeoxStore {
         }
 
         // Check for existing record
+        let is_update = self.hash_table.contains(key);
         let existing_record = self.hash_table.read(key, |_, v| v.clone());
         if let Some(existing_record) = existing_record {
             let existing_ts = existing_record.timestamp;
@@ -300,7 +301,7 @@ impl FeoxStore {
             .memory_usage
             .fetch_add(new_size, Ordering::AcqRel);
         self.stats
-            .record_insert(start.elapsed().as_nanos() as u64, false);
+            .record_insert(start.elapsed().as_nanos() as u64, is_update);
 
         // Only do persistence if not in memory-only mode
         if !self.memory_only {
@@ -312,7 +313,7 @@ impl FeoxStore {
             }
         }
 
-        Ok(())
+        Ok(!is_update)
     }
 
     /// Retrieve a value by key.

src/core/store/ttl.rs

@@ -37,7 +37,7 @@ impl FeoxStore {
     ///
     /// * Memory mode: ~800ns
     /// * Persistent mode: ~1µs (buffered write)
-    pub fn insert_with_ttl(&self, key: &[u8], value: &[u8], ttl_seconds: u64) -> Result<()> {
+    pub fn insert_with_ttl(&self, key: &[u8], value: &[u8], ttl_seconds: u64) -> Result<bool> {
         if !self.enable_ttl {
             return Err(FeoxError::TtlNotEnabled);
         }
@@ -62,7 +62,7 @@ impl FeoxStore {
         value: &[u8],
         ttl_seconds: u64,
         timestamp: Option<u64>,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         if !self.enable_ttl {
             return Err(FeoxError::TtlNotEnabled);
         }
@@ -114,7 +114,12 @@ impl FeoxStore {
     ///
     /// * Memory mode: ~800ns (avoids value copy)
     /// * Persistent mode: ~1µs (buffered write, avoids value copy)
-    pub fn insert_bytes_with_ttl(&self, key: &[u8], value: Bytes, ttl_seconds: u64) -> Result<()> {
+    pub fn insert_bytes_with_ttl(
+        &self,
+        key: &[u8],
+        value: Bytes,
+        ttl_seconds: u64,
+    ) -> Result<bool> {
         if !self.enable_ttl {
             return Err(FeoxError::TtlNotEnabled);
         }
@@ -139,7 +144,7 @@ impl FeoxStore {
         value: Bytes,
         ttl_seconds: u64,
         timestamp: Option<u64>,
-    ) -> Result<()> {
+    ) -> Result<bool> {
         if !self.enable_ttl {
             return Err(FeoxError::TtlNotEnabled);
         }