Merge pull request #64 from meilisearch/stop-returning-results-in-writer-new

Author: Kerollmops

examples/build-tree-no-commit.rs

@@ -59,7 +59,7 @@ fn main() -> Result<(), heed::BoxedError> {
 
     let mut wtxn = env.write_txn().unwrap();
     let database: Database<DotProduct> = env.create_database(&mut wtxn, None)?;
-    let writer = Writer::<DotProduct>::new(database, 0, dimensions)?;
+    let writer = Writer::<DotProduct>::new(database, 0, dimensions);
 
     let now = Instant::now();
     println!("Building the arroy internal trees...");

examples/compare_with_hnsw.rs

@@ -75,7 +75,7 @@ fn load_into_arroy(
     dimensions: usize,
     points: &[Point],
 ) -> Result<()> {
-    let writer = Writer::<Euclidean>::new(database, 0, dimensions)?;
+    let writer = Writer::<Euclidean>::new(database, 0, dimensions);
     for (i, Point(vector)) in points.iter().enumerate() {
         writer.add_item(&mut wtxn, i.try_into().unwrap(), &vector[..])?;
     }

examples/fuzz.rs

@@ -85,7 +85,7 @@ fn main() -> Result<()> {
             let ret = panic::catch_unwind(|| -> arroy::Result<()> {
                 let mut rng_arroy = rng_arroy.clone();
                 let mut wtxn = env.write_txn()?;
-                let writer = Writer::<Euclidean>::new(database, 0, 2)?;
+                let writer = Writer::<Euclidean>::new(database, 0, 2);
 
                 for op in operations {
                     match op {

examples/import-vectors.rs

@@ -66,7 +66,7 @@ fn main() -> Result<(), heed::BoxedError> {
 
     let mut wtxn = env.write_txn().unwrap();
     let database: Database<DotProduct> = env.create_database(&mut wtxn, None)?;
-    let writer = Writer::<DotProduct>::new(database, 0, dimensions)?;
+    let writer = Writer::<DotProduct>::new(database, 0, dimensions);
 
     // The file look like that
     // === BEGIN vectors ===

src/lib.rs

@@ -29,7 +29,7 @@
 //! // Now we can give it to our arroy writer
 //! let index = 0;
 //! let dimensions = 5;
-//! let writer = Writer::<Euclidean>::new(db, index, dimensions)?;
+//! let writer = Writer::<Euclidean>::new(db, index, dimensions);
 //!
 //! // let's write some vectors
 //! writer.add_item(&mut wtxn, 0,    &[0.8,  0.49, 0.27, 0.76, 0.94])?;

src/tests/reader.rs

@@ -28,7 +28,7 @@ impl Display for NnsRes {
 fn open_unfinished_db() {
     let handle = create_database();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     writer.add_item(&mut wtxn, 0, &[0.0, 0.0]).unwrap();
     wtxn.commit().unwrap();
 
@@ -41,7 +41,7 @@ fn open_unfinished_db() {
 fn open_db_with_wrong_dimension() {
     let handle = create_database();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     writer.add_item(&mut wtxn, 0, &[0.0, 0.0]).unwrap();
 
     writer.build(&mut wtxn, &mut rng(), Some(1)).unwrap();
@@ -57,7 +57,7 @@ fn open_db_with_wrong_dimension() {
 fn open_db_with_wrong_distance() {
     let handle = create_database::<Euclidean>();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     writer.add_item(&mut wtxn, 0, &[0.0, 0.0]).unwrap();
 
     writer.build(&mut wtxn, &mut rng(), Some(1)).unwrap();
@@ -79,7 +79,7 @@ fn search_in_db_with_a_single_vector() {
     // https://github.com/meilisearch/meilisearch/pull/4296
     let handle = create_database::<Angular>();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 3).unwrap();
+    let writer = Writer::new(handle.database, 0, 3);
     writer.add_item(&mut wtxn, 0, &[0.00397, 0.553, 0.0]).unwrap();
 
     writer.build(&mut wtxn, &mut rng(), None).unwrap();
@@ -98,7 +98,7 @@ fn search_in_db_with_a_single_vector() {
 fn two_dimension_on_a_line() {
     let handle = create_database();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     // We'll draw a simple line over the y as seen below
     // (0,0) # # # # # # ...
     for i in 0..100 {
@@ -142,7 +142,7 @@ fn two_dimension_on_a_line() {
 fn two_dimension_on_a_column() {
     let handle = create_database();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     // We'll draw a simple line over the y as seen below
     // (0,0) # . . . . .
     // (0,1) # . . . . .
@@ -173,7 +173,7 @@ fn two_dimension_on_a_column() {
 fn filtering() {
     let handle = create_database();
     let mut wtxn = handle.env.write_txn().unwrap();
-    let writer = Writer::new(handle.database, 0, 2).unwrap();
+    let writer = Writer::new(handle.database, 0, 2);
     // We'll draw a simple line over the y as seen below
     // (0,0) # . . . . .
     // (0,1) # . . . . .