Apply suggestions from code review

Co-authored-by: Clément Renault <[email protected]>

Author: irevoire

src/error.rs

@@ -43,7 +43,7 @@ pub enum Error {
     /// Arroy is not able to find the metadata for a given index.
     /// It is probably because the user forget to build the database.
     #[error(
-        "Metadata are missing on index {0}, did you build your database before trying to read it"
+        "Metadata are missing on index {0}, You must build your database before attempting to read it"
     )]
     MissingMetadata(u16),
 

src/reader.rs

@@ -45,9 +45,7 @@ impl<'t, D: Distance> Reader<'t, D> {
                 received: D::name(),
             });
         }
-        let need_build =
-            database.remap_data_type::<Bytes>().get(rtxn, &Key::updated(index))?.is_some();
-        if need_build {
+        if database.remap_data_type::<Bytes>().get(rtxn, &Key::updated(index))?.is_some() {
             return Err(Error::NeedBuild(index));
         }
 

src/tests/reader.rs

@@ -34,7 +34,7 @@ fn open_unfinished_db() {
 
     let rtxn = handle.env.read_txn().unwrap();
     let ret = Reader::<Euclidean>::open(&rtxn, 0, handle.database).map(|_| ()).unwrap_err();
-    insta::assert_display_snapshot!(ret, @"Metadata are missing on index 0, did you build your database before trying to read it");
+    insta::assert_display_snapshot!(ret, @"Metadata are missing on index 0, You must build your database before attempting to read it");
 }
 
 #[test]

src/tests/writer.rs

@@ -95,7 +95,6 @@ fn write_one_vector() {
 
 #[test]
 fn write_one_vector_in_one_tree() {
-    let _ = env_logger::builder().is_test(true).parse_filters("trace").try_init();
     let handle = create_database::<Euclidean>();
     let mut wtxn = handle.env.write_txn().unwrap();
     let writer = Writer::new(handle.database, 0, 3);