Skip to content

Dead code to investigate #81

New issue
New issue
Closed
#132
#93
Closed
Dead code to investigate#81
#132
#93
Milestone
v1.7.0
@irevoire

Description

@irevoire
irevoire
opened on Jul 3, 2024

Hey,

I noticed some dead code in the euclidean & manhattan distance;

arroy/src/distance/euclidean.rs

Lines 54 to 60 in 973f093

normal.header.bias = normal
.vector
.iter()
.zip(node_p.vector.iter())
.zip(node_q.vector.iter())
.map(|((n, p), q)| -n * (p + q) / 2.0)
.sum();

arroy/src/distance/manhattan.rs

Lines 57 to 63 in 973f093

normal.header.bias = normal
.vector
.iter()
.zip(node_p.vector.iter())
.zip(node_q.vector.iter())
.map(|((n, p), q)| -n * (p + q) / 2.0)
.sum();

Before deleting it, we should investigate and try to understand if we were not supposed to be doing this operation in the pre-process or somewhere else?
Are the bias even set anywhere?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions