Merge #380

380: Bump pylint from 2.15.9 to 2.17.4 r=alallema a=dependabot[bot]

Bumps [pylint](https://github.com/PyCQA/pylint) from 2.15.9 to 2.17.4.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/pylint-dev/pylint/commit/fc34a4b6abe56f3ac07ca15d846b1c1955545f85"><code>fc34a4b</code></a> Bump pylint to 2.17.4, update changelog</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/62083dc1f197712e440128620541e5c068d9ccf7"><code>62083dc</code></a> [changelog] Add a changelog entry for <a href="https://redirect.github.com/PyCQA/pylint/issues/8632">#8632</a></li>
<li><a href="https://github.com/pylint-dev/pylint/commit/fd60b7284a78e3fe371dd90566f0cc316deaf4c4"><code>fd60b72</code></a> Make sure a <code>tool</code> table is created in <code>toml</code> generation (<a href="https://redirect.github.com/PyCQA/pylint/issues/8638">#8638</a>) (<a href="https://redirect.github.com/PyCQA/pylint/issues/8640">#8640</a>)</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/0b5defa5cfa4662d76cb01c90893c38428e3513c"><code>0b5defa</code></a> [tomlkit] Limit the maximum version of tomlkit (<a href="https://redirect.github.com/PyCQA/pylint/issues/8633">#8633</a>) (<a href="https://redirect.github.com/PyCQA/pylint/issues/8635">#8635</a>)</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/4350c6fd7a955892712e2bf7a78adf4531e483b4"><code>4350c6f</code></a> Added escaping of vertical bar character in annotation labels (<a href="https://redirect.github.com/PyCQA/pylint/issues/8610">#8610</a>) (<a href="https://redirect.github.com/PyCQA/pylint/issues/8631">#8631</a>)</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/e507a4d87ec80e706ac0c8ce2d23bd28006cbbbc"><code>e507a4d</code></a> Fix a false positive for <code>bad-dunder-name</code> when there is a user-defined ``_...</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/389e14c36819cb87190fd412d3f366a3283f0078"><code>389e14c</code></a> Bump pylint to 2.17.3, update changelog (<a href="https://redirect.github.com/PyCQA/pylint/issues/8620">#8620</a>)</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/3fc153ac67f8264275f846bc25daccc57a8f8a5a"><code>3fc153a</code></a> Upgrade astroid to 2.15.4 (<a href="https://redirect.github.com/PyCQA/pylint/issues/8615">#8615</a>) (<a href="https://redirect.github.com/PyCQA/pylint/issues/8618">#8618</a>)</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/c2936a541f570a4a854672cbb4899651d39d6088"><code>c2936a5</code></a> Disable import-error as attrs is no longer a test dependency</li>
<li><a href="https://github.com/pylint-dev/pylint/commit/5f7e2a51bf008b0bb4acf2ecbcadcf1c903a72f4"><code>5f7e2a5</code></a> Upgrade astroid to 2.15.3 (<a href="https://redirect.github.com/PyCQA/pylint/issues/8584">#8584</a>)</li>
<li>Additional commits viewable in <a href="https://github.com/PyCQA/pylint/compare/v2.15.9...v2.17.4">compare view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=pylint&package-manager=pip&previous-version=2.15.9&new-version=2.17.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

You can trigger a rebase of this PR by commenting ``@dependabot` rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- ``@dependabot` rebase` will rebase this PR
- ``@dependabot` recreate` will recreate this PR, overwriting any edits that have been made to it
- ``@dependabot` merge` will merge this PR after your CI passes on it
- ``@dependabot` squash and merge` will squash and merge this PR after your CI passes on it
- ``@dependabot` cancel merge` will cancel a previously requested merge and block automerging
- ``@dependabot` reopen` will reopen this PR if it is closed
- ``@dependabot` close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- ``@dependabot` ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- ``@dependabot` ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)


</details>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: alallema <[email protected]>

Author: 3 people

Pipfile

@@ -13,7 +13,7 @@ requests = "==2.31.0"
 
 [dev-packages]
 pytest = "==7.3.1"
-pylint = "==2.15.9"
+pylint = "==2.17.4"
 tox = "==4.5.2"
 tox-pipenv = "==1.10.1"
 importlib_metadata = {version = "*", markers="python_version < '3.8'"}

Pipfile.lock

@@ -1,3 +1,4 @@
+import builtins
 import re
 import os
 from selenium import webdriver
@@ -29,7 +30,7 @@ def init(config_original_content, js_render, user_agent):
             CHROMEDRIVER_PATH = os.environ.get('CHROMEDRIVER_PATH',
                                                "/usr/bin/chromedriver")
             if not os.path.isfile(CHROMEDRIVER_PATH):
-                raise Exception(
+                raise builtins.Exception(
                     f"Env CHROMEDRIVER_PATH='{CHROMEDRIVER_PATH}' is not a path to a file")
             driver = webdriver.Chrome(
                 CHROMEDRIVER_PATH,

scraper/src/config/browser_handler.py

@@ -1,5 +1,8 @@
 
 
+import builtins
+
+
 class ConfigValidator:
     config = None
 
@@ -18,52 +21,52 @@ def validate(self):
         # Start urls must be an array
         if self.config.start_urls and not isinstance(self.config.start_urls,
                                                      list):
-            raise Exception('start_urls should be list')
+            raise builtins.Exception('start_urls should be list')
 
         # Stop urls must be an array
         if self.config.stop_urls and not isinstance(self.config.stop_urls,
                                                     list):
-            raise Exception('stop_urls should be list')
+            raise builtins.Exception('stop_urls should be list')
 
         # Custom settings must be a dict
         if self.config.custom_settings and not isinstance(self.config.custom_settings,
                                                     dict):
-            raise Exception('custom_settings must be a dictionary')
+            raise builtins.Exception('custom_settings must be a dictionary')
 
         if self.config.js_render and not isinstance(self.config.js_render,
                                                     bool):
-            raise Exception('js_render should be boolean')
+            raise builtins.Exception('js_render should be boolean')
 
         # `js_wait` is set to 0s by default unless it is specified
         if self.config.js_wait and not isinstance(self.config.js_wait, int):
-            raise Exception('js_wait should be integer')
+            raise builtins.Exception('js_wait should be integer')
 
         if self.config.use_anchors and not isinstance(self.config.use_anchors,
                                                       bool):
-            raise Exception('use_anchors should be boolean')
+            raise builtins.Exception('use_anchors should be boolean')
 
         if self.config.sitemap_alternate_links and not isinstance(
                 self.config.sitemap_alternate_links, bool):
-            raise Exception('sitemap_alternate_links should be boolean')
+            raise builtins.Exception('sitemap_alternate_links should be boolean')
 
         if self.config.sitemap_urls_regexs and not self.config.sitemap_urls:
-            raise Exception(
+            raise builtins.Exception(
                 'You gave an regex to parse sitemap but you didn\'t provide a sitemap url')
 
         if self.config.sitemap_urls_regexs and not self.config.sitemap_urls:
             for regex in self.config.sitemap_urls_regex:
                 if not isinstance(regex, str):
-                    raise Exception(
+                    raise builtins.Exception(
                         'You gave an bad regex: ' + regex + ' must be a string')
 
         if self.config.force_sitemap_urls_crawling and not self.config.sitemap_urls:
-            raise Exception(
+            raise builtins.Exception(
                 'You want to force the sitemap crawling but you didn\'t provide a sitemap url')
 
         if not self.config.scrape_start_urls and not self.config.scrap_start_urls:
-            raise Exception(
+            raise builtins.Exception(
                 'Please use only the new variable name: scrape_start_urls')
 
         if self.config.nb_hits_max and not isinstance(self.config.nb_hits_max,
                                                       int):
-            raise Exception('nb_hits_max should be integer')
+            raise builtins.Exception('nb_hits_max should be integer')

scraper/src/config/config_validator.py

@@ -1,3 +1,4 @@
+import builtins
 from ..helpers import css_to_xpath
 
 
@@ -27,7 +28,7 @@ def _parse_selectors_set(config_selectors):
             # Type
             if 'type' in selectors_set[key]:
                 if selectors_set[key]['type'] not in ['xpath', 'css']:
-                    raise Exception(
+                    raise builtins.Exception(
                         selectors_set[key][
                             'type'] + 'is not a good selector type, it should be `xpath` or `css`')
             else:

scraper/src/config/selectors_parser.py

@@ -1,3 +1,4 @@
+import builtins
 import re
 import copy
 
@@ -55,11 +56,11 @@ def parse(config_start_urls):
                                         start_url['variables'][match]['url'],
                                         start_url['variables'][match]['js'])
                                 else:
-                                    raise Exception(
+                                    raise builtins.Exception(
                                         "Bad arguments for variables." + match + " for url " +
                                         start_url['url'])
                         else:
-                            raise Exception(
+                            raise builtins.Exception(
                                 "Missing " + match + " in variables" + " for url " +
                                 start_url['url'])