Skip to content

Commit 2e14dbe

Browse files
Upgrade scrapy to version 2.2.0 (#47)
* Remove custom context factory Update scrapy to latest version * Fix Changelog after update
1 parent 8e34402 commit 2e14dbe

File tree

4 files changed

+66
-27
lines changed

4 files changed

+66
-27
lines changed

Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ verify_ssl = true
44
name = "pypi"
55

66
[packages]
7-
Scrapy = "==1.7.*"
7+
Scrapy = "==2.2.0"
88
selenium = "==3.141.0"
99
pytest = "==5.4.3"
1010
meilisearch = "==0.11.2"

Pipfile.lock

Lines changed: 65 additions & 9 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scraper/src/index.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
from .custom_downloader_middleware import CustomDownloaderMiddleware
1717
from .custom_dupefilter import CustomDupeFilter
1818
from .config.browser_handler import BrowserHandler
19-
from .scrapy_patch import CustomContextFactory
2019

2120
try:
2221
# disable boto (S3 download)
@@ -46,7 +45,6 @@ def run_config(config):
4645

4746
root_module = 'src.' if __name__ == '__main__' else 'scraper.src.'
4847
DOWNLOADER_MIDDLEWARES_PATH = root_module + 'custom_downloader_middleware.' + CustomDownloaderMiddleware.__name__
49-
DOWNLOADER_CLIENTCONTEXTFACTORY = root_module + 'scrapy_patch.' + CustomContextFactory.__name__
5048
DUPEFILTER_CLASS_PATH = root_module + 'custom_dupefilter.' + CustomDupeFilter.__name__
5149

5250
headers = {
@@ -78,7 +76,6 @@ def run_config(config):
7876
'USER_AGENT': config.user_agent,
7977
'DOWNLOADER_MIDDLEWARES': {DOWNLOADER_MIDDLEWARES_PATH: 900},
8078
# Need to be > 600 to be after the redirectMiddleware
81-
'DOWNLOADER_CLIENTCONTEXTFACTORY': DOWNLOADER_CLIENTCONTEXTFACTORY,
8279
'DUPEFILTER_USE_ANCHORS': config.use_anchors,
8380
# Use our custom dupefilter in order to be scheme agnostic regarding link provided
8481
'DUPEFILTER_CLASS': DUPEFILTER_CLASS_PATH,

scraper/src/scrapy_patch.py

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)