Skip to content

Commit 3c927e5

Browse files
authored
Merge branch 'main' into meili-bot/dependabot-gh-actions
2 parents bb27734 + 9698a1a commit 3c927e5

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

CONTRIBUTING.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ Some notes on GitHub PRs:
128128
- All PRs must be reviewed and approved by at least one maintainer.
129129
- The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next [release changelogs](https://github.com/meilisearch/docs-scraper/releases/).
130130

131-
## Release Process (for internal team only)
131+
## Release Process (for the internal team only)
132132

133133
Meilisearch tools follow the [Semantic Versioning Convention](https://semver.org/).
134134

@@ -146,10 +146,10 @@ _[Read more about this](https://github.com/meilisearch/integration-guides/blob/m
146146

147147
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md).
148148

149-
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/docs-scraper/releases): on this page, click on `Edit` (related to the draft release) > update the description (be sure you apply [these recommandations](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md#writting-the-release-description)) > when you are ready, click on `Publish release`.
149+
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/docs-scraper/releases): on this page, click on `Edit` (related to the draft release) > update the description (be sure you apply [these recommendations](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md#writting-the-release-description)) > when you are ready, click on `Publish release`.
150150

151151
GitHub Actions will be triggered and push the `latest` and `vX.X.X` version of the Docker image to [DockerHub](https://hub.docker.com/repository/docker/getmeili/docs-scraper).
152152

153153
<hr>
154154

155-
Thank you again for reading this through, we can not wait to begin to work with you if you made your way through this contributing guide ❤️
155+
Thank you again for reading this through. We can not wait to begin to work with you if you make your way through this contributing guide ❤️

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ _Meilisearch is open-source and can run either on your server or on any cloud pr
8787

8888
### Set your Config File
8989

90-
The scraper tool needs a config file to know which content you want to scrape. This is done by providing **selectors** (e.g. the HTML tag/id/class).
90+
The scraper tool needs a config file to know which content you want to scrape. This is done by providing **selectors** (e.g. the HTML tag/id/class). The config file is passed as an argument. It follows no naming convention and may be named as you want.
9191

9292
Here is an example of a basic config file:
9393

@@ -157,8 +157,8 @@ pipenv run ./docs_scraper <path-to-your-config-file>
157157
docker run -t --rm \
158158
-e MEILISEARCH_HOST_URL=<your-meilisearch-host-url> \
159159
-e MEILISEARCH_API_KEY=<your-meilisearch-api-key> \
160-
-v <absolute-path-to-your-config-file>:/docs-scraper/config.json \
161-
getmeili/docs-scraper:latest pipenv run ./docs_scraper config.json
160+
-v <absolute-path-to-your-config-file>:/docs-scraper/<path-to-your-config-file> \
161+
getmeili/docs-scraper:latest pipenv run ./docs_scraper <path-to-your-config-file>
162162
```
163163

164164
`<absolute-path-to-your-config-file>` should be the absolute path of your configuration file defined at the [previous step](#set-your-config-file).
@@ -184,8 +184,8 @@ run-scraper:
184184
docker run -t --rm \
185185
-e MEILISEARCH_HOST_URL=$HOST_URL \
186186
-e MEILISEARCH_API_KEY=$API_KEY \
187-
-v $CONFIG_FILE_PATH:/docs-scraper/config.json \
188-
getmeili/docs-scraper:latest pipenv run ./docs_scraper config.json
187+
-v $CONFIG_FILE_PATH:/docs-scraper/<path-to-your-config-file> \
188+
getmeili/docs-scraper:latest pipenv run ./docs_scraper <path-to-your-config-file>
189189
```
190190
191191
⚠️ We do not recommend using the `latest` image in production. Use the [release tags](https://github.com/meilisearch/docs-scraper/releases) instead.

0 commit comments

Comments
 (0)