Bump pylint from 2.3.1 to 2.5.3 (#36)

* Bump pylint from 2.3.1 to 2.5.3

Bumps [pylint](https://github.com/PyCQA/pylint) from 2.3.1 to 2.5.3.
- [Release notes](https://github.com/PyCQA/pylint/releases)
- [Changelog](https://github.com/PyCQA/pylint/blob/master/ChangeLog)
- [Commits](pylint-dev/pylint@pylint-2.3.1...pylint-2.5.3)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* Fix linter errors

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Clementine Urquizar <[email protected]>

Author: dependabot-preview[bot]

Pipfile

@@ -11,7 +11,7 @@ meilisearch = "==0.11.0"
 requests-iap = "==0.2.0"
 
 [dev-packages]
-pylint = "==2.3.1"
+pylint = "==2.5.3"
 
 [requires]
 python_version = "3.6"

Pipfile.lock

@@ -9,6 +9,7 @@
 from distutils.util import strtobool
 import json
 import os
+import sys
 import copy
 
 from .config_validator import ConfigValidator
@@ -104,7 +105,7 @@ def _load_config(self, config):
             return data
         except ValueError:
             raise ValueError('CONFIG is not a valid JSON')
-            exit(EXIT_CODE_WRONG_CONFIG)
+            sys.exit(EXIT_CODE_WRONG_CONFIG)
 
     def _parse(self):
         # Parse Env

scraper/src/config/config_loader.py

@@ -10,6 +10,7 @@
 from scrapy.spiders.sitemap import regex
 import re
 import os
+import sys
 
 # End of import for the sitemap behavior
 
@@ -156,7 +157,7 @@ def add_records(self, response, from_sitemap):
             self.reason_to_stop = "Too much hits, Docs-Scraper only handle {} records".format(
                 int(self.nb_hits_max))
             raise ValueError(self.reason_to_stop)
-            exit(EXIT_CODE_EXCEEDED_RECORDS)
+            sys.exit(EXIT_CODE_EXCEEDED_RECORDS)
 
     def parse_from_sitemap(self, response):
         if self.reason_to_stop is not None:

scraper/src/documentation_spider.py

@@ -1,6 +1,7 @@
+import json
+import unicodedata
 from builtins import input
 from cssselect import HTMLTranslator
-import json
 
 
 def confirm(message="Confirm"):
@@ -29,7 +30,6 @@ def is_number(s):
         pass
 
     try:
-        import unicodedata
         unicodedata.numeric(s)
         return True
     except (TypeError, ValueError):

scraper/src/helpers.py

@@ -2,6 +2,7 @@
 Docs-scraper main entry point
 """
 import os
+import sys
 import json
 import requests
 from requests_iap import IAPAuth
@@ -109,7 +110,7 @@ def run_config(config):
     else:
         print('Crawling issue: nbHits 0 for ' + config.index_uid)
         # meilisearch_helper.report_crawling_issue()
-        exit(EXIT_CODE_NO_RECORD)
+        sys.exit(EXIT_CODE_NO_RECORD)
     print("")
 
 

scraper/src/index.py

@@ -10,6 +10,7 @@
 from ..helpers import to_json
 import json
 import hashlib
+import sys
 
 
 class DefaultStrategy(AbstractStrategy):
@@ -63,7 +64,7 @@ def _update_record_with_global_content(self, record, levels):
     def get_records_from_dom(self, current_page_url=None):
 
         if self.dom is None:
-            exit('DefaultStrategy.dom is not defined')
+            sys.exit('DefaultStrategy.dom is not defined')
 
         # Reset it to be able to have a clean instance when testing
         self.global_content = {}

scraper/src/strategies/default_strategy.py

@@ -1,7 +1,7 @@
 # coding: utf-8
 from ...config.config_loader import ConfigLoader
 from .abstract import config
-
+from .mocked_init import MockedInit
 
 class TestGetExtraFacets:
     def test_extra_facets_should_be_empty_by_default(self):
@@ -13,7 +13,6 @@ def test_extra_facets_should_be_empty_by_default(self):
 
     def test_extra_facets_should_be_set_from_start_urls_variables_browser(self,
                                                                           monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")
@@ -37,7 +36,6 @@ def test_extra_facets_should_be_set_from_start_urls_variables_browser(self,
 
     def test_extra_facets_should_be_set_from_start_urls_variables_with_two_start_url_browser(
             self, monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")
@@ -67,7 +65,6 @@ def test_extra_facets_should_be_set_from_start_urls_variables_with_two_start_url
 
     def test_extra_facets_should_be_set_from_start_urls_variables_with_multiple_tags_browser(
             self, monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")

scraper/src/tests/config_loader/get_extra_facets_test.py

@@ -2,6 +2,7 @@
 from ...config.config_loader import ConfigLoader
 from ...config.browser_handler import BrowserHandler
 from .abstract import config
+from .mocked_init import MockedInit
 
 
 class TestOpenSeleniumBrowser:
@@ -14,7 +15,6 @@ def test_browser_not_needed_by_default(self):
                                                 actual.js_render) is False
 
     def test_browser_needed_when_js_render_true(self, monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")
@@ -30,7 +30,6 @@ def test_browser_needed_when_js_render_true(self, monkeypatch):
 
     def test_browser_needed_when_config_contains_automatic_tag(self,
                                                                monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")

scraper/src/tests/config_loader/open_selenium_browser_test.py

@@ -3,6 +3,7 @@
 
 from ...config.config_loader import ConfigLoader
 from .abstract import config
+from .mocked_init import MockedInit
 
 
 class TestStartUrls:
@@ -70,7 +71,6 @@ def test_start_url_should_be_transform_to_object_if_string(self):
 
     def test_start_urls_should_be_generated_when_there_is_automatic_tagging_browser(
             self, monkeypatch):
-        from .mocked_init import MockedInit
         monkeypatch.setattr("selenium.webdriver.chrome",
                             lambda x: MockedInit())
         monkeypatch.setattr("time.sleep", lambda x: "")