Skip to content

Commit d973df7

Browse files
renehernandezrenehernandez
andauthored
Upgrade scrapy 2.3.0 (#67)
* Remove custom context factory Update scrapy to latest version * Fix Changelog after update * Remove nb_hits update in config file * Remove commented out import * Remove update_nb_hits related logic since is no longer used * Fix pylint complaint * Update scrapy to version 2.3.0 Co-authored-by: renehernandez <[email protected]>
1 parent 72033da commit d973df7

File tree

3 files changed

+27
-9
lines changed

3 files changed

+27
-9
lines changed

Pipfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ verify_ssl = true
44
name = "pypi"
55

66
[packages]
7-
Scrapy = "==2.2.1"
7+
Scrapy = "==2.3.0"
88
selenium = "==3.141.0"
99
pytest = "==6.0.0"
1010
meilisearch = "==0.12.3"

Pipfile.lock

Lines changed: 23 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scraper/src/documentation_spider.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,9 @@ def start_requests(self):
145145
},
146146
errback=self.errback_alternative_link)
147147

148+
def parse(self, response, **kwargs):
149+
return super()._parse(response, **kwargs)
150+
148151
def add_records(self, response, from_sitemap):
149152
records = self.strategy.get_records_from_response(response)
150153
self.meilisearch_helper.add_records(records, response.url, from_sitemap)
@@ -176,7 +179,6 @@ def parse_from_start_url(self, response):
176179

177180
if self.is_rules_compliant(response):
178181
self.add_records(response, from_sitemap=False)
179-
180182
else:
181183
print("\033[94m> Ignored: from start url\033[0m " + response.url)
182184

0 commit comments

Comments
 (0)