Skip to content

Commit e7bd4aa

Browse files
authored
Merge branch 'main' into bump-meilisearch-v0.24.0
2 parents 73ef9fa + 895f1c6 commit e7bd4aa

File tree

3 files changed

+31
-35
lines changed

3 files changed

+31
-35
lines changed

.github/release-draft-template.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,15 @@ version-resolver:
88
- 'breaking-change'
99
default: patch
1010
categories:
11-
- title: 'Breaking changes ⚠️'
11+
- title: '⚠️ Breaking changes'
1212
label: 'breaking-change'
13+
- title: '🚀 Enhancements'
14+
label: 'enhancement'
15+
- title: '🐛 Bug Fixes'
16+
label: 'bug'
17+
- title: '🔒 Security'
18+
label: 'security'
1319
template: |
14-
## Changes
15-
1620
$CHANGES
1721
1822
Thanks again to $CONTRIBUTORS! 🎉

.github/workflows/tests.yml

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,13 @@ jobs:
1515
runs-on: ubuntu-18.04
1616
steps:
1717
- uses: actions/checkout@v2
18+
- name: Install pipenv
19+
run: pipx install pipenv
1820
- name: Set up Python 3.8
19-
uses: actions/setup-python@v1
21+
uses: actions/setup-python@v2
2022
with:
2123
python-version: 3.8
22-
- name: Install pipenv
23-
uses: dschep/install-pipenv-action@v1
24+
cache: "pipenv"
2425
- name: Install dependencies
2526
run: pipenv install --dev
2627
- name: Linter with pylint
@@ -35,16 +36,17 @@ jobs:
3536
runs-on: ubuntu-18.04
3637
steps:
3738
- uses: actions/checkout@v2
39+
- name: Install pipenv
40+
run: pipx install pipenv
3841
- name: Set up Python ${{ matrix.python-version }}
39-
uses: actions/setup-python@v1
42+
uses: actions/setup-python@v2
4043
with:
4144
python-version: ${{ matrix.python-version }}
42-
- name: Install pipenv
43-
uses: dschep/install-pipenv-action@v1
45+
cache: "pipenv"
4446
- name: Install dependencies
4547
run: pipenv install --dev
4648
- name: Run tests
47-
run: pipenv run pytest
49+
run: pipenv run pytest -m "not chromedriver"
4850

4951
integration_tests:
5052
strategy:
@@ -55,28 +57,29 @@ jobs:
5557
runs-on: ubuntu-18.04
5658
steps:
5759
- uses: actions/checkout@v2
60+
- name: Install pipenv
61+
run: pipx install pipenv
5862
- name: Set up Python ${{ matrix.python-version }}
59-
uses: actions/setup-python@v1
63+
uses: actions/setup-python@v2
6064
with:
6165
python-version: ${{ matrix.python-version }}
62-
- name: Install pipenv
63-
uses: dschep/install-pipenv-action@v1
66+
cache: "pipenv"
6467
- name: Install dependencies for production only
6568
run: pipenv install
6669
- name: MeiliSearch setup with Docker
6770
run: docker run -d -p 7700:7700 getmeili/meilisearch:latest ./meilisearch --no-analytics=true --master-key=masterKey
6871
- name: Run the scraper with basic config
6972
run: pipenv run ./docs_scraper $CONFIG_FILE
7073
env:
71-
MEILISEARCH_HOST_URL: 'http://127.0.0.1:7700'
72-
MEILISEARCH_API_KEY: 'masterKey'
73-
CONFIG_FILE: 'tests/config_files_examples/docs-basics.config.json'
74+
MEILISEARCH_HOST_URL: "http://127.0.0.1:7700"
75+
MEILISEARCH_API_KEY: "masterKey"
76+
CONFIG_FILE: "tests/config_files_examples/docs-basics.config.json"
7477
- name: Run the scraper with custom config
7578
run: pipenv run ./docs_scraper $CONFIG_FILE
7679
env:
77-
MEILISEARCH_HOST_URL: 'http://127.0.0.1:7700'
78-
MEILISEARCH_API_KEY: 'masterKey'
79-
CONFIG_FILE: 'tests/config_files_examples/docs-custom.config.json'
80+
MEILISEARCH_HOST_URL: "http://127.0.0.1:7700"
81+
MEILISEARCH_API_KEY: "masterKey"
82+
CONFIG_FILE: "tests/config_files_examples/docs-custom.config.json"
8083

8184
image_build:
8285
name: image-build

CONTRIBUTING.md

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,12 @@
22

33
First of all, thank you for contributing to MeiliSearch! The goal of this document is to provide everything you need to know in order to contribute to MeiliSearch and its different integrations.
44

5-
- [Hacktoberfest](#hacktoberfest)
65
- [Assumptions](#assumptions)
76
- [How to Contribute](#how-to-contribute)
87
- [Development Workflow](#development-workflow)
98
- [Git Guidelines](#git-guidelines)
109
- [Release Process (for internal team only)](#release-process-for-internal-team-only)
1110

12-
## Hacktoberfest
13-
14-
It's [Hacktoberfest month](https://blog.meilisearch.com/contribute-hacktoberfest-2021/)! 🥳
15-
16-
🚀 If your PR gets accepted it will count into your participation to Hacktoberfest!
17-
18-
✅ To be accepted it has either to have been merged, approved or tagged with the `hacktoberfest-accepted` label.
19-
20-
🧐 Don't forget to check the [quality standards](https://hacktoberfest.digitalocean.com/resources/qualitystandards)! Low-quality PRs might get marked as `spam` or `invalid`, and will not count toward your participation in Hacktoberfest.
21-
2211
## Assumptions
2312

2413
1. **You're familiar with [GitHub](https://github.com) and the [Pull Request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests)(PR) workflow.**
@@ -122,7 +111,7 @@ Some notes on GitHub PRs:
122111

123112
- [Convert your PR as a draft](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request) if your changes are a work in progress: no one will review it until you pass your PR as ready for review.<br>
124113
The draft PR can be very useful if you want to show that you are working on something and make your work visible.
125-
- The branch related to the PR must be **up-to-date with `main`** before merging. Fortunately, this project [integrates a bot](https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md) to automatically enforce this requirement without the PR author having to do it manually.
114+
- The branch related to the PR must be **up-to-date with `main`** before merging. Fortunately, this project [integrates a bot](https://github.com/meilisearch/integration-guides/blob/main/resources/bors.md) to automatically enforce this requirement without the PR author having to do it manually.
126115
- All PRs must be reviewed and approved by at least one maintainer.
127116
- The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next [release changelogs](https://github.com/meilisearch/docs-scraper/releases/).
128117

@@ -133,18 +122,18 @@ MeiliSearch tools follow the [Semantic Versioning Convention](https://semver.org
133122
### Automation to Rebase and Merge the PRs <!-- omit in TOC -->
134123

135124
This project integrates a bot that helps us manage pull requests merging.<br>
136-
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md)._
125+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/resources/bors.md)._
137126

138127
### Automated Changelogs <!-- omit in TOC -->
139128

140129
This project integrates a tool to create automated changelogs.<br>
141-
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/release-drafter.md)._
130+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/resources/release-drafter.md)._
142131

143132
### How to Publish the Release <!-- omit in TOC -->
144133

145-
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/guides/integration-release.md).
134+
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md).
146135

147-
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/docs-scraper/releases).
136+
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/docs-scraper/releases): on this page, click on `Edit` (related to the draft release) > update the description (be sure you apply [these recommandations](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md#writting-the-release-description)) > when you are ready, click on `Publish release`.
148137

149138
GitHub Actions will be triggered and push the `latest` and `vX.X.X` version of the Docker image to [DockerHub](https://hub.docker.com/repository/docker/getmeili/docs-scraper).
150139

0 commit comments

Comments
 (0)