Merge pull request #278 from meilisearch/combined-lmdb-support

Combined version of LMDB mdb.master and mdb.master3

Author: Kerollmops

.github/workflows/rust.yml

@@ -28,7 +28,33 @@ jobs:
           cargo clean
           cargo test
 
-  check_all_features:
+  check-heed3:
+    name: Check the heed3 project
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+          - os: windows-latest
+          - os: macos-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+      - name: Run cargo check
+        run: |
+          cargo clean
+          bash convert-to-heed3.sh
+          cargo check -p heed3
+
+  check-all-features:
     name: Check all the features of the heed project
     runs-on: ${{ matrix.os }}
     env:
@@ -51,9 +77,35 @@ jobs:
           override: true
       - name: Run cargo test
         run: |
-          cd heed
           cargo clean
-          cargo check --all-features
+          cargo check --all-features -p heed
+
+  check-all-features-heed3:
+    name: Check all the features of the heed3 project
+    runs-on: ${{ matrix.os }}
+    env:
+      RUSTFLAGS: -D warnings
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+          - os: macos-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+      - name: Run cargo test
+        run: |
+          cargo clean
+          bash convert-to-heed3.sh
+          cargo check --all-features -p heed3
 
   examples:
     name: Run the heed examples
@@ -81,6 +133,31 @@ jobs:
           cargo run --example 2>&1 | grep -E '^ ' | awk '!/rmp-serde/' | xargs -n1 cargo run --example
           cargo run --example rmp-serde --features serde-rmp
 
+  heed3-examples:
+    name: Run the heed3 examples
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+          - os: macos-latest
+
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: stable
+          override: true
+      - name: Run the examples
+        run: |
+          cargo clean
+          bash convert-to-heed3.sh
+          cargo run --example 2>&1 | grep -E '^ '| xargs -n1 cargo run --example
+
   fmt:
     name: Ensure the heed project is formatted
     runs-on: ubuntu-latest
@@ -94,3 +171,11 @@ jobs:
           components: rustfmt
       - name: Run cargo fmt
         run: cargo fmt --check
+
+  no-heed3-in-heed-folder:
+    name: Ensure heed3 is not erasing heed
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - name: Check name is heed with grep
+        run: grep -q 'name = "heed"' heed/Cargo.toml

.gitmodules

@@ -2,3 +2,7 @@
 	path = lmdb-master-sys/lmdb
 	url = https://github.com/LMDB/lmdb
 	branch = mdb.master
+[submodule "lmdb-master3-sys/lmdb"]
+	path = lmdb-master3-sys/lmdb
+	url = https://github.com/LMDB/lmdb
+	branch = mdb.master3

Cargo.toml

@@ -1,3 +1,3 @@
 [workspace]
-members = ["lmdb-master-sys", "heed", "heed-traits", "heed-types"]
+members = ["lmdb-master-sys", "lmdb-master3-sys", "heed", "heed-traits", "heed-types"]
 resolver = "2"

README.md

@@ -1,17 +1,17 @@
 <p align="center"><img width="280px" src="https://raw.githubusercontent.com/meilisearch/heed/main/assets/heed-pigeon-logo.png"></a></p>
-<h1 align="center" >heed</h1>
+<h1 align="center" >heed & heed3</h1>
 
 [![License](https://img.shields.io/badge/license-MIT-green)](#LICENSE)
 [![Crates.io](https://img.shields.io/crates/v/heed)](https://crates.io/crates/heed)
 [![Docs](https://docs.rs/heed/badge.svg)](https://docs.rs/heed)
 [![dependency status](https://deps.rs/repo/github/meilisearch/heed/status.svg)](https://deps.rs/repo/github/meilisearch/heed)
 [![Build](https://github.com/meilisearch/heed/actions/workflows/rust.yml/badge.svg)](https://github.com/meilisearch/heed/actions/workflows/rust.yml)
 
-A Rust-centric [LMDB](https://en.wikipedia.org/wiki/Lightning_Memory-Mapped_Database) abstraction with minimal overhead. This library enables the storage of various Rust types within LMDB, extending support to include Serde-compatible types.
+A Rust-centric [LMDB](https://en.wikipedia.org/wiki/Lightning_Memory-Mapped_Database) abstraction with minimal overhead. This library enables the storage of various Rust types within LMDB, extending support to include Serde-compatible types. It not only supports the LMDB `mdb.master` branch but also the `mdb.master3` branch which features encryption-at-rest and checksumming.
 
 ## Simple Example Usage
 
-Here is an example on how to store and read entries into LMDB in a safe and ACID way. For usage examples, see [heed/examples/](heed/examples/). To see more advanced usage techniques go check our [Cookbook](https://docs.rs/heed/latest/heed/cookbook/index.html).
+Here is an example on how to store and read entries into LMDB in a safe and ACID way. For usage examples, see [examples/](examples/). To see more advanced usage techniques go check our [Cookbook](https://docs.rs/heed/latest/heed/cookbook/index.html).
 
 ```rust
 use std::fs;
@@ -46,6 +46,13 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
 }
 ```
 
+## Working with two Crates: heed and heed3
+
+The heed and heed3 crates manage a shared codebase. Within the heed3 folder, you can find the Cargo.toml specific to the heed3 crate.
+To facilitate work on heed3, utilize the `convert-to-heed3.sh` script.
+
+This script conveniently moves the `heed3/Cargo.toml` file to the `heed/` folder, updates the `heed::` references to `heed3::`, and generates a commit for easy rollback if needed.
+
 ## Building from Source
 
 You can use this command to clone the repository:

convert-to-heed3.sh

@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+# This script is meant to setup the heed3 crate.
+#
+
+if [[ -n $(git status -s) ]]; then
+    echo "Error: Repository is git dirty, please commit or stash changes before running this script."
+    exit 1
+fi
+
+set -e
+
+# It basically copy the heed3/Cargo.toml file into
+# the heed folder...
+if [[ "$OSTYPE" == "cygwin" || "$OSTYPE" == "msys" ]]; then
+    cp heed3\\Cargo.toml heed\\Cargo.toml
+else
+    cp heed3/Cargo.toml heed/Cargo.toml
+fi
+
+# ...and replaces the `heed::` string by the `heed3::` one.
+for file in $(find heed/src -type f -name "*.rs"); do
+    if [[ "$OSTYPE" == "darwin"* ]]; then
+        sed -i '' 's/heed::/heed3::/g' "$file"
+    else
+        sed -i 's/heed::/heed3::/g' "$file"
+    fi
+done
+
+# Make it easier to rollback by doing a commit
+git config --global user.email "[email protected]"
+git config --global user.name "The CI"
+git commit -am 'remove-me: heed3 changes generate by the convert-to-heed3.sh script'
+
+echo "Heed3 crate setup completed successfully. Configurations for the heed crate have been copied and modified."
+echo "A commit (starting with remove-me) has been generated and must be deleted before merging into the main branch."

heed/examples/all-types.rs renamed to examples/all-types.rs

@@ -0,0 +1,111 @@
+use std::error::Error;
+use std::fs;
+use std::path::Path;
+
+use heed3::byteorder::BE;
+use heed3::types::*;
+use heed3::{Database, EnvOpenOptions};
+use serde::{Deserialize, Serialize};
+
+fn main() -> Result<(), Box<dyn Error>> {
+    let path = Path::new("target").join("heed3.mdb");
+
+    fs::create_dir_all(&path)?;
+
+    let env = unsafe {
+        EnvOpenOptions::new()
+            .map_size(10 * 1024 * 1024) // 10MB
+            .max_dbs(3000)
+            .open(path)?
+    };
+
+    // here the key will be an str and the data will be a slice of u8
+    let mut wtxn = env.write_txn()?;
+    let db: Database<Str, Bytes> = env.create_database(&mut wtxn, Some("kiki"))?;
+
+    db.put(&mut wtxn, "hello", &[2, 3][..])?;
+    let ret: Option<&[u8]> = db.get(&wtxn, "hello")?;
+
+    println!("{:?}", ret);
+    wtxn.commit()?;
+
+    // serde types are also supported!!!
+    #[derive(Debug, Serialize, Deserialize)]
+    struct Hello<'a> {
+        string: &'a str,
+    }
+
+    let mut wtxn = env.write_txn()?;
+    let db: Database<Str, SerdeBincode<Hello>> =
+        env.create_database(&mut wtxn, Some("serde-bincode"))?;
+
+    let hello = Hello { string: "hi" };
+    db.put(&mut wtxn, "hello", &hello)?;
+
+    let ret: Option<Hello> = db.get(&wtxn, "hello")?;
+    println!("serde-bincode:\t{:?}", ret);
+
+    wtxn.commit()?;
+
+    let mut wtxn = env.write_txn()?;
+    let db: Database<Str, SerdeJson<Hello>> = env.create_database(&mut wtxn, Some("serde-json"))?;
+
+    let hello = Hello { string: "hi" };
+    db.put(&mut wtxn, "hello", &hello)?;
+
+    let ret: Option<Hello> = db.get(&wtxn, "hello")?;
+    println!("serde-json:\t{:?}", ret);
+
+    wtxn.commit()?;
+
+    // you can ignore the data
+    let mut wtxn = env.write_txn()?;
+    let db: Database<Str, Unit> = env.create_database(&mut wtxn, Some("ignored-data"))?;
+
+    db.put(&mut wtxn, "hello", &())?;
+    let ret: Option<()> = db.get(&wtxn, "hello")?;
+
+    println!("{:?}", ret);
+
+    let ret: Option<()> = db.get(&wtxn, "non-existant")?;
+
+    println!("{:?}", ret);
+    wtxn.commit()?;
+
+    // database opening and types are tested in a safe way
+    //
+    // we try to open a database twice with the same types
+    let mut wtxn = env.write_txn()?;
+    let _db: Database<Str, Unit> = env.create_database(&mut wtxn, Some("ignored-data"))?;
+
+    // you can iterate over keys in order
+    type BEI64 = I64<BE>;
+
+    let db: Database<BEI64, Unit> = env.create_database(&mut wtxn, Some("big-endian-iter"))?;
+
+    db.put(&mut wtxn, &0, &())?;
+    db.put(&mut wtxn, &68, &())?;
+    db.put(&mut wtxn, &35, &())?;
+    db.put(&mut wtxn, &42, &())?;
+
+    let rets: Result<Vec<(i64, _)>, _> = db.iter(&wtxn)?.collect();
+
+    println!("{:?}", rets);
+
+    // or iterate over ranges too!!!
+    let range = 35..=42;
+    let rets: Result<Vec<(i64, _)>, _> = db.range(&wtxn, &range)?.collect();
+
+    println!("{:?}", rets);
+
+    // delete a range of key
+    let range = 35..=42;
+    let deleted: usize = db.delete_range(&mut wtxn, &range)?;
+
+    let rets: Result<Vec<(i64, _)>, _> = db.iter(&wtxn)?.collect();
+
+    println!("deleted: {:?}, {:?}", deleted, rets);
+    wtxn.commit()?;
+
+    Ok(())
+}