Make clippy happy

Author: Kerollmops

heed-types/src/integer.rs

@@ -11,7 +11,7 @@ pub struct U8;
 impl BytesEncode<'_> for U8 {
     type EItem = u8;
 
-    fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         Ok(Cow::from([*item].to_vec()))
     }
 }
@@ -30,7 +30,7 @@ pub struct I8;
 impl BytesEncode<'_> for I8 {
     type EItem = i8;
 
-    fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         Ok(Cow::from([*item as u8].to_vec()))
     }
 }
@@ -54,7 +54,7 @@ macro_rules! define_type {
         impl<O: ByteOrder> BytesEncode<'_> for $name<O> {
             type EItem = $native;
 
-            fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+            fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
                 let mut buf = vec![0; size_of::<Self::EItem>()];
                 O::$write_method(&mut buf, *item);
                 Ok(Cow::from(buf))

heed-types/src/serde_json.rs

@@ -14,7 +14,7 @@ where
 {
     type EItem = T;
 
-    fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         serde_json::to_vec(item).map(Cow::Owned).map_err(Into::into)
     }
 }

heed-types/src/serde_rmp.rs

@@ -14,7 +14,7 @@ where
 {
     type EItem = T;
 
-    fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         rmp_serde::to_vec(item).map(Cow::Owned).map_err(Into::into)
     }
 }

heed-types/src/str.rs

@@ -9,7 +9,7 @@ pub enum Str {}
 impl BytesEncode<'_> for Str {
     type EItem = str;
 
-    fn bytes_encode(item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         Ok(Cow::Borrowed(item.as_bytes()))
     }
 }

heed-types/src/unit.rs

@@ -9,7 +9,7 @@ pub enum Unit {}
 impl BytesEncode<'_> for Unit {
     type EItem = ();
 
-    fn bytes_encode(_item: &Self::EItem) -> Result<Cow<[u8]>, BoxedError> {
+    fn bytes_encode(_item: &Self::EItem) -> Result<Cow<'_, [u8]>, BoxedError> {
         Ok(Cow::Borrowed(&[]))
     }
 }

heed/src/envs/encrypted_env.rs

@@ -103,7 +103,9 @@ impl<T> EncryptedEnv<T> {
     }
 
     /// Options and flags which can be used to configure how a [`Database`] is opened.
-    pub fn database_options(&self) -> EncryptedDatabaseOpenOptions<T, Unspecified, Unspecified> {
+    pub fn database_options(
+        &self,
+    ) -> EncryptedDatabaseOpenOptions<'_, '_, T, Unspecified, Unspecified> {
         EncryptedDatabaseOpenOptions::new(self)
     }
 
@@ -174,7 +176,7 @@ impl<T> EncryptedEnv<T> {
     /// If another write transaction is initiated, while another write transaction exists
     /// the thread initiating the new one will wait on a mutex upon completion of the previous
     /// transaction.
-    pub fn write_txn(&self) -> Result<RwTxn> {
+    pub fn write_txn(&self) -> Result<RwTxn<'_>> {
         self.inner.write_txn()
     }
 
@@ -215,7 +217,7 @@ impl<T> EncryptedEnv<T> {
     ///   map must be resized
     /// * [`crate::MdbError::ReadersFull`]: a read-only transaction was requested, and the reader lock table is
     ///   full
-    pub fn read_txn(&self) -> Result<RoTxn<T>> {
+    pub fn read_txn(&self) -> Result<RoTxn<'_, T>> {
         self.inner.read_txn()
     }
 

heed/src/envs/env.rs

@@ -195,7 +195,7 @@ impl<T> Env<T> {
     }
 
     /// Options and flags which can be used to configure how a [`Database`] is opened.
-    pub fn database_options(&self) -> DatabaseOpenOptions<T, Unspecified, Unspecified> {
+    pub fn database_options(&self) -> DatabaseOpenOptions<'_, '_, T, Unspecified, Unspecified> {
         DatabaseOpenOptions::new(self)
     }
 
@@ -331,7 +331,7 @@ impl<T> Env<T> {
     /// If another write transaction is initiated, while another write transaction exists
     /// the thread initiating the new one will wait on a mutex upon completion of the previous
     /// transaction.
-    pub fn write_txn(&self) -> Result<RwTxn> {
+    pub fn write_txn(&self) -> Result<RwTxn<'_>> {
         RwTxn::new(self)
     }
 
@@ -372,7 +372,7 @@ impl<T> Env<T> {
     ///   map must be resized
     /// * [`crate::MdbError::ReadersFull`]: a read-only transaction was requested, and the reader lock table is
     ///   full
-    pub fn read_txn(&self) -> Result<RoTxn<T>> {
+    pub fn read_txn(&self) -> Result<RoTxn<'_, T>> {
         RoTxn::new(self)
     }
 
@@ -594,7 +594,7 @@ impl<T> Env<T> {
     /// it is okay to call `mdb_env_set_mapsize` for an open environment as long as no transactions are active,
     /// but the library does not check for this condition, so the caller must ensure it explicitly.
     pub unsafe fn resize(&self, new_size: usize) -> Result<()> {
-        if new_size % page_size::get() != 0 {
+        if !new_size.is_multiple_of(page_size::get()) {
             let msg = format!(
                 "map size ({}) must be a multiple of the system page size ({})",
                 new_size,

heed/src/envs/env_open_options.rs

@@ -1,6 +1,4 @@
 use std::ffi::CString;
-#[cfg(windows)]
-use std::ffi::OsStr;
 use std::io::ErrorKind::NotFound;
 use std::marker::PhantomData;
 #[cfg(unix)]