From fbc985250c0fcc7774ef5f9d1c53b7effe9a7d5a Mon Sep 17 00:00:00 2001 From: joonseolee Date: Thu, 14 Aug 2025 08:00:38 +0900 Subject: [PATCH 1/2] Add disableOnNumbers setting in TypoTolerance --- .code-samples.meilisearch.yaml | 4 ++++ .../meilisearch/sdk/model/TypoTolerance.java | 1 + .../meilisearch/integration/SettingsTest.java | 18 ++++++++++++++++++ 3 files changed, 23 insertions(+) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index d46b4f9f..5080a9bf 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -452,6 +452,10 @@ typo_tolerance_guide_4: |- }; typoTolerance.setMinWordSizeForTypos(minWordSizeTypos); client.index("movies").updateTypoToleranceSettings(typoTolerance); +typo_tolerance_guide_5: |- + TypoTolerance typoTolerance = new TypoTolerance(); + typoTolerance.setDisableOnNumbers(true); + client.index("1917").updateTypoToleranceSettings(typoTolerance); getting_started_add_documents: |- // For Maven: // Add the following code to the `` section of your project: diff --git a/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java b/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java index 284b680c..5e33c290 100644 --- a/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java +++ b/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java @@ -19,6 +19,7 @@ public class TypoTolerance { protected HashMap minWordSizeForTypos; protected String[] disableOnWords; protected String[] disableOnAttributes; + protected boolean disableOnNumbers; public TypoTolerance() {} } diff --git a/src/test/java/com/meilisearch/integration/SettingsTest.java b/src/test/java/com/meilisearch/integration/SettingsTest.java index a8dbbbe0..eff9738d 100644 --- a/src/test/java/com/meilisearch/integration/SettingsTest.java +++ b/src/test/java/com/meilisearch/integration/SettingsTest.java @@ -900,6 +900,24 @@ public void testResetTypoTolerance() throws Exception { is(notNullValue())); } + @Test + @DisplayName("Test update disableOnNumbers tolerance settings") + public void testUpdateDisableOnNumbersTolerance() throws Exception { + Index index = createIndex("testUpdateDisableOnNumbers"); + + TypoTolerance newTypoTolerance = new TypoTolerance(); + index.waitForTask(index.updateTypoToleranceSettings(newTypoTolerance).getTaskUid()); + TypoTolerance updatedTypoToleranceDefault = index.getTypoToleranceSettings(); + + TypoTolerance newTypoToleranceDisableOnNumbers = new TypoTolerance(); + newTypoToleranceDisableOnNumbers.setDisableOnNumbers(true); + index.waitForTask(index.updateTypoToleranceSettings(newTypoToleranceDisableOnNumbers).getTaskUid()); + TypoTolerance updatedTypoToleranceDisableOnNumbers = index.getTypoToleranceSettings(); + + assertThat(updatedTypoToleranceDefault.isDisableOnNumbers(), is(equalTo(false))); + assertThat(updatedTypoToleranceDisableOnNumbers.isDisableOnNumbers(), is(equalTo(true))); + } + /** Tests of all the specifics setting methods when null is passed */ @Test @DisplayName("Test update synonyms settings when null is passed") From 8a976a4f6d720698069bc845bea01cc6629e16c6 Mon Sep 17 00:00:00 2001 From: Joonseo Lee Date: Sat, 13 Sep 2025 13:43:16 +0900 Subject: [PATCH 2/2] Change disableOnNumbers to nullable Boolean for partial updates --- .code-samples.meilisearch.yaml | 2 +- .../com/meilisearch/sdk/model/TypoTolerance.java | 2 +- .../com/meilisearch/integration/SettingsTest.java | 14 ++++++-------- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/.code-samples.meilisearch.yaml b/.code-samples.meilisearch.yaml index 5080a9bf..c3db7b1e 100644 --- a/.code-samples.meilisearch.yaml +++ b/.code-samples.meilisearch.yaml @@ -455,7 +455,7 @@ typo_tolerance_guide_4: |- typo_tolerance_guide_5: |- TypoTolerance typoTolerance = new TypoTolerance(); typoTolerance.setDisableOnNumbers(true); - client.index("1917").updateTypoToleranceSettings(typoTolerance); + client.index("movies").updateTypoToleranceSettings(typoTolerance); getting_started_add_documents: |- // For Maven: // Add the following code to the `` section of your project: diff --git a/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java b/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java index 5e33c290..bbfc0ebf 100644 --- a/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java +++ b/src/main/java/com/meilisearch/sdk/model/TypoTolerance.java @@ -19,7 +19,7 @@ public class TypoTolerance { protected HashMap minWordSizeForTypos; protected String[] disableOnWords; protected String[] disableOnAttributes; - protected boolean disableOnNumbers; + protected Boolean disableOnNumbers; public TypoTolerance() {} } diff --git a/src/test/java/com/meilisearch/integration/SettingsTest.java b/src/test/java/com/meilisearch/integration/SettingsTest.java index eff9738d..e05b1b7c 100644 --- a/src/test/java/com/meilisearch/integration/SettingsTest.java +++ b/src/test/java/com/meilisearch/integration/SettingsTest.java @@ -904,18 +904,16 @@ public void testResetTypoTolerance() throws Exception { @DisplayName("Test update disableOnNumbers tolerance settings") public void testUpdateDisableOnNumbersTolerance() throws Exception { Index index = createIndex("testUpdateDisableOnNumbers"); - - TypoTolerance newTypoTolerance = new TypoTolerance(); - index.waitForTask(index.updateTypoToleranceSettings(newTypoTolerance).getTaskUid()); - TypoTolerance updatedTypoToleranceDefault = index.getTypoToleranceSettings(); + TypoTolerance defaultTypoTolerance = index.getTypoToleranceSettings(); TypoTolerance newTypoToleranceDisableOnNumbers = new TypoTolerance(); newTypoToleranceDisableOnNumbers.setDisableOnNumbers(true); - index.waitForTask(index.updateTypoToleranceSettings(newTypoToleranceDisableOnNumbers).getTaskUid()); - TypoTolerance updatedTypoToleranceDisableOnNumbers = index.getTypoToleranceSettings(); + index.waitForTask( + index.updateTypoToleranceSettings(newTypoToleranceDisableOnNumbers).getTaskUid()); + TypoTolerance updatedTypoTolerance = index.getTypoToleranceSettings(); - assertThat(updatedTypoToleranceDefault.isDisableOnNumbers(), is(equalTo(false))); - assertThat(updatedTypoToleranceDisableOnNumbers.isDisableOnNumbers(), is(equalTo(true))); + assertThat(defaultTypoTolerance.getDisableOnNumbers(), is(equalTo(false))); + assertThat(updatedTypoTolerance.getDisableOnNumbers(), is(equalTo(true))); } /** Tests of all the specifics setting methods when null is passed */