Skip to content

Commit 682a604

Browse files
Merge #1331
1331: Fix wrong meilisearch client being imported in UMD bundle r=curquiza a=flevi29 # Pull Request ## Related issue Fixes #1330 ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: F. Levi <[email protected]>
2 parents 5870e0b + 1e7bf78 commit 682a604

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.changeset/big-swans-cover.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@meilisearch/instant-meilisearch": patch
3+
---
4+
5+
Fix wrong "meilisearch" client being imported in UMD bundle.

packages/instant-meilisearch/rollup.config.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ const ROLLUP_OPTIONS = [
3838
// browser-friendly IIFE build
3939
{
4040
input: INPUT, // directory to transpilation of typescript
41-
external: ['cross-fetch', 'cross-fetch/polyfill'],
4241
output: {
4342
name: 'window',
4443
extend: true,
@@ -55,11 +54,7 @@ const ROLLUP_OPTIONS = [
5554
},
5655
plugins: [
5756
...COMMON_PLUGINS,
58-
nodeResolve({
59-
mainFields: ['jsnext', 'browser', 'main'],
60-
preferBuiltins: true,
61-
browser: true,
62-
}),
57+
nodeResolve({ exportConditions: ['browser'] }),
6358
commonjs(),
6459
babel(),
6560
// json(),

0 commit comments

Comments
 (0)