Skip to content

Commit 684256b

Browse files
Merge #1134
1134: Update meilisearch js to v0.33.0 r=bidoubiwa a=bidoubiwa Update meilisearch-js to v0.33.0 and fix a failing tests introduced by the new version of Meilisearch (the engine) v1.2.0. This failing test is due to a change in the way the cropping is processed on Meilisearch sides and is considered not a breaking change. The test was changed to be more robust. Co-authored-by: Charlotte Vermandel <[email protected]>
2 parents 7ced091 + 53affc1 commit 684256b

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

packages/instant-meilisearch/__tests__/snippets.test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ describe('Snippet Browser test', () => {
214214
{
215215
indexName: 'movies',
216216
params: {
217-
query: 'm',
217+
query: 'night',
218218
attributesToSnippet: ['overview:1', 'title:1'],
219219
snippetEllipsisText: '…',
220220
},
@@ -223,16 +223,16 @@ describe('Snippet Browser test', () => {
223223

224224
const firstHit = response.results[0]?.hits[0]?._snippetResult
225225
expect(firstHit).toHaveProperty('title', {
226-
value: '__ais-highlight__M__/ais-highlight__agnetic…',
226+
value: '__ais-highlight__Night__/ais-highlight__',
227227
})
228-
expect(firstHit).toHaveProperty('overview', { value: '' })
228+
expect(firstHit).toHaveProperty('overview', { value: 'While…' })
229229

230230
const secondHit = response.results[0].hits[1]._snippetResult
231231
expect(secondHit).toHaveProperty('title', {
232-
value: 'Judgment…',
232+
value: 'Four…',
233233
})
234234
expect(secondHit).toHaveProperty('overview', {
235-
value: '…__ais-highlight__m__/ais-highlight__atch…',
235+
value: '…__ais-highlight__night__/ais-highlight__…',
236236
})
237237
})
238238

packages/instant-meilisearch/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
"templates"
4848
],
4949
"dependencies": {
50-
"meilisearch": "^0.32.1"
50+
"meilisearch": "^0.33.0"
5151
},
5252
"devDependencies": {
5353
"@babel/cli": "^7.21.0",

yarn.lock

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -5229,12 +5229,12 @@ [email protected]:
52295229
postcss "^8.3.7"
52305230
pretty-bytes "^5.3.0"
52315231

5232-
cross-fetch@^3.1.5:
5233-
version "3.1.5"
5234-
resolved "https://registry.yarnpkg.com/cross-fetch/-/cross-fetch-3.1.5.tgz#e1389f44d9e7ba767907f7af8454787952ab534f"
5235-
integrity sha512-lvb1SBsI0Z7GDwmuid+mU3kWVBwTVUbe7S0H52yaaAdQOXq2YktTCZdlAcNKFzE6QtRz0snpw9bNiPeOIkkQvw==
5232+
cross-fetch@^3.1.6:
5233+
version "3.1.6"
5234+
resolved "https://registry.yarnpkg.com/cross-fetch/-/cross-fetch-3.1.6.tgz#bae05aa31a4da760969756318feeee6e70f15d6c"
5235+
integrity sha512-riRvo06crlE8HiqOwIpQhxwdOk4fOeR7FVM/wXoxchFEqMNUjvbs3bfo4OTgMEMHzppd4DxFBDbyySj8Cv781g==
52365236
dependencies:
5237-
node-fetch "2.6.7"
5237+
node-fetch "^2.6.11"
52385238

52395239
cross-spawn@^5.1.0:
52405240
version "5.1.0"
@@ -9756,12 +9756,12 @@ [email protected]:
97569756
resolved "https://registry.yarnpkg.com/media-typer/-/media-typer-0.3.0.tgz#8710d7af0aa626f8fffa1ce00168545263255748"
97579757
integrity sha512-dq+qelQ9akHpcOl/gUVRTxVIOkAJ1wR3QAvb4RsVjS8oVoFjDGTc679wJYmUmknUF5HwMLOgb5O+a3KxfWapPQ==
97589758

9759-
meilisearch@^0.32.1:
9760-
version "0.32.1"
9761-
resolved "https://registry.yarnpkg.com/meilisearch/-/meilisearch-0.32.1.tgz#3b09a3d2a5d70949c38f410a53c22f0136d4e8f6"
9762-
integrity sha512-ceC0TSKL7GF91b50y1Qb2lKUUF/d5uZ242Iry093cTDRO3KfL/lcSwXxNxKzluk71iBPH0A0cKAIy6v06sPriA==
9759+
meilisearch@^0.33.0:
9760+
version "0.33.0"
9761+
resolved "https://registry.yarnpkg.com/meilisearch/-/meilisearch-0.33.0.tgz#25982b193cdd22e9ec534a022dbde89c42951dc4"
9762+
integrity sha512-bYPb9WyITnJfzf92e7QFK8Rc50DmshFWxypXCs3ILlpNh8pT15A7KSu9Xgnnk/K3G/4vb3wkxxtFS4sxNkWB8w==
97639763
dependencies:
9764-
cross-fetch "^3.1.5"
9764+
cross-fetch "^3.1.6"
97659765

97669766
memfs@^3.4.12, memfs@^3.4.3:
97679767
version "3.4.13"
@@ -10194,10 +10194,10 @@ node-addon-api@^3.0.0:
1019410194
resolved "https://registry.yarnpkg.com/node-addon-api/-/node-addon-api-3.2.1.tgz#81325e0a2117789c0128dab65e7e38f07ceba161"
1019510195
integrity sha512-mmcei9JghVNDYydghQmeDX8KoAm0FAiYyIcUt/N4nhyAipB17pllZQDOJD2fotxABnt4Mdz+dKTO7eftLg4d0A==
1019610196

10197-
10198-
version "2.6.7"
10199-
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.7.tgz#24de9fba827e3b4ae44dc8b20256a379160052ad"
10200-
integrity sha512-ZjMPFEfVx5j+y2yF35Kzx5sF7kDzxuDj6ziH4FFbOp87zKDZNx8yExJIb05OGF4Nlt9IHFIMBkRl41VdvcNdbQ==
10197+
node-fetch@^2.6.11:
10198+
version "2.6.11"
10199+
resolved "https://registry.yarnpkg.com/node-fetch/-/node-fetch-2.6.11.tgz#cde7fc71deef3131ef80a738919f999e6edfff25"
10200+
integrity sha512-4I6pdBY1EthSqDmJkiNk3JIT8cswwR9nfeW/cPdUagJYEQG7R95WRH74wpz7ma8Gh/9dI9FP+OU+0E4FvtA55w==
1020110201
dependencies:
1020210202
whatwg-url "^5.0.0"
1020310203

0 commit comments

Comments
 (0)