Skip to content

Commit b39d07e

Browse files
committed
Fix merge conflicts
2 parents 7fcdbba + 7089dc6 commit b39d07e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

55 files changed

+11536
-4603
lines changed

.github/release-draft-template.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,5 @@ replacers:
2525
replace: ''
2626
- search: '/(?:and )?@bors(?:\[bot\])?,?/g'
2727
replace: ''
28+
- search: '/(?:and )?@meili-bot,?/g'
29+
replace: ''

.github/workflows/test.yml

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,9 @@ jobs:
2424
run: yarn test
2525
- name: Build project
2626
run: yarn build
27-
- name: Run ESM demo
28-
run: yarn test:demo:esm
29-
- name: Run Node.js demo
30-
run: yarn test:demo:nodejs
31-
- name: Run Browser demo
32-
run: yarn test:demo:browser
27+
- name: Run env tests
28+
run: yarn test:env
29+
3330

3431
style:
3532
name: style-check
@@ -50,9 +47,5 @@ jobs:
5047
- uses: actions/checkout@v1
5148
- name: Install dependencies
5249
run: yarn install
53-
- name: Run Vue build
54-
run: yarn build:playground:vue
55-
- name: Run React build
56-
run: yarn build:playground:react
57-
- name: Run Vanilla JS build
58-
run: yarn build:playground:vanilla-js
50+
- name: Run Playgrounds Builds
51+
run: yarn test:playgrounds

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,3 +105,6 @@ dist
105105

106106
# misc
107107
.DS_Store
108+
109+
# parcel
110+
.parcel_cache/

CONTRIBUTING.md

Lines changed: 45 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
88
- [How to Contribute](#how-to-contribute)
99
- [Development Workflow](#development-workflow)
1010
- [Git Guidelines](#git-guidelines)
11+
- [Release Process (for internal team only)](#release-process-for-internal-team-only)
1112

1213
<!-- /MarkdownTOC -->
1314

@@ -23,7 +24,7 @@ First of all, thank you for contributing to MeiliSearch! The goal of this docume
2324
2. Once done, [fork the instant-meilisearch repository](https://help.github.com/en/github/getting-started-with-github/fork-a-repo) in your own GitHub account. Ask a maintainer if you want your issue to be checked before making a PR.
2425
3. [Create a new Git branch](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-and-deleting-branches-within-your-repository).
2526
4. Review the [Development Workflow](#workflow) section that describes the steps to maintain the repository.
26-
5. Make your changes.
27+
5. Make the changes on your branch.
2728
6. [Submit the branch as a PR](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork) pointing to the `master` branch of the main instant-meilisearch repository. A maintainer should comment and/or review your Pull Request within a few days. Although depending on the circumstances, it may take longer.<br>
2829
We do not enforce a naming convention for the PRs, but **please use something descriptive of your changes**, having in mind that the title of your PR will be automatically added to the next [release changelog](https://github.com/meilisearch/instant-meilisearch/releases/).
2930

@@ -68,40 +69,15 @@ Or the React playground:
6869
$ yarn playground:react
6970
```
7071

71-
Or the Vanilla JavaScript playground:
72+
Or the JavaScript playground:
7273
```
73-
$ yarn playground:vanilla-js
74+
$ yarn playground:javascript
7475
```
7576

76-
### Release Process
77-
78-
MeiliSearch tools follow the [Semantic Versioning Convention](https://semver.org/).
79-
80-
#### Automated Changelogs
81-
82-
For each PR merged on `master`, a GitHub Action is running and updates the next release description as a draft release in the [GitHub interface](https://github.com/meilisearch/instant-meilisearch/releases). If you don't have the right access to this repository, you will not be able to see the draft release until the release is published.
83-
84-
The draft release description is therefore generated and corresponds to all the PRs titles since the previous release. This means each PR should only do one change and the title should be descriptive of this change.
85-
86-
About this automation:
87-
- As the draft release description is generated on every push on `master`, don't change it manually until the final release publishment.
88-
- If you don't want a PR to appear in the release changelogs: add the label `skip-changelog`. We suggest removing PRs updating the README or the CI (except for big changes).
89-
- If the changes you are doing in the PR are breaking: add the label `breaking-change`. In the release tag, the minor will be increased instead of the patch. The major will never be changed until [MeiliSearch](https://github.com/meilisearch/MeiliSearch) is stable.
90-
- If you did any mistake, for example the PR is already closed but you forgot to add a label or you misnamed your PR, don't panic: change what you want in the closed PR and run the job again.
91-
92-
*More information about the [Release Drafter](https://github.com/release-drafter/release-drafter), used to automate these steps.*
93-
94-
#### How to Publish the Release
95-
96-
Make a PR modifying the file [`package.json`](/package.json) with the right version.
97-
98-
```javascript
99-
"version": "X.X.X"
77+
Or the HTML playground:
78+
```
79+
$ yarn playground:html
10080
```
101-
102-
Once the changes are merged on `master`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/instant-meilisearch/releases).
103-
104-
A GitHub Action will be triggered and push the package to [npm](https://www.npmjs.com/package/@meilisearch/instant-meilisearch).
10581

10682
## Git Guidelines
10783

@@ -123,11 +99,47 @@ We don't follow any other convention, but if you want to use one, we recommend [
12399
### GitHub Pull Requests
124100

125101
Some notes on GitHub PRs:
102+
126103
- [Convert your PR as a draft](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request) if your changes are a work in progress: no one will review it until you pass your PR as ready for review.<br>
127104
The draft PR can be very useful if you want to show that you are working on something and make your work visible.
128-
- The branch related to the PR must be **up-to-date with `master`** before merging. You need to [rebase your branch](https://gist.github.com/curquiza/5f7ce615f85331f083cd467fc4e19398) if it is not.
105+
- The branch related to the PR must be **up-to-date with `master`** before merging. Fortunately, this project [integrates a bot](https://github.com/meilisearch/integration-guides/blob/master/guides/bors.md) to automatically enforce this requirement without the PR author having to do it manually..
129106
- All PRs must be reviewed and approved by at least one maintainer.
130-
- All PRs have to be **squashed and merged**.
131107
- The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next [release changelogs](https://github.com/meilisearch/instant-meilisearch/releases/).
132108

109+
## Release Process (for internal team only)
110+
111+
MeiliSearch tools follow the [Semantic Versioning Convention](https://semver.org/).
112+
113+
### Automation to Rebase and Merge the PRs
114+
115+
This project integrates a bot that helps us manage pull requests merging.<br>
116+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/master/guides/bors.md)._
117+
118+
### Automated Changelogs
119+
120+
This project integrates a tool to create automated changelogs.<br>
121+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/master/guides/release-drafter.md)._
122+
123+
### How to Publish the Release
124+
125+
Make a PR modifying the file [`package.json`](/package.json) with the right version.
126+
127+
```javascript
128+
"version": "X.X.X"
129+
```
130+
131+
Once the changes are merged on `master`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/instant-meilisearch/releases).
132+
133+
GitHub Actions will be triggered and push the package to [npm](https://www.npmjs.com/package/@meilisearch/instant-meilisearch).
134+
135+
Once the version is available on npm, please update the instant-meilisearch version used in the different Code-Sandboxes we provide:
136+
137+
- [MeiliSearch + InstantSearch](https://codesandbox.io/s/ms-is-mese9)
138+
- [MeiliSearch + Vue InstantSearch](https://codesandbox.io/s/ms-vue-is-1d6bi)
139+
- [MeiliSearch + React InstantSearch](https://codesandbox.io/s/ms-react-is-sh9ud)
140+
141+
If you don't have the access to do it, please request it internally.
142+
143+
<hr>
144+
133145
Thank you again for reading this through, we can not wait to begin to work with you if you made your way through this contributing guide ❤️

LICENSE

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
MIT License
22

3-
Copyright (c) 2020 MeiliSearch
3+
Copyright (c) 2020-2021 MeiliSearch
44

55
Permission is hereby granted, free of charge, to any person obtaining a copy
66
of this software and associated documentation files (the "Software"), to deal

README.md

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,25 +7,23 @@
77
<h4 align="center">
88
<a href="https://github.com/meilisearch/MeiliSearch">MeiliSearch</a> |
99
<a href="https://docs.meilisearch.com">Documentation</a> |
10+
<a href="https://slack.meilisearch.com">Slack</a> |
1011
<a href="https://roadmap.meilisearch.com/tabs/1-under-consideration">Roadmap</a> |
1112
<a href="https://www.meilisearch.com">Website</a> |
12-
<a href="https://blog.meilisearch.com">Blog</a> |
13-
<a href="https://twitter.com/meilisearch">Twitter</a> |
1413
<a href="https://docs.meilisearch.com/faq">FAQ</a>
1514
</h4>
1615

1716
<p align="center">
1817
<a href="https://www.npmjs.com/package/@meilisearch/instant-meilisearch"><img src="https://img.shields.io/npm/v/@meilisearch/instant-meilisearch.svg" alt="npm version"></a>
1918
<a href="https://github.com/meilisearch/instant-meilisearch/actions"><img src="https://github.com/meilisearch/instant-meilisearch/workflows/Tests/badge.svg?branch=master" alt="Tests"></a>
2019
<a href="https://github.com/meilisearch/instant-meilisearch/blob/master/LICENSE"><img src="https://img.shields.io/badge/license-MIT-informational" alt="License"></a>
21-
<a href="https://slack.meilisearch.com"><img src="https://img.shields.io/badge/slack-MeiliSearch-blue.svg?logo=slack" alt="Slack"></a>
2220
<a href="https://github.com/meilisearch/MeiliSearch/discussions" alt="Discussions"><img src="https://img.shields.io/badge/github-discussions-red" /></a>
2321
<a href="https://app.bors.tech/repositories/28908"><img src="https://bors.tech/images/badge_small.svg" alt="Bors enabled"></a>
2422
</p>
2523

2624
<p align="center">⚡ How to integrate a front-end search bar in your website using MeiliSearch</p>
2725

28-
**MeiliSearch** is a powerful, fast, open-source, easy to use and deploy search engine. Both searching and indexing are highly customizable. Features such as typo-tolerance, filters, facets, and synonyms are provided out-of-the-box.
26+
**MeiliSearch** is an open-source search engine. [Discover what MeiliSearch is!](https://github.com/meilisearch/MeiliSearch)
2927

3028
This library is a plugin to establish the communication between your [MeiliSearch](https://github.com/meilisearch/MeiliSearch) instance and the open-source [InstantSearch](https://github.com/algolia/instantsearch.js) tools (powered by Algolia) for your front-end application.<br>
3129
Instead of reinventing the wheel, we have opted to reuse the InstantSearch library for our own front-end tooling. We will contribute upstream any improvements that may result from our adoption of InstantSearch.
@@ -37,11 +35,25 @@ If you use React or Vue, you might want to check out these repositories:
3735

3836
NB: If you don't have any MeiliSearch instance running and containing your data, you should take a look at this [getting started page](https://docs.meilisearch.com/guides/introduction/quick_start_guide.html).
3937

38+
## Installation
39+
40+
Use `npm` or `yarn` to install `instant-meilisearch`:
41+
42+
```bash
43+
$ npm install @meilisearch/instant-meilisearch
44+
```
45+
46+
```bash
47+
$ yarn add @meilisearch/instant-meilisearch
48+
```
49+
4050
## Usage
4151

4252
### Basic
4353

4454
```js
55+
import instantMeiliSearch from "@meilisearch/instant-meilisearch";
56+
4557
const searchClient = instantMeiliSearch(
4658
"https://demos.meilisearch.com",
4759
"dc3fedaf922de8937fdea01f0a7d59557f1fd31832cb8440ce94231cfdde7f25"
@@ -51,6 +63,8 @@ const searchClient = instantMeiliSearch(
5163
### Customization
5264

5365
```js
66+
import instantMeiliSearch from "@meilisearch/instant-meilisearch";
67+
5468
const searchClient = instantMeiliSearch(
5569
"https://demos.meilisearch.com",
5670
"dc3fedaf922de8937fdea01f0a7d59557f1fd31832cb8440ce94231cfdde7f25",
@@ -143,7 +157,7 @@ search.start();
143157

144158
## Compatibility with MeiliSearch
145159

146-
This package only guarantees the compatibility with the [version v0.16.0 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.16.0).
160+
This package only guarantees the compatibility with the [version v0.18.1 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.18.1).
147161

148162
## Development Workflow and Contributing
149163

examples/express/.DS_Store

-6 KB
Binary file not shown.

examples/express/public/instant-meilisearch.umd.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

examples/express/tests/client.test.js

Lines changed: 0 additions & 11 deletions
This file was deleted.

examples/node/index.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)