Skip to content

Commit d6e0e8e

Browse files
committed
Merge branch 'main' of github.com:meilisearch/instant-meilisearch into bump-meilisearch-v0.24.0
2 parents bdcd661 + f1522bd commit d6e0e8e

File tree

19 files changed

+323
-417
lines changed

19 files changed

+323
-417
lines changed

.github/release-draft-template.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,15 @@ version-resolver:
88
- 'breaking-change'
99
default: patch
1010
categories:
11-
- title: 'Breaking changes ⚠️'
11+
- title: '⚠️ Breaking changes'
1212
label: 'breaking-change'
13+
- title: '🚀 Enhancements'
14+
label: 'enhancement'
15+
- title: '🐛 Bug Fixes'
16+
label: 'bug'
17+
- title: '🔒 Security'
18+
label: 'security'
1319
template: |
14-
## Changes
15-
1620
$CHANGES
1721
1822
Thanks again to $CONTRIBUTORS! 🎉

.github/workflows/publish.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
steps:
1111
- uses: actions/checkout@v2
12-
- uses: actions/setup-node@v1
12+
- uses: actions/setup-node@v2
1313
with:
1414
node-version: 12
1515
registry-url: https://registry.npmjs.org/

.github/workflows/test.yml

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ jobs:
2424
./node_modules
2525
key: ${{ hashFiles('yarn.lock') }}
2626
- name: Setup node
27-
uses: actions/setup-node@v1
27+
uses: actions/setup-node@v2
2828
with:
29-
node-version: '12.x'
29+
node-version: "14.x"
3030
- name: Install dependencies
3131
run: yarn --dev && yarn --cwd ./playgrounds/vue
3232
- name: Run Browser tests
@@ -35,23 +35,26 @@ jobs:
3535
# Tests are only done on one playground to avoid long testing time
3636
start: yarn playground:vue
3737
env: playground=vue
38-
- uses: actions/upload-artifact@v1
38+
- uses: actions/upload-artifact@v2
3939
if: failure()
4040
with:
4141
name: cypress-screenshots
4242
path: cypress/screenshots
43-
- uses: actions/upload-artifact@v1
43+
- uses: actions/upload-artifact@v2
4444
if: failure()
4545
with:
4646
name: cypress-videos
4747
path: cypress/videos
4848

4949
tests:
50-
name: integration-tests
5150
runs-on: ubuntu-latest
52-
51+
strategy:
52+
fail-fast: false
53+
matrix:
54+
node: ["12", "14", "16"]
55+
name: integration-tests (Node.js ${{ matrix.node }})
5356
steps:
54-
- uses: actions/checkout@v1
57+
- uses: actions/checkout@v2
5558
- name: Cache dependencies
5659
uses: actions/cache@v2
5760
with:
@@ -72,7 +75,7 @@ jobs:
7275
runs-on: ubuntu-latest
7376

7477
steps:
75-
- uses: actions/checkout@v1
78+
- uses: actions/checkout@v2
7679
- name: Cache dependencies
7780
uses: actions/cache@v2
7881
with:

CONTRIBUTING.md

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,12 @@
22

33
First of all, thank you for contributing to MeiliSearch! The goal of this document is to provide everything you need to know in order to contribute to MeiliSearch and its different integrations.
44

5-
- [Hacktoberfest](#hacktoberfest)
65
- [Assumptions](#assumptions)
76
- [How to Contribute](#how-to-contribute)
87
- [Development Workflow](#development-workflow)
98
- [Git Guidelines](#git-guidelines)
109
- [Release Process (for internal team only)](#release-process-for-internal-team-only)
1110

12-
## Hacktoberfest
13-
14-
It's [Hacktoberfest month](https://blog.meilisearch.com/contribute-hacktoberfest-2021/)! 🥳
15-
16-
🚀 If your PR gets accepted it will count into your participation to Hacktoberfest!
17-
18-
✅ To be accepted it has either to have been merged, approved or tagged with the `hacktoberfest-accepted` label.
19-
20-
🧐 Don't forget to check the [quality standards](https://hacktoberfest.digitalocean.com/resources/qualitystandards)! Low-quality PRs might get marked as `spam` or `invalid`, and will not count toward your participation in Hacktoberfest.
21-
2211
## Assumptions
2312

2413
1. **You're familiar with [GitHub](https://github.com) and the [Pull Request](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests) (PR) workflow.**
@@ -91,14 +80,6 @@ yarn playground:html
9180

9281
A playground is available to try out the [GeoSearch](./README.md/-geo-search) in `instant-meilisearch`.
9382

94-
Unfortunately, for the moment, no online dataset is provided. Meaning that to make the playground work, you will have to set up your MeiliSearch accordingly to the playground needs.
95-
96-
To do so follow these steps:
97-
98-
1. Run a MeiliSeaerch instance. See [Setup](#setup) section to launch MeiliSearch with `Docker`. It is important to use the same `host` and `apikey` as provided in the `setup` section.
99-
2. Add the settings and the documents to your running MeiliSearch instance. We provide a script that does this automatically. Please run `node playgrounds/geo-javascript/setup/index.js`. Or you can look at the script to take inspiration!
100-
4. Run the playground!
101-
10283
```bash
10384
yarn playground:geo-javascript
10485
```
@@ -128,7 +109,7 @@ Some notes on GitHub PRs:
128109

129110
- [Convert your PR as a draft](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/changing-the-stage-of-a-pull-request) if your changes are a work in progress: no one will review it until you pass your PR as ready for review.<br>
130111
The draft PR can be very useful if you want to show that you are working on something and make your work visible.
131-
- The branch related to the PR must be **up-to-date with `main`** before merging. Fortunately, this project [integrates a bot](https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md) to automatically enforce this requirement without the PR author having to do it manually.
112+
- The branch related to the PR must be **up-to-date with `main`** before merging. Fortunately, this project [integrates a bot](https://github.com/meilisearch/integration-guides/blob/main/resources/bors.md) to automatically enforce this requirement without the PR author having to do it manually.
132113
- All PRs must be reviewed and approved by at least one maintainer.
133114
- The PR title should be accurate and descriptive of the changes. The title of the PR will be indeed automatically added to the next [release changelogs](https://github.com/meilisearch/instant-meilisearch/releases/).
134115

@@ -139,24 +120,24 @@ MeiliSearch tools follow the [Semantic Versioning Convention](https://semver.org
139120
### Automation to Rebase and Merge the PRs <!-- omit in TOC -->
140121

141122
This project integrates a bot that helps us manage pull requests merging.<br>
142-
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/bors.md)._
123+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/resources/bors.md)._
143124

144125
### Automated Changelogs <!-- omit in TOC -->
145126

146127
This project integrates a tool to create automated changelogs.<br>
147-
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/guides/release-drafter.md)._
128+
_[Read more about this](https://github.com/meilisearch/integration-guides/blob/main/resources/release-drafter.md)._
148129

149130
### How to Publish the Release <!-- omit in TOC -->
150131

151-
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/guides/integration-release.md).
132+
⚠️ Before doing anything, make sure you got through the guide about [Releasing an Integration](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md).
152133

153134
Make a PR modifying the file [`package.json`](/package.json) with the right version.
154135

155136
```javascript
156137
"version": "X.X.X"
157138
```
158139

159-
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/instant-meilisearch/releases).
140+
Once the changes are merged on `main`, you can publish the current draft release via the [GitHub interface](https://github.com/meilisearch/instant-meilisearch/releases): on this page, click on `Edit` (related to the draft release) > update the description (be sure you apply [these recommandations](https://github.com/meilisearch/integration-guides/blob/main/resources/integration-release.md#writting-the-release-description)) > when you are ready, click on `Publish release`.
160141

161142
GitHub Actions will be triggered and push the package to [npm](https://www.npmjs.com/package/@meilisearch/instant-meilisearch).
162143

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ The `refinementList` widget is one of the most common widgets you can find in a
584584

585585
- ✅ container: The CSS Selector or HTMLElement to insert the refinements. _required_
586586
- ✅ attribute: The facet to display _required_
587-
- operator: How to apply facets, "AND" or "OR"
587+
- operator: How to apply facets, "AND" or "OR". For the moment it only works with "AND"
588588
- ✅ limit: How many facet values to retrieve.
589589
- ✅ showMore: Whether to display a button that expands the number of items.
590590
- ✅ showMoreLimit: The maximum number of displayed items. Does not work when showMoreLimit > limit.

bors.toml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1-
status = ['integration-tests', 'style-check', 'cypress-run']
1+
status = [
2+
'style-check',
3+
'integration-tests (Node.js 12)',
4+
'integration-tests (Node.js 14)',
5+
'cypress-run'
6+
]
27
# 1 hour timeout
38
timeout-sec = 3600

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@
5454
"url": "https://github.com/meilisearch/instant-meilisearch.git"
5555
},
5656
"dependencies": {
57-
"meilisearch": "^0.22.1"
57+
"meilisearch": "^0.22.3"
5858
},
5959
"devDependencies": {
60-
"@babel/cli": "^7.15.7",
61-
"@babel/core": "^7.15.8",
60+
"@babel/cli": "^7.16.0",
61+
"@babel/core": "^7.16.0",
6262
"@babel/preset-env": "^7.15.8",
6363
"@rollup/plugin-commonjs": "^17.1.0",
6464
"@rollup/plugin-node-resolve": "^11.2.0",
@@ -88,7 +88,7 @@
8888
"eslint-plugin-react": "^7.22.0",
8989
"eslint-plugin-standard": "^5.0.0",
9090
"eslint-plugin-vue": "^7.7.0",
91-
"instantsearch.js": "^4.31.0",
91+
"instantsearch.js": "^4.33.1",
9292
"jest": "^27.2.2",
9393
"jest-watch-typeahead": "^0.6.3",
9494
"prettier": "^2.0.0",

playgrounds/angular/src/app/app.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import { Component } from '@angular/core'
22
import { instantMeiliSearch } from '../../../../src'
33

44
const searchClient = instantMeiliSearch(
5-
'https://demo-steam.meilisearch.com/',
6-
'90b03f9c47d0f321afae5ae4c4e4f184f53372a2953ab77bca679ff447ecc15c'
5+
'https://demos.meilisearch.com',
6+
'dc3fedaf922de8937fdea01f0a7d59557f1fd31832cb8440ce94231cfdde7f25'
77
)
88

99
@Component({

playgrounds/geo-javascript/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Javascript GeoSearch Playground
22

3-
To run this playground you will first have to set up your MeiliSearch accordingly to the playground needs. To do so please follow the steps in our [contributing guide](./CONTRIBUTING.md#-geo-search-playground).
3+
The provided Google Maps API Key is limited to 300 requests per day, so it might be down sometimes. In which case, please create a new [Google API Key](https://developers.google.com/maps/documentation/javascript/get-api-key) and add it in the `.env` file at the root of the playground: `/playgrounds/geo-javascript`.
44

5-
The provided Google Maps Api Key is limited at 300 requests per day, so it might be down sometimes. In which case, please create a new [Google Api Key](https://developers.google.com/maps/documentation/javascript/get-api-key) and add it in the `.env` file at the root of the playground: `/playgrounds/geo-javascript`
5+
The same dataset is [downloadable here](https://github.com/meilisearch/datasets/tree/main/datasets/world_cities) if you want to try it out on your own MeiliSearch.
66

77
## Project setup
88

playgrounds/geo-javascript/index.html

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,15 @@
1616
<body>
1717
<div class="ais-InstantSearch">
1818
<h1>MeiliSearch + InstantSearch.js</h1>
19-
<h2>Search in European cities </h2>
19+
<h2>Search in world cities </h2>
2020
<p>
21-
This is a small dataset of 20 european cities around Lille in France.
21+
This is a dataset of 32419 world cities with more than 10000 inhabitants.
2222
</p>
2323

24+
<div class="left-panel">
25+
<div id="sort-by"></div>
26+
</div>
27+
2428
<div class="right-panel">
2529
<div id="searchbox" class="ais-SearchBox"></div>
2630
<div id="maps" style="height: 500px; width: 500px"></div>

0 commit comments

Comments
 (0)