Skip to content

Conversation

@Strift
Copy link
Collaborator

@Strift Strift commented Jan 20, 2025

Pull Request

Related issue

Fixes #1362

What does this PR do?

  • Bump meilisearch-js to 0.48.2

To do

The tests are currently failing because jest are currently failing because jest cannot load metadata for mocks in the UMD build:

Test suite failed to run
@meilisearch/instant-meilisearch:test: 
@meilisearch/instant-meilisearch:test:     Failed to get mock metadata: /Users/strift/Code/Meili/meilisearch-js-plugins/node_modules/meilisearch/dist/umd/index.min.js
@meilisearch/instant-meilisearch:test: 
@meilisearch/instant-meilisearch:test:     See: https://jestjs.io/docs/manual-mocks#content
@meilisearch/instant-meilisearch:test: 
@meilisearch/instant-meilisearch:test:     > 1 | import { MeiliSearch } from 'meilisearch'

The relevant docs for jest v27.x: https://jest-archive-august-2023.netlify.app/docs/27.x/manual-mocks

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: 58eb09f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Strift Strift marked this pull request as draft January 20, 2025 04:57
@Strift Strift mentioned this pull request Jan 20, 2025
3 tasks
@Strift Strift changed the title Bump to v0.48.2 Bump meilisearch-js to v0.48.2 Jan 20, 2025
@Strift
Copy link
Collaborator Author

Strift commented Jan 22, 2025

Superseded by #1373

@Strift Strift closed this Jan 22, 2025
@Strift Strift deleted the chore/bump-meilisearch-js-to-0.48.2 branch September 24, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants