Merge #1082 #1084

bors[bot] · bidoubiwa · web-flow · commit 189da60997de · 2021-11-04T16:35:20.000Z
1082: Improve javascript playground r=bidoubiwa a=bidoubiwa



1084: Update github actions version to v2 r=bidoubiwa a=bidoubiwa



Co-authored-by: Charlotte Vermandel &lt;charlottevermandel@gmail.com&gt;
diff --git a/.github/workflows/pre-release-tests.yml b/.github/workflows/pre-release-tests.yml
@@ -4,16 +4,16 @@ name: Pre-Release Tests
 # Will only run for PRs and pushes to bump-meilisearch-v*
 on:
   push:
-    branches: bump-meilisearch-v*
+    branches: [bump-meilisearch-v*]
   pull_request:
-    branches: bump-meilisearch-v*
+    branches: [bump-meilisearch-v*]
 
 jobs:
   integration_tests:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [ '12', '14' ]
+        node: ["12", "14"]
     name: integration-tests-against-rc (Node.js ${{ matrix.node }})
     steps:
       - uses: actions/checkout@v2
@@ -24,7 +24,7 @@ jobs:
             ./node_modules
           key: ${{ hashFiles('yarn.lock') }}
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
       - name: print version
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - uses: actions/setup-node@v1
+      - uses: actions/setup-node@v2
         with:
           node-version: 12
           registry-url: https://registry.npmjs.org/
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [ '12', '14' ]
+        node: ["12", "14"]
     name: integration-tests (Node.js ${{ matrix.node }})
     steps:
       - uses: actions/checkout@v2
@@ -29,7 +29,7 @@ jobs:
             ./node_modules
           key: ${{ hashFiles('yarn.lock') }}
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: ${{ matrix.node }}
       - name: print version
@@ -63,7 +63,7 @@ jobs:
             ./node_modules
           key: ${{ hashFiles('yarn.lock') }}
       - name: Setup node
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
       - name: Install dependencies
         run: yarn --dev
       - name: Run style check
diff --git a/playgrounds/javascript/index.html b/playgrounds/javascript/index.html
@@ -1,18 +1,24 @@
 <!DOCTYPE html>
 <html lang="en">
-  <head>
-    <meta charset="utf-8" />
-    <meta
-      name="viewport"
-      content="width=device-width, initial-scale=1, shrink-to-fit=no"
-    />
-    <meta name="theme-color" content="#000000" />
-  </head>
-  <body>
 
+<head>
+  <meta charset="utf-8" />
+  <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
+  <meta name="theme-color" content="#000000" />
+</head>
 
+<body>
+
+
+  <h2 class="errors_title">Errors:</h2>
+  <div class="errors"></div>
+
+  <h2>Movies index:</h2>
+  <div class="indexes"></div>
+  <h2>Search response:</h2>
+  <div class="hits"></div>
+  <script src="https://cdn.jsdelivr.net/npm/instantsearch.js@4"></script>
+  <script src="/src/app.js"></script>
+</body>
 
-    <script src="https://cdn.jsdelivr.net/npm/instantsearch.js@4"></script>
-    <script src="/src/app.js"></script>
-  </body>
 </html>
diff --git a/playgrounds/javascript/src/app.js b/playgrounds/javascript/src/app.js
@@ -31,21 +31,31 @@ const addDataset = async () => {
 }
 
 ;(async () => {
-  await addDataset()
   try {
-    const index = await client.getOrCreateIndex('movies')
-
-    const resp = await index.search(
-      'Moana',
+    await addDataset()
+    const indexes = await client.getIndexes()
+    document.querySelector('.indexes').innerText = JSON.stringify(
+      indexes,
+      null,
+      2
+    )
+    const resp = await client.index(uid).search(
+      '',
       {
-        limit: 1,
         attributesToHighlight: ['title'],
       },
       'POST'
     )
     console.log({ resp })
     console.log({ hit: resp.hits[0] })
+    document.querySelector('.hits').innerText = JSON.stringify(
+      resp.hits,
+      null,
+      2
+    )
+    document.querySelector('.errors_title').style.display = 'none'
   } catch (e) {
     console.error(e)
+    document.querySelector('.errors').innerText = JSON.stringify(e, null, 2)
   }
 })()
