Merge #1503

1503: Feat/native fetch with nitro support r=bidoubiwa a=icyJoseph

# Pull Request

This PR brings back the conditional fetch loading. And it also makes sure that the SDK still supports nitro-apps.

## Related issue
Fixes #1487 

## What does this PR do?
- Conditionally load cross-fetch, only when global fetch is not defined

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Joseph Chamochumbi <[email protected]>
Co-authored-by: Joseph <[email protected]>

Author: meili-bors[bot]

package.json

@@ -46,6 +46,7 @@
     "test:env:node-ts": "yarn --cwd tests/env/typescript-node start",
     "test:env:nodejs": "yarn build && node tests/env/node/index.js && node tests/env/node/getting_started.js",
     "test:env:esm": "yarn --cwd tests/env/esm && yarn --cwd tests/env/esm start",
+    "test:env:nitro-app": "yarn build && yarn --cwd tests/env/nitro-app test",
     "size": "node scripts/file-size ./dist/bundles/meilisearch.esm.min.js ./dist/bundles/meilisearch.umd.min.js",
     "style": "yarn lint",
     "style:fix": "yarn lint:fix",

src/errors/meilisearch-communication-error.ts

@@ -1,4 +1,3 @@
-import 'cross-fetch/polyfill'
 import { FetchError } from '../types'
 
 class MeiliSearchCommunicationError extends Error {

src/http-requests.ts

@@ -1,5 +1,3 @@
-import 'cross-fetch/polyfill'
-
 import { Config, EnqueuedTaskObject } from './types'
 import { PACKAGE_VERSION } from './package-version'
 
@@ -120,6 +118,10 @@ class HttpRequests {
     body?: any
     config?: Record<string, any>
   }) {
+    if (typeof fetch === 'undefined') {
+      require('cross-fetch/polyfill')
+    }
+
     const constructURL = new URL(url, this.url)
     if (params) {
       const queryParams = new URLSearchParams()

tests/env/nitro-app/.gitignore

@@ -0,0 +1,5 @@
+node_modules
+*.log*
+.nitro
+.cache
+.output

tests/env/nitro-app/package.json

@@ -0,0 +1,16 @@
+{
+  "private": true,
+  "scripts": {
+    "test": "yarn build && jest",
+    "dev": "npx nitropack dev",
+    "build": "npx nitropack build",
+    "preview": "node .output/server/index.mjs"
+  },
+  "dependencies": {
+    "meilisearch": "file:../../../",
+    "nitropack": "latest"
+  },
+  "devDependencies": {
+    "jest": "29.5.0"
+  }
+}

tests/env/nitro-app/routes/index.js

@@ -0,0 +1,19 @@
+import { MeiliSearch } from 'meilisearch'
+
+const meilisearch = new MeiliSearch({
+  host: 'http://localhost:7700',
+  apiKey: 'masterKey',
+})
+
+export default defineEventHandler(async () => {
+  try {
+    const health = await meilisearch.isHealthy()
+
+    return { health }
+  } catch (error) {
+    throw createError({
+      statusCode: 500,
+      statusMessage: 'Unexpected Error',
+    })
+  }
+})

tests/env/nitro-app/tests/client.test.js

@@ -0,0 +1,26 @@
+const { spawn } = require('child_process')
+
+let server
+
+beforeAll(() => {
+  server = spawn('node', ['.output/server/index.mjs'])
+})
+
+afterAll(() => {
+  server.kill()
+})
+
+describe('Meilisearch JS w/ Nitro App Server Browser test', () => {
+  it('Should have created an index and displayed it', async () => {
+    await new Promise((next) => {
+      server.stdout.on('data', () => {
+        next()
+        server.stdout.removeAllListeners('data')
+      })
+    })
+    const response = await fetch('http://[::]:3000')
+    const data = await response.json()
+
+    expect(data.health).toBe(true)
+  })
+})