Skip to content

Commit 2e41364

Browse files
bors[bot]bidoubiwa
andauthored
Merge #768
768: Fix failing test by using an older version of jsdom r=bidoubiwa a=bidoubiwa Usage of `jest-environment-jsdom` is not explicitly given anywhere I searched for it. But it appears it creates a jest environment that uses (depending on the version) a previous `jsdom`. More information on my supposition here: jestjs/jest#11025 Npm package of jest-environment-jsdom with 10million downloads a week but no readme https://www.npmjs.com/package/jest-environment-jsdom 🤯 Co-authored-by: Charlotte Vermandel <[email protected]>
2 parents 71cae6b + b9986e4 commit 2e41364

File tree

3 files changed

+163
-27
lines changed

3 files changed

+163
-27
lines changed

jest.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const config = {
2525
// TODO: Change this value back to jsdom once once `globalThis` issue is resolved
2626
// Also uninstall jest-environment-jsdom-sixteen
2727
// https://github.com/jsdom/jsdom/issues/2961
28-
testEnvironment: 'jest-environment-jsdom-sixteen',
28+
testEnvironment: 'jest-environment-jsdom',
2929
testMatch: ['<rootDir>/tests/**/*.ts?(x)'],
3030
testPathIgnorePatterns: ['meilisearch-test-utils', 'env/'],
3131
},

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@
8484
"eslint-plugin-standard": "5",
8585
"gzip-size": "^6.0.0",
8686
"jest": "^26.6.3",
87-
"jest-environment-jsdom-sixteen": "^1.0.3",
87+
"jest-environment-jsdom": "25.5",
8888
"jest-watch-typeahead": "^0.5.0",
8989
"kleur": "^4.0.0",
9090
"lint-staged": "10.5.1",

0 commit comments

Comments
 (0)