Skip to content

Commit 374b8d0

Browse files
bors[bot]bidoubiwa
andauthored
Merge #771
771: Update jsdom comment r=bidoubiwa a=bidoubiwa Update jsdom dom comment to be more accurate Co-authored-by: Charlotte Vermandel <[email protected]>
2 parents 938fb87 + 1922eb0 commit 374b8d0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

jest.config.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,8 @@ const config = {
2222
{
2323
preset: 'ts-jest',
2424
displayName: 'dom',
25-
// TODO: Change this value back to jsdom once once `globalThis` issue is resolved
26-
// Also uninstall jest-environment-jsdom-sixteen
27-
// https://github.com/jsdom/jsdom/issues/2961
25+
// We are using jest-environment-jsdom 25 until we stop supporting node 10
26+
// jest-environment-jsdom 25 uses jsdom 15 which still supports node 10
2827
testEnvironment: 'jest-environment-jsdom',
2928
testMatch: ['<rootDir>/tests/**/*.ts?(x)'],
3029
testPathIgnorePatterns: ['meilisearch-test-utils', 'env/'],

0 commit comments

Comments
 (0)