removed expect-expect rule and adapted tests

Author: Barabasbalazs

eslint.config.js

@@ -66,7 +66,6 @@ module.exports = [
     rules: {
       ...vitest.configs.recommended.rules,
       // @TODO: Remove all of these rules and adapt code!
-      "vitest/expect-expect": "off",
       "vitest/valid-title": "off",
       "vitest/valid-expect": "off",
     },

tests/dump.test.ts

@@ -1,5 +1,5 @@
 import { expect, test, describe, beforeEach } from "vitest";
-import { ErrorStatusCode } from "../src/types";
+import { ErrorStatusCode, TaskStatus } from "../src/types";
 import {
   clearAllIndexes,
   config,
@@ -13,13 +13,15 @@ beforeEach(async () => {
 });
 
 describe.each([{ permission: "Master" }, { permission: "Admin" }])(
-  "Test on dump",
+  "Test on dump should succeed with right permission",
   ({ permission }) => {
     test(`${permission} key: create a new dump`, async () => {
       const client = await getClient(permission);
       const { taskUid } = await client.createDump();
 
-      await client.waitForTask(taskUid);
+      const taskResult = await client.waitForTask(taskUid);
+
+      expect(taskResult).toHaveProperty("status", TaskStatus.TASK_SUCCEEDED);
     });
   },
 );

tests/snapshots.test.ts

@@ -1,5 +1,5 @@
 import { beforeEach, describe, expect, test } from "vitest";
-import { ErrorStatusCode } from "../src/types";
+import { ErrorStatusCode, TaskStatus } from "../src/types";
 import {
   clearAllIndexes,
   config,
@@ -13,13 +13,15 @@ beforeEach(async () => {
 });
 
 describe.each([{ permission: "Master" }, { permission: "Admin" }])(
-  "Test on snapshot",
+  "Test on snapshot should succeed with right permission",
   ({ permission }) => {
     test(`${permission} key: create a new snapshot`, async () => {
       const client = await getClient(permission);
       const { taskUid } = await client.createSnapshot();
 
-      await client.waitForTask(taskUid);
+      const taskResult = await client.waitForTask(taskUid);
+
+      expect(taskResult).toHaveProperty("status", TaskStatus.TASK_SUCCEEDED);
     });
   },
 );