Merge #1444

1444: Update typescript to 4.9.5 (ts) r=bidoubiwa a=bidoubiwa

The library was not compatible with environments using typescript `v4.9.5` causing typing errors. 



Co-authored-by: Charlotte Vermandel <[email protected]>

Author: meili-bors[bot]

.eslintignore

@@ -3,3 +3,4 @@ dist
 examples
 scripts
 tests/env
+coverage

.eslintrc.js

@@ -53,5 +53,6 @@ module.exports = {
       },
     ],
     'comma-dangle': 'off',
+    '@typescript-eslint/ban-ts-ignore': 'off',
   },
 }

package.json

@@ -109,6 +109,6 @@
     "rollup-plugin-typescript2": "^0.34.1",
     "shx": "^0.3.2",
     "ts-jest": "^26.5.6",
-    "typescript": "4.6.4"
+    "typescript": "^4.9.5"
   }
 }

src/clients/client.ts

@@ -59,7 +59,9 @@ class Client {
    * @param indexUid - The index UID
    * @returns Instance of Index
    */
-  index<T = any>(indexUid: string): Index<T> {
+  index<T extends Record<string, any> = Record<string, any>>(
+    indexUid: string
+  ): Index<T> {
     return new Index<T>(this.config, indexUid)
   }
 
@@ -70,7 +72,9 @@ class Client {
    * @param indexUid - The index UID
    * @returns Promise returning Index instance
    */
-  async getIndex<T = any>(indexUid: string): Promise<Index<T>> {
+  async getIndex<T extends Record<string, any> = Record<string, any>>(
+    indexUid: string
+  ): Promise<Index<T>> {
     return new Index<T>(this.config, indexUid).fetchInfo()
   }
 

tests/search.test.ts

@@ -802,6 +802,7 @@ describe.each([
       'unreachable',
       {},
       {
+        // @ts-ignore qwe
         signal: controller.signal,
       }
     )
@@ -824,6 +825,7 @@ describe.each([
       searchQuery,
       {},
       {
+        // @ts-ignore
         signal: controllerA.signal,
       }
     )
@@ -832,6 +834,7 @@ describe.each([
       searchQuery,
       {},
       {
+        // @ts-ignore
         signal: controllerB.signal,
       }
     )
@@ -840,6 +843,7 @@ describe.each([
       searchQuery,
       {},
       {
+        // @ts-ignore
         signal: controllerC.signal,
       }
     )

tsconfig.json

@@ -11,13 +11,14 @@
       "lib": ["ES2019", "ESNext", "dom"],
       "moduleResolution": "node",
       "noImplicitAny": true,
+      "strict": true,
+      "alwaysStrict": true,
       "strictNullChecks": true,
       "strictFunctionTypes": true,
       "strictPropertyInitialization": true,
       "strictBindCallApply": true,
       "noImplicitThis": true,
       "noImplicitReturns": true,
-      "alwaysStrict": true,
       "esModuleInterop": true,
       "experimentalDecorators": true,
       "emitDecoratorMetadata": true,

yarn.lock

@@ -6736,10 +6736,10 @@ typedarray-to-buffer@^3.1.5:
   dependencies:
     is-typedarray "^1.0.0"
 
-typescript@4.6.4:
-  version "4.6.4"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.6.4.tgz#caa78bbc3a59e6a5c510d35703f6a09877ce45e9"
-  integrity sha512-9ia/jWHIEbo49HfjrLGfKbZSuWo9iTMwXO+Ca3pRsSpbsMbc7/IU8NKdCZVRRBafVPGnoJeFL76ZOAA84I9fEg==
+typescript@^4.9.5:
+  version "4.9.5"
+  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.5.tgz#095979f9bcc0d09da324d58d03ce8f8374cbe65a"
+  integrity sha512-1FXk9E2Hm+QzZQ7z+McJiHL4NW1F2EzMu9Nq9i3zAaGqibafqYwCVU6WyWAuyQRRzOlxou8xZSyXLEN8oKj24g==
 
 undefsafe@^2.0.5:
   version "2.0.5"