Skip to content

Commit 8fea5e4

Browse files
Merge #1593
1593: Fix const enum issues r=brunoocasali a=jonespen # Pull Request ## Related issue Fixes #1588 ## What does this PR do? `const enum` is not really suited for libraries (ref https://youtu.be/jjMbPt_H3RQ?feature=shared&t=249 and https://www.typescriptlang.org/docs/handbook/enums.html#const-enum-pitfalls) and cause issues in typescript projects with `isolatedModules: true` (like Next.js). Instead, regular objects can be used (like done in #1350) with `as const` to make them type safe. About the `as readonly string[]` in cfcda4f, this could probably have been solved by a type guard as well, but I opted for the type cast option instead to avoid runtime code changes. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Jon Espen Kvisler <[email protected]>
2 parents 8a74e35 + cfcda4f commit 8fea5e4

File tree

2 files changed

+152
-139
lines changed

2 files changed

+152
-139
lines changed

src/task.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,10 @@ class TaskClient {
9797
while (Date.now() - startingTime < timeOutMs) {
9898
const response = await this.getTask(taskUid)
9999
if (
100-
![TaskStatus.TASK_ENQUEUED, TaskStatus.TASK_PROCESSING].includes(
101-
response.status
102-
)
100+
!([
101+
TaskStatus.TASK_ENQUEUED,
102+
TaskStatus.TASK_PROCESSING,
103+
] as readonly string[]).includes(response.status)
103104
)
104105
return response
105106
await sleep(intervalMs)

0 commit comments

Comments
 (0)