Update errors in Update response

Author: bidoubiwa

src/errors/meilisearch-api-error.ts

@@ -1,20 +1,13 @@
-import {
-  MSApiError,
-  MeiliSearchApiErrorResponse,
-  MSApiErrorConstructor,
-} from '../types'
+import { MeiliSearchErrorInterface } from '../types'
 
-const MeiliSearchApiError: MSApiErrorConstructor = class
-  extends Error
-  implements MSApiError {
+const MeiliSearchApiError = class extends Error {
   httpStatus: number
-  response?: MeiliSearchApiErrorResponse
   code?: string
   link?: string
   stack?: string
   type?: string
 
-  constructor(error: MSApiError, status: number) {
+  constructor(error: MeiliSearchErrorInterface, status: number) {
     super(error.message)
     this.name = 'MeiliSearchApiError'
 

src/types/types.ts

@@ -174,6 +174,7 @@ export type Update = {
   duration: number
   enqueuedAt: string
   processedAt: string
+  error?: MeiliSearchErrorBody
 }
 
 export type EnqueuedDump = {
@@ -236,22 +237,11 @@ export type Version = {
  ** ERROR HANDLER
  */
 
-export type MSApiErrorConstructor = new (
-  error: MSApiError,
-  status: number
-) => void
-
-export type MeiliSearchApiErrorResponse = {
-  status?: number
-  statusText?: string
-  path?: string
-  method?: string
-  body?: object
-}
-export type MeiliSearchApiErrorRequest = {
-  url?: string
-  path?: string
-  method?: string
+export interface MeiliSearchErrorInterface extends Error {
+  code?: string
+  link?: string
+  stack?: string
+  type?: string
 }
 
 export interface FetchError extends Error {
@@ -260,14 +250,11 @@ export interface FetchError extends Error {
   code: string
 }
 
-export interface MSApiError extends Error {
-  name: string
+export type MeiliSearchErrorBody = {
+  code: string
+  link: string
   message: string
-  stack?: string
-  httpStatus: number
-  code?: string
-  type?: string
-  link?: string
+  type: string
 }
 
 export const enum ErrorStatusCode {

tests/documents_tests.ts

@@ -369,6 +369,23 @@ describe.each([
     expect(response).toHaveProperty('primaryKey', 'unique')
   })
 
+  test(`${permission} key: Add a document without a primary key and check response in update status`, async () => {
+    const docs = [
+      {
+        title: 'Le Rouge et le Noir',
+      },
+    ]
+    const { updateId } = await client.index(indexNoPk.uid).addDocuments(docs)
+
+    const { error } = await client
+      .index(indexNoPk.uid)
+      .waitForPendingUpdate(updateId)
+    expect(error).toHaveProperty('code')
+    expect(error).toHaveProperty('link')
+    expect(error).toHaveProperty('message')
+    expect(error).toHaveProperty('type')
+  })
+
   test(`${permission} key: Try to add documents from index with no primary key with NO valid primary key, update should fail`, async () => {
     const { updateId } = await client.index(indexNoPk.uid).addDocuments([
       {