Resolve path removal of host url (#628)

Linting

Update client test for clarity

remove async from non async function

Remove header check in two URL tests

Remove header from second test

Fixes tests with missing headers

Remove header check in two URL tests

Fixes tests with missing headers

Author: bidoubiwa

src/http-requests.ts

@@ -7,17 +7,15 @@ import {
 
 class HttpRequests {
   headers: {}
-  baseUrl: string
-  url: URL
+  url: string
 
   constructor(config: Types.Config) {
     this.headers = {
       ...(config.headers || {}),
       'Content-Type': 'application/json',
       ...(config.apiKey ? { 'X-Meili-API-Key': config.apiKey } : {}),
     }
-    this.baseUrl = config.host
-    this.url = new URL(this.baseUrl)
+    this.url = config.host
   }
 
   async request({
@@ -34,14 +32,17 @@ class HttpRequests {
     config?: Request
   }) {
     try {
-      const constructURL = new URL(url, this.url)
+      const constructURL = new URL(this.url)
+      constructURL.pathname = constructURL.pathname + url
+
       if (params) {
         const queryParams = new URLSearchParams()
         Object.keys(params)
           .filter((x: string) => params[x] !== null)
           .map((x: string) => queryParams.set(x, params[x]))
         constructURL.search = queryParams.toString()
       }
+
       const response: Response = await fetch(constructURL.toString(), {
         ...config,
         method,

tests/client_tests.ts

@@ -37,6 +37,31 @@ describe.each([
     const health = await client.isHealthy()
     expect(health).toBe(true)
   })
+
+  test(`${permission} key: Client handles host URL with domain and path`, () => {
+    const customHost = `${config.host}/api`
+    const client = new MeiliSearch({
+      host: customHost,
+      apiKey: key,
+    })
+    expect(client.config.host).toBe(customHost)
+    expect(client.httpRequest.url).toBe(customHost)
+  })
+
+  test(`${permission} key: Client uses complete URL with domain and additionnal path in MeiliSearch call`, async () => {
+    try {
+      const customHost = `${config.host}/api`
+      const client = new MeiliSearch({
+        host: customHost,
+        apiKey: key,
+      })
+      const health = await client.isHealthy()
+      expect(health).toBe(false) // Left here to trigger failed test if error is not thrown
+    } catch (e) {
+      expect(e.type).toBe('MeiliSearchCommunicationError')
+      expect(e.message).toBe('Not Found') // Expect 404 because host does not exist
+    }
+  })
 })
 
 describe.each([