Skip to content

Commit 07ca854

Browse files
committed
Add assertion
1 parent 63fdbbe commit 07ca854

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

src/Endpoints/Indexes.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,10 @@ public function update(array $body): Task
144144

145145
public function delete(): Task
146146
{
147-
return Task::fromArray($this->http->delete(self::PATH.'/'.$this->uid) ?? []);
147+
$response = $this->http->delete(self::PATH.'/'.$this->uid);
148+
assert($response !== null);
149+
150+
return Task::fromArray($response);
148151
}
149152

150153
/**

tests/Endpoints/IndexTest.php

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
use Meilisearch\Contracts\DeleteTasksQuery;
88
use Meilisearch\Contracts\TasksQuery;
9+
use Meilisearch\Contracts\TaskType;
910
use Meilisearch\Endpoints\Indexes;
1011
use Meilisearch\Exceptions\TimeOutException;
1112
use Tests\TestCase;
@@ -244,17 +245,14 @@ public function testDeleteIndexes(): void
244245
$indexName2 = $this->safeIndexName('books-2');
245246
$index = $this->createEmptyIndex($indexName2);
246247

247-
$res = $this->index->delete();
248-
self::assertSame($indexName1, $res['indexUid']);
249-
self::assertArrayHasKey('type', $res);
250-
self::assertSame('indexDeletion', $res['type']);
251-
self::assertArrayHasKey('enqueuedAt', $res);
252-
253-
$res = $index->delete();
254-
self::assertSame($indexName2, $res['indexUid']);
255-
self::assertArrayHasKey('type', $res);
256-
self::assertSame('indexDeletion', $res['type']);
257-
self::assertArrayHasKey('enqueuedAt', $res);
248+
$task = $this->index->delete();
249+
var_dump($task);
250+
self::assertSame($indexName1, $task->getIndexUid());
251+
self::assertSame(TaskType::IndexDeletion, $task->getType());
252+
253+
$task = $index->delete();
254+
self::assertSame($indexName2, $task->getIndexUid());
255+
self::assertSame(TaskType::IndexDeletion, $task->getType());
258256
}
259257

260258
public function testSwapIndexes(): void

0 commit comments

Comments
 (0)