Skip to content

Commit 279fdd9

Browse files
authored
Remove vectorStore experimental setting usage (#718)
* Remove manual enabling * Remove unused import * Update default embedder expectations
1 parent 2b1416d commit 279fdd9

File tree

4 files changed

+1
-28
lines changed

4 files changed

+1
-28
lines changed

tests/Endpoints/DocumentsTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -680,8 +680,6 @@ public function testGetDocumentsWithoutFilterCorrectFieldsFormat(): void
680680

681681
public function testGetDocumentsWithVector(): void
682682
{
683-
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
684-
$http->patch('/experimental-features', ['vectorStore' => true]);
685683
$index = $this->createEmptyIndex($this->safeIndexName('movies'));
686684

687685
$promise = $index->updateEmbedders(['manual' => ['source' => 'userProvided', 'dimensions' => 3]]);

tests/Endpoints/SearchTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -707,8 +707,6 @@ public function testBasicSearchWithFacetsOptionAndMultipleFacets(): void
707707

708708
public function testVectorSearch(): void
709709
{
710-
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
711-
$http->patch('/experimental-features', ['vectorStore' => true]);
712710
$index = $this->createEmptyIndex($this->safeIndexName());
713711

714712
$promise = $index->updateEmbedders(['manual' => ['source' => 'userProvided', 'dimensions' => 3]]);

tests/Settings/EmbeddersTest.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,20 +5,17 @@
55
namespace Tests\Settings;
66

77
use Meilisearch\Endpoints\Indexes;
8-
use Meilisearch\Http\Client;
98
use Tests\TestCase;
109

1110
final class EmbeddersTest extends TestCase
1211
{
1312
private Indexes $index;
1413

15-
private const DEFAULT_EMBEDDER = null;
14+
private const DEFAULT_EMBEDDER = [];
1615

1716
protected function setUp(): void
1817
{
1918
parent::setUp();
20-
$http = new Client($this->host, getenv('MEILISEARCH_API_KEY'));
21-
$http->patch('/experimental-features', ['vectorStore' => true]);
2219
$this->index = $this->createEmptyIndex($this->safeIndexName());
2320
}
2421

tests/Settings/SettingsTest.php

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -196,24 +196,4 @@ public function testResetSettings(): void
196196
self::assertSame(self::DEFAULT_FACET_SEARCH, $settings['facetSearch']);
197197
self::assertSame(self::DEFAULT_PREFIX_SEARCH, $settings['prefixSearch']);
198198
}
199-
200-
// Here the test to prevent https://github.com/meilisearch/meilisearch-php/issues/204.
201-
// Rollback this comment after meilisearch v1.6.0 final release.
202-
// Related to: https://github.com/meilisearch/meilisearch/issues/4323
203-
//
204-
// public function testGetThenUpdateSettings(): void
205-
// {
206-
// $http = new \Meilisearch\Http\Client($this->host, getenv('MEILISEARCH_API_KEY'));
207-
// $http->patch('/experimental-features', ['vectorStore' => false]);
208-
// $index = $this->createEmptyIndex($this->safeIndexName());
209-
210-
// $resetPromise = $index->resetSettings();
211-
// $this->assertIsValidPromise($resetPromise);
212-
// $index->waitForTask($resetPromise['taskUid']);
213-
214-
// $settings = $index->getSettings();
215-
// $promise = $index->updateSettings($settings);
216-
// $this->assertIsValidPromise($promise);
217-
// $index->waitForTask($promise['taskUid']);
218-
// }
219199
}

0 commit comments

Comments
 (0)