Skip to content

Commit 8de831c

Browse files
committed
Completely replace array data usage
1 parent 8514102 commit 8de831c

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

tests/Endpoints/DocumentsTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -831,8 +831,8 @@ public function testUpdateDocumentsCsvInBatches(): void
831831

832832
$documentCsv = file_get_contents('./tests/datasets/songs.csv', true);
833833

834-
$addPromise = $index->addDocumentsCsv($documentCsv);
835-
$index->waitForTask($addPromise['taskUid']);
834+
$task = $index->addDocumentsCsv($documentCsv);
835+
$index->waitForTask($task->getTaskUid());
836836

837837
$replacement = 'id,title'.PHP_EOL;
838838
$replacement .= '888221515,Young folks'.PHP_EOL;
@@ -895,8 +895,8 @@ public function testUpdateDocumentsNdjsonInBatches(): void
895895
$documentNdJson = fread($fileNdJson, filesize('./tests/datasets/songs.ndjson'));
896896
fclose($fileNdJson);
897897

898-
$addPromise = $index->addDocumentsNdjson($documentNdJson);
899-
$index->waitForTask($addPromise['taskUid']);
898+
$task = $index->addDocumentsNdjson($documentNdJson);
899+
$index->waitForTask($task->getTaskUid());
900900

901901
$replacement = json_encode(['id' => 412559401, 'title' => 'WASPTHOVEN']).PHP_EOL;
902902
$replacement .= json_encode(['id' => 70764404, 'artist' => 'Ailitp']).PHP_EOL;

tests/Endpoints/IndexTest.php

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,9 +230,11 @@ public function testWaitForTaskWithTimeout(): void
230230

231231
public function testExceptionWhenTaskTimeOut(): void
232232
{
233-
$res = $this->index->addDocuments([['id' => 1, 'title' => 'Pride and Prejudice']]);
233+
$task = $this->index->addDocuments([['id' => 1, 'title' => 'Pride and Prejudice']]);
234+
234235
$this->expectException(TimeOutException::class);
235-
$this->index->waitForTask($res['taskUid'], 0, 20);
236+
237+
$this->index->waitForTask($task->getTaskUid(), 0, 20);
236238
}
237239

238240
public function testDeleteIndexes(): void

tests/Endpoints/SearchTest.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,9 @@ public function testBasicSearchIfNoPrimaryKeyAndDocumentProvided(): void
131131
public function testExceptionIfNoIndexWhenSearching(): void
132132
{
133133
$index = $this->createEmptyIndex($this->safeIndexName('movie-1'));
134-
$res = $index->delete();
135-
$index->waitForTask($res['taskUid']);
134+
135+
$task = $index->delete();
136+
$index->waitForTask($task->getTaskUid());
136137

137138
$this->expectException(ApiException::class);
138139

tests/Endpoints/TenantTokenTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function testGenerateTenantTokenWithFilter(): void
7373
$taskFromFilter = $this->client->index('tenantToken')->updateFilterableAttributes([
7474
'id',
7575
]);
76-
$this->client->waitForTask($taskFromFilter['taskUid']);
76+
$this->client->waitForTask($taskFromFilter->getTaskUid());
7777

7878
$token = $this->privateClient->generateTenantToken($this->key->getUid(), (object) ['tenantToken' => (object) ['filter' => 'id > 10']]);
7979
$tokenClient = new Client($this->host, $token);

tests/TestCase.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ protected function tearDown(): void
9191
$tasks = [];
9292

9393
foreach ($indexes as $index) {
94-
$tasks[] = $index->delete()['taskUid'];
94+
$tasks[] = $index->delete()->getTaskUid();
9595
}
9696

9797
$this->client->waitForTasks($tasks);

0 commit comments

Comments
 (0)