Skip to content

Commit 96e93a0

Browse files
committed
Replace task array access usage with getters
Rename `$response` to `$task` in tests
1 parent 1a6811f commit 96e93a0

34 files changed

+297
-291
lines changed

tests/Contracts/TaskTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public function testCreate(): void
6262
), $task->getError());
6363

6464
// Ensure the class supports array access retrocompatibility
65-
self::assertSame(1, $task['taskUid']);
65+
self::assertSame(1, $task->getTaskUid());
6666
self::assertSame('documents', $task['indexUid']);
6767
self::assertSame('failed', $task['status']);
6868
self::assertSame('index_creation', $task['type']);

tests/Endpoints/BatchesTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testGetAllBatchesWithIndexUidFilters(): void
3636
public function testGetAllBatchesWithTasksFilters(): void
3737
{
3838
$tasks = $this->client->getTasks(new TasksQuery())->getResults();
39-
$response = $this->client->getBatches((new BatchesQuery())->setUids([$tasks[0]['uid']]));
39+
$response = $this->client->getBatches((new BatchesQuery())->setUids([$tasks[0]->getTaskUid()]));
4040
self::assertGreaterThan(0, $response->getTotal());
4141
}
4242

tests/Endpoints/ClientTest.php

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,12 @@ public function testgetIndexes(): void
9292
{
9393
$booksIndex1 = $this->safeIndexName('books-1');
9494
$booksIndex2 = $this->safeIndexName('books-2');
95-
$response = $this->client->createIndex($booksIndex1);
96-
$this->client->waitForTask($response['taskUid']);
97-
$response = $this->client->createIndex($booksIndex2);
98-
$this->client->waitForTask($response['taskUid']);
95+
96+
$task = $this->client->createIndex($booksIndex1);
97+
$this->client->waitForTask($task->getTaskUid());
98+
99+
$task = $this->client->createIndex($booksIndex2);
100+
$this->client->waitForTask($task->getTaskUid());
99101

100102
$indexes = $this->client->getIndexes();
101103

@@ -116,9 +118,10 @@ public function testUpdateIndex(): void
116118
$indexName = $this->safeIndexName('books-1');
117119
$this->createEmptyIndex($indexName);
118120

119-
$response = $this->client->updateIndex($indexName, ['primaryKey' => 'id']);
120-
$this->client->waitForTask($response['taskUid']);
121-
$index = $this->client->getIndex($response['indexUid']);
121+
$task = $this->client->updateIndex($indexName, ['primaryKey' => 'id']);
122+
$this->client->waitForTask($task->getTaskUid());
123+
124+
$index = $this->client->getIndex($task->getIndexUid());
122125

123126
self::assertSame('id', $index->getPrimaryKey());
124127
self::assertSame($indexName, $index->getUid());
@@ -131,8 +134,8 @@ public function testDeleteIndex(): void
131134
$response = $this->client->getIndexes();
132135
self::assertCount(1, $response);
133136

134-
$response = $this->client->deleteIndex('index');
135-
$this->client->waitForTask($response['taskUid']);
137+
$task = $this->client->deleteIndex('index');
138+
$this->client->waitForTask($task->getTaskUid());
136139

137140
$this->expectException(ApiException::class);
138141
$index = $this->client->getIndex('index');

0 commit comments

Comments
 (0)