Skip to content

Commit ec91f26

Browse files
Merge #710
710: Fix flaky tasks reverse test r=curquiza a=Strift # Pull Request Fixes a flaky tests about getting tasks in reverse order Co-authored-by: Strift <[email protected]>
2 parents 78879c2 + 5f94393 commit ec91f26

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

tests/Endpoints/TasksTest.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -154,18 +154,16 @@ public function testCancelTasksWithFilter(): void
154154

155155
public function testGetAllTasksInReverseOrder(): void
156156
{
157-
$startDate = new \DateTimeImmutable('now');
157+
$sampleTasks = $this->client->getTasks(new TasksQuery());
158+
$sampleTasksUids = array_map(fn ($task) => $task['uid'], $sampleTasks->getResults());
158159

159-
$tasks = $this->client->getTasks((new TasksQuery())
160-
->setAfterEnqueuedAt($startDate)
161-
);
162-
$reversedTasks = $this->client->getTasks((new TasksQuery())
163-
->setAfterEnqueuedAt($startDate)
164-
->setReverse(true)
165-
);
160+
$expectedTasks = $this->client->getTasks((new TasksQuery())->setUids($sampleTasksUids));
161+
$expectedTasksUids = array_map(fn ($task) => $task['uid'], $expectedTasks->getResults());
162+
163+
$reversedTasks = $this->client->getTasks((new TasksQuery())->setUids($sampleTasksUids)->setReverse(true));
164+
$reversedTasksUids = array_map(fn ($task) => $task['uid'], $reversedTasks->getResults());
166165

167-
self::assertSameSize($tasks->getResults(), $reversedTasks->getResults());
168-
self::assertSame($tasks->getResults(), array_reverse($reversedTasks->getResults()));
166+
self::assertSame(array_reverse($expectedTasksUids), $reversedTasksUids);
169167
}
170168

171169
public function testExceptionIfNoTaskIdWhenGetting(): void

0 commit comments

Comments
 (0)