Make rubocop happy

Author: ellnix

.rubocop_todo.yml

@@ -1,27 +1,11 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-04-08 13:44:25 UTC using RuboCop version 1.27.0.
+# on 2024-05-27 18:22:30 UTC using RuboCop version 1.27.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: TreatCommentsAsGroupSeparators, ConsiderPunctuation, Include.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
-Bundler/OrderedGems:
-  Exclude:
-    - 'Gemfile'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: Include.
-# Include: **/*.gemspec
-Gemspec/RequireMFA:
-  Exclude:
-    - 'meilisearch-rails.gemspec'
-
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -30,13 +14,12 @@ Layout/EmptyLinesAroundModuleBody:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 3
+# Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: symmetrical, new_line, same_line
 Layout/MultilineMethodCallBraceLayout:
   Exclude:
-    - 'spec/integration_spec.rb'
     - 'spec/ms_clean_up_job_spec.rb'
 
 # Offense count: 1
@@ -70,7 +53,7 @@ Lint/UnusedMethodArgument:
 # Offense count: 12
 # Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 104
+  Max: 103
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
@@ -81,7 +64,7 @@ Metrics/BlockLength:
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
-  Max: 157
+  Max: 169
 
 # Offense count: 8
 # Configuration parameters: IgnoredMethods.
@@ -91,12 +74,12 @@ Metrics/CyclomaticComplexity:
 # Offense count: 18
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
-  Max: 103
+  Max: 102
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 449
+  Max: 437
 
 # Offense count: 8
 # Configuration parameters: IgnoredMethods.
@@ -123,47 +106,61 @@ Naming/MethodParameterName:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 20
+# Offense count: 5
 RSpec/BeforeAfterAll:
   Exclude:
-    - 'spec/integration_spec.rb'
+    - 'spec/integration/active_record/record_has_associations_spec.rb'
+    - 'spec/pagination/kaminari_spec.rb'
+    - 'spec/pagination/will_paginate_spec.rb'
+    - 'spec/settings_spec.rb'
+    - 'spec/system/tech_shop_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/options_spec.rb'
+    - 'spec/system/tech_shop_spec.rb'
 
-# Offense count: 56
+# Offense count: 54
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Max: 19
+  Max: 16
 
-# Offense count: 3
+# Offense count: 6
 # Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
 # Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Exclude:
     - 'spec/configuration_spec.rb'
+    - 'spec/integration/active_record/meilisearch_calls_are_deactivated.rb'
+    - 'spec/meilisearch/activation_spec.rb'
+    - 'spec/safe_index_spec.rb'
     - 'spec/settings_spec.rb'
     - 'spec/utilities_spec.rb'
 
-# Offense count: 25
+# Offense count: 29
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
   Exclude:
-    - 'spec/integration_spec.rb'
+    - 'spec/system/tech_shop_spec.rb'
 
 # Offense count: 1
 RSpec/MultipleDescribes:
   Exclude:
-    - 'spec/integration_spec.rb'
+    - 'spec/search_spec.rb'
+
+# Offense count: 2
+RSpec/NestedGroups:
+  Max: 4
 
 # Offense count: 1
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Exclude:
     - 'spec/configuration_spec.rb'
 
-# Offense count: 1
-Security/MarshalLoad:
-  Exclude:
-    - 'spec/integration_spec.rb'
-
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -172,13 +169,13 @@ Style/Alias:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 9
+# Offense count: 8
 # This cop supports safe auto-correction (--auto-correct).
 Style/IfUnlessModifier:
   Exclude:
@@ -212,26 +209,17 @@ Style/OptionalBooleanParameter:
   Exclude:
     - 'lib/meilisearch-rails.rb'
 
-# Offense count: 11
+# Offense count: 5
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Exclude:
-    - 'spec/integration_spec.rb'
     - 'spec/ms_clean_up_job_spec.rb'
 
-# Offense count: 2
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyleForMultiline.
-# SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
-  Exclude:
-    - 'spec/integration_spec.rb'
-
-# Offense count: 20
+# Offense count: 16
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
 # URISchemes: http, https
 Layout/LineLength:
-  Max: 178
+  Max: 170

spec/instance_methods_spec.rb

@@ -13,9 +13,9 @@
       )
 
       expect(book.ms_entries).to contain_exactly(
-        a_hash_including("index_uid" => /SecuredBook/),
-        a_hash_including("index_uid" => /BookAuthor/),
-        a_hash_including("index_uid" => /Book/),
+        a_hash_including('index_uid' => /SecuredBook/),
+        a_hash_including('index_uid' => /BookAuthor/),
+        a_hash_including('index_uid' => /Book/)
       )
     end
 
@@ -27,10 +27,10 @@
       )
 
       expect(book.ms_entries).to contain_exactly(
-        a_hash_including("index_uid" => /SecuredBook/),
-        a_hash_including("index_uid" => /BookAuthor/),
+        a_hash_including('index_uid' => /SecuredBook/),
+        a_hash_including('index_uid' => /BookAuthor/),
         # also includes book's id as if it was a public book
-        a_hash_including("index_uid" => /Book/),
+        a_hash_including('index_uid' => /Book/)
       )
     end
 
@@ -42,10 +42,12 @@
         taby_cat = Cat.create!(name: 'Taby the Cat')
 
         expect(toby_dog.ms_entries).to contain_exactly(
-          a_hash_including('primary_key' => /dog_\d+/))
+          a_hash_including('primary_key' => /dog_\d+/)
+        )
 
         expect(taby_cat.ms_entries).to contain_exactly(
-          a_hash_including('primary_key' => /cat_\d+/))
+          a_hash_including('primary_key' => /cat_\d+/)
+        )
       end
     end
   end

spec/integration/active_record/attributes_have_changed_spec.rb

@@ -65,4 +65,3 @@
     expect(results[0].id).to eq(m.id)
   end
 end
-

spec/integration/active_record/ms_rails_is_included_without_block_spec.rb

@@ -7,4 +7,3 @@
     end.to raise_error(ArgumentError)
   end
 end
-

spec/integration/active_record/record_has_associations_spec.rb

@@ -21,4 +21,3 @@
     end
   end
 end
-

spec/meilisearch/activation_spec.rb

@@ -1,39 +1,39 @@
 describe MeiliSearch::Rails do
   it 'is active by default' do
-    expect(MeiliSearch::Rails).to be_active
+    expect(described_class).to be_active
   end
 
   describe '#deactivate!' do
     context 'without block' do
-      before { MeiliSearch::Rails.deactivate! }
+      before { described_class.deactivate! }
 
-      after { MeiliSearch::Rails.activate! }
+      after { described_class.activate! }
 
       it 'deactivates the requests until activate!-ed' do
-        expect(MeiliSearch::Rails).not_to be_active
+        expect(described_class).not_to be_active
       end
 
       it 'responds with a black hole' do
-        expect(MeiliSearch::Rails.client.foo.bar.now.nil.item.issue).to be_nil
+        expect(described_class.client.foo.bar.now.nil.item.issue).to be_nil
       end
     end
 
     context 'with a block' do
       it 'disables only around call' do
-        MeiliSearch::Rails.deactivate! do
-          expect(MeiliSearch::Rails).not_to be_active
+        described_class.deactivate! do
+          expect(described_class).not_to be_active
         end
 
-        expect(MeiliSearch::Rails).to be_active
+        expect(described_class).to be_active
       end
 
       it 'works in multi-threaded environments' do
         Threads.new(5, log: $stdout).assert(20) do |_i, _r|
-          MeiliSearch::Rails.deactivate! do
-            expect(MeiliSearch::Rails).not_to be_active
+          described_class.deactivate! do
+            expect(described_class).not_to be_active
           end
 
-          expect(MeiliSearch::Rails).to be_active
+          expect(described_class).to be_active
         end
       end
     end

spec/options_spec.rb

@@ -216,7 +216,7 @@
 
         expect(b['hits'][0]).to include(
           'name' => '"> hack0r',
-          'author' => '',
+          'author' => ''
         )
       end
 
@@ -229,7 +229,7 @@
         b = Book.raw_search('hack', { attributes_to_highlight: ['*'] })
 
         expect(b['hits'][0]['_formatted']).to include(
-          'name' => '"&gt; <em>hack</em>0r',
+          'name' => '"&gt; <em>hack</em>0r'
         )
       end
     end