Skip to content

Commit 684a47b

Browse files
meili-bors[bot]meili-botcurquiza
authored
Merge #520
520: Changes related to the next Meilisearch release (v1.7.0) r=curquiza a=meili-bot Related to this issue: meilisearch/integration-guides#296 This PR: - gathers the changes related to the next Meilisearch release (v1.7.0) so that this package is ready when the official release is out. - should pass the tests against the [latest pre-release of Meilisearch](https://github.com/meilisearch/meilisearch/releases). - might eventually contain test failures until the Meilisearch v1.7.0 is out. ⚠️ This PR should NOT be merged until the next release of Meilisearch (v1.7.0) is out. _This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/main/resources/pre-release-week.md) purpose._ Co-authored-by: meili-bot <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]> Co-authored-by: curquiza <[email protected]>
2 parents d422a55 + c560365 commit 684a47b

File tree

3 files changed

+1
-26
lines changed

3 files changed

+1
-26
lines changed

README.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,8 +251,6 @@ JSON output:
251251
}
252252
```
253253

254-
You can enable it by querying PATCH /experimental-features with { "scoreDetails": true }
255-
256254
This feature is only available with Meilisearch v1.3 and newer (optional).
257255

258256
#### Custom Search With attributes on at search time <!-- omit in toc -->

spec/meilisearch/index/search/show_ranking_score_details_spec.rb

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,31 +3,12 @@
33
RSpec.describe 'MeiliSearch::Index - Search with ranking score details' do
44
include_context 'search books with genre'
55

6-
it 'experimental feature scoreDetails is not enabled so an error is raised' do
7-
enable_score_details(false)
8-
9-
expect do
10-
index.search('hobbit', { show_ranking_score_details: true })
11-
end.to raise_error(MeiliSearch::ApiError)
12-
end
13-
14-
it 'shows the ranking score details when showRankingScoreDetails is true' do
15-
enable_score_details(true)
16-
6+
it 'shows the ranking score details' do
177
response = index.search('hobbit', { show_ranking_score_details: true })
188
expect(response['hits'][0]).to have_key('_rankingScoreDetails')
199
end
2010

21-
it 'hides the ranking score details when showRankingScoreDetails is false' do
22-
enable_score_details(false)
23-
24-
response = index.search('hobbit', { show_ranking_score_details: false })
25-
expect(response['hits'][0]).not_to have_key('_rankingScoreDetails')
26-
end
27-
2811
it 'hides the ranking score details when showRankingScoreDetails is not set' do
29-
enable_score_details(false)
30-
3112
response = index.search('hobbit')
3213
expect(response['hits'][0]).not_to have_key('_rankingScoreDetails')
3314
end

spec/support/experimental_feature_helpers.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,6 @@
44
require 'json'
55

66
module ExperimentalFeatureHelpers
7-
def enable_score_details(toggle)
8-
configure_feature('scoreDetails', toggle)
9-
end
10-
117
def enable_vector_store(toggle)
128
configure_feature('vectorStore', toggle)
139
end

0 commit comments

Comments
 (0)