Merge #145

145: Changes related to the next MeiliSearch release (v0.19.0) r=curquiza a=meili-bot


This PR:
- gathers the changes related to the next MeiliSearch release (v0.19.0) so that this package is ready when the official release is out.
- should pass the tests against the [latest pre-release of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases).
- might eventually contain test failures until the MeiliSearch v0.19.0 is out.

⚠️ This PR should NOT be merged until the next release of MeiliSearch (v0.19.0) is out.

_This PR is auto-generated for the [pre-release week](https://github.com/meilisearch/integration-guides/blob/master/guides/pre-release-week.md) purpose._


Co-authored-by: meili-bot <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>

Author: 3 people

README.md

@@ -153,7 +153,7 @@ JSON output:
 
 ## 🤖 Compatibility with MeiliSearch
 
-This package only guarantees the compatibility with the [version v0.18.1 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.18.1).
+This package only guarantees the compatibility with the [version v0.19.0 of MeiliSearch](https://github.com/meilisearch/MeiliSearch/releases/tag/v0.19.0).
 
 ## 💡 Learn More
 

spec/meilisearch/index/documents_spec.rb

@@ -276,7 +276,7 @@
     end
   end
 
-  context 'Wrong primary-key (attribute does not exist) added when pushing documents' do
+  context 'Wrong primary-key (attribute does not exist) when pushing documents' do
     before(:all) do
       @uid = SecureRandom.hex(4)
       @client.create_index(@uid)
@@ -289,36 +289,17 @@
       { unique: 3, id: 1, title: 'Le Rouge et le Noir' }
     end
 
-    it 'adds the primary-key but not the documents' do
+    it 'does not add the primary key and the documents either' do
       response = index.update_documents(documents, 'objectId')
       expect(response).to be_a(Hash)
       expect(response).to have_key('updateId')
       sleep(0.2)
-      expect(index.fetch_primary_key).to eq('objectId')
-      expect(index.get_update_status(response['updateId'])['status']).to eq('failed')
-    end
-
-    it 'succeeds to add document with the primary-key' do
-      response = index.add_documents({ objectId: 1, title: 'Le Rouge et le Noir' }, 'id')
-      expect(response).to be_a(Hash)
-      expect(response).to have_key('updateId')
-      sleep(0.2)
-      expect(index.fetch_primary_key).to eq('objectId')
-      expect(index.get_update_status(response['updateId'])['status']).to eq('processed')
-      expect(index.documents.count).to eq(1)
-    end
-
-    it 'does not take into account the new primary key' do
-      response = index.add_documents({ id: 2, title: 'Le Petit Prince' }, 'id')
-      expect(response).to be_a(Hash)
-      expect(response).to have_key('updateId')
-      sleep(0.2)
-      expect(index.fetch_primary_key).to eq('objectId')
+      expect(index.fetch_primary_key).to be_nil
       expect(index.get_update_status(response['updateId'])['status']).to eq('failed')
     end
   end
 
-  context 'Wrong primary-key (attribute bad formatted) added when pushing documents' do
+  context 'Wrong primary-key (attribute bad formatted) when pushing documents' do
     before(:all) do
       @uid = SecureRandom.hex(4)
       @client.create_index(@uid)
@@ -331,12 +312,12 @@
       { id: 1, title: 'Le Rouge et le Noir' }
     end
 
-    it 'adds the primary-key but not the documents' do
+    it 'does not add the primary key and the documents either' do
       response = index.add_documents(documents, 'title')
       expect(response).to be_a(Hash)
       expect(response).to have_key('updateId')
       sleep(0.2)
-      expect(index.fetch_primary_key).to eq('title')
+      expect(index.fetch_primary_key).to be_nil
       expect(index.get_update_status(response['updateId'])['status']).to eq('failed')
       expect(index.documents.count).to eq(0)
     end