Fix RuboCop violations

Author: jmks

spec/meilisearch/index/search/multi_params_spec.rb

@@ -48,11 +48,11 @@
     response = index.update_filterable_attributes(['genre'])
     index.wait_for_pending_update(response['updateId'])
     response = index.search('prinec',
-                             {
-                               filter: ['genre = fantasy'],
-                               attributesToRetrieve: ['title'],
-                               attributesToHighlight: ['*']
-                             })
+                            {
+                              filter: ['genre = fantasy'],
+                              attributesToRetrieve: ['title'],
+                              attributesToHighlight: ['*']
+                            })
     expect(response.keys).to contain_exactly(*DEFAULT_SEARCH_RESPONSE_KEYS)
     expect(response['nbHits']).to eq(1)
     expect(response['hits'].first).to have_key('_formatted')

spec/meilisearch/index/settings_spec.rb

@@ -13,7 +13,6 @@
   end
   let(:default_searchable_attributes) { ['*'] }
   let(:default_displayed_attributes) { ['*'] }
-
   let(:settings_keys) do
     [
       'rankingRules',
@@ -26,14 +25,12 @@
       'sortableAttributes'
     ]
   end
+  let(:uid) { random_uid }
 
   context 'On global settings routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
+    let(:index) { client.index(uid) }
 
-    let(:index) { client.index(@uid) }
+    before { client.create_index(uid) }
 
     it 'gets default values of settings' do
       response = index.settings
@@ -95,15 +92,12 @@
   end
 
   context 'On ranking-rules sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:ranking_rules) { ['title:asc', 'words', 'typo'] }
     let(:wrong_ranking_rules) { ['title:asc', 'typos'] }
 
+    before { client.create_index(uid) }
+
     it 'gets default values of ranking rules' do
       response = index.ranking_rules
       expect(response).to eq(default_ranking_rules)
@@ -150,7 +144,6 @@
   end
 
   context 'On distinct-attribute sub-routes' do
-    let(:uid) { random_uid }
     let(:index) { client.index(uid) }
     let(:distinct_attribute) { 'title' }
 
@@ -191,14 +184,11 @@
   end
 
   context 'On searchable-attributes sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:searchable_attributes) { ['title', 'description'] }
 
+    before { client.create_index(uid) }
+
     it 'gets default values of searchable attributes' do
       response = index.searchable_attributes
       expect(response).to eq(default_searchable_attributes)
@@ -236,14 +226,11 @@
   end
 
   context 'On displayed-attributes sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:displayed_attributes) { ['title', 'description'] }
 
+    before { client.create_index(uid) }
+
     it 'gets default values of displayed attributes' do
       response = index.displayed_attributes
       expect(response).to eq(default_displayed_attributes)
@@ -282,12 +269,7 @@
   end
 
   context 'On synonyms sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:synonyms) do
       {
         wow: ['world of warcraft'],
@@ -296,6 +278,8 @@
       }
     end
 
+    before { client.create_index(uid) }
+
     it 'gets an empty hash of synonyms by default' do
       response = index.synonyms
       expect(response).to be_a(Hash)
@@ -354,15 +338,12 @@
   end
 
   context 'On stop-words sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:stop_words_array) { ['the', 'of'] }
     let(:stop_words_string) { 'a' }
 
+    before { client.create_index(uid) }
+
     it 'gets an empty array when there is no stop-words' do
       response = index.stop_words
       expect(response).to be_a(Array)
@@ -425,14 +406,11 @@
   end
 
   context 'On filterable-attributes sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:filterable_attributes) { ['title', 'description'] }
 
+    before { client.create_index(uid) }
+
     it 'gets default values of filterable attributes' do
       response = index.filterable_attributes
       expect(response).to be_a(Array)
@@ -471,14 +449,11 @@
   end
 
   context 'On sortable-attributes sub-routes' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
-
-    let(:index) { client.index(@uid) }
+    let(:index) { client.index(uid) }
     let(:sortable_attributes) { ['title', 'description'] }
 
+    before { client.create_index(uid) }
+
     it 'gets default values of sortable attributes' do
       response = index.sortable_attributes
       expect(response).to be_a(Array)
@@ -517,12 +492,9 @@
   end
 
   context 'Index with primary-key' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid, primaryKey: 'id')
-    end
+    let(:index) { client.index(uid) }
 
-    let(:index) { client.index(@uid) }
+    before { client.create_index(uid, primaryKey: 'id') }
 
     it 'gets the default values of settings' do
       response = index.settings
@@ -624,12 +596,9 @@
   end
 
   context 'Aliases' do
-    before do
-      @uid = random_uid
-      client.create_index(@uid)
-    end
+    let(:index) { client.index(uid) }
 
-    let(:index) { client.index(@uid) }
+    before { client.create_index(uid) }
 
     it 'works with method aliases' do
       expect(index.method(:settings) == index.method(:get_settings)).to be_truthy