Rubocop issues fixed

Author: André Mommert

lib/meilisearch/index.rb

@@ -386,7 +386,7 @@ def reset_stop_words
       Models::Task.new(response, task_endpoint)
     end
 
-    ### SETTINGS - DINSTINCT ATTRIBUTE
+    ### SETTINGS - DISTINCT ATTRIBUTE
 
     def distinct_attribute
       http_get "/indexes/#{@uid}/settings/distinct-attribute"

spec/meilisearch/client/requests_spec.rb

@@ -3,7 +3,7 @@
 RSpec.describe 'MeiliSearch::Client requests' do
   let(:key) { SecureRandom.uuid }
 
-  before(:each) do
+  before do
     expect(MeiliSearch::Client).to receive(:post)
       .with(kind_of(String), hash_including(body: "{\"primaryKey\":\"#{key}\",\"uid\":\"#{key}\"}"))
       .and_call_original

spec/meilisearch/client/token_spec.rb

@@ -53,7 +53,7 @@ def initialize(api_key)
       it 'decodes successfully using @api_key from instance' do
         expect do
           JWT.decode token, client_key, true, VERIFY_OPTIONS
-        end.to_not raise_error
+        end.not_to raise_error
       end
 
       it 'tries to decode without the right signature raises a error' do
@@ -89,7 +89,7 @@ def initialize(api_key)
       it 'allows generate token with a nil expires_at' do
         expect do
           instance.generate_tenant_token('uid', search_rules, expires_at: nil)
-        end.to_not raise_error
+        end.not_to raise_error
       end
 
       it 'decodes successfully the expires_at param' do
@@ -117,7 +117,7 @@ def initialize(api_key)
       it 'allows generate token without expires_at' do
         expect do
           instance.generate_tenant_token('uid', search_rules)
-        end.to_not raise_error
+        end.not_to raise_error
       end
     end
 

spec/meilisearch/index/base_spec.rb

@@ -5,7 +5,7 @@
     client.create_index('books').await
 
     index = client.fetch_index('books')
-    expect(index).to be_a(MeiliSearch::Index)
+    expect(index).to be_a(described_class)
     expect(index.uid).to eq('books')
     expect(index.created_at).to be_a(Time)
     expect(index.created_at).to be_within(60).of(Time.now)
@@ -59,7 +59,7 @@
     task.await
 
     index = client.fetch_index('uid')
-    expect(index).to be_a(MeiliSearch::Index)
+    expect(index).to be_a(described_class)
     expect(index.uid).to eq('uid')
     expect(index.primary_key).to eq('new_primary_key')
     expect(index.fetch_primary_key).to eq('new_primary_key')
@@ -77,7 +77,7 @@
     task.await
 
     index = client.fetch_index('books')
-    expect(index).to be_a(MeiliSearch::Index)
+    expect(index).to be_a(described_class)
     expect(index.uid).to eq('books')
     expect(index.primary_key).to eq('international_standard_book_number')
     expect(index.fetch_primary_key).to eq('international_standard_book_number')
@@ -111,7 +111,7 @@
     index = new_client.fetch_index('books')
     expect(index.options).to eq({ max_retries: 1, timeout: 2, convert_body?: true })
 
-    expect(MeiliSearch::Index).to receive(:get).with(
+    expect(described_class).to receive(:get).with(
       "#{URL}/indexes/books",
       {
         headers: expected_headers,
@@ -139,7 +139,7 @@
     index = new_client.fetch_index('books')
     expect(index.options).to eq(options.merge({ convert_body?: true }))
 
-    expect(MeiliSearch::Index).to receive(:get).with(
+    expect(described_class).to receive(:get).with(
       "#{URL}/indexes/books",
       {
         headers: expected_headers,
@@ -194,7 +194,7 @@
       task.await
 
       index = client.fetch_index('uid')
-      expect(index).to be_a(MeiliSearch::Index)
+      expect(index).to be_a(described_class)
       expect(index.uid).to eq('uid')
       expect(index.primary_key).to eq('new_primary_key')
       expect(index.fetch_primary_key).to eq('new_primary_key')

spec/meilisearch/index/search/q_spec.rb

@@ -72,13 +72,9 @@
   context 'with finite pagination params' do
     it 'responds with specialized fields' do
       response = index.search('coco', { page: 2, hits_per_page: 2 })
-
       expect(response.keys).to contain_exactly(*FINITE_PAGINATED_SEARCH_RESPONSE_KEYS)
-    end
 
-    it 'responds with specialized fields' do
       response = index.search('coco', { page: 2, hitsPerPage: 2 })
-
       expect(response.keys).to contain_exactly(*FINITE_PAGINATED_SEARCH_RESPONSE_KEYS)
     end
   end

…eilisearch/index/search/vector_search.rb …earch/index/search/vector_search_spec.rbspec/meilisearch/index/search/vector_search.rb renamed to spec/meilisearch/index/search/vector_search_spec.rb spec/meilisearch/index/search/vector_search.rb renamed to spec/meilisearch/index/search/vector_search_spec.rb

@@ -14,6 +14,7 @@
     new_index = client.index('vector_test_search')
     new_index.add_documents(documents).await
 
-    expect(new_index.search('q', vector: [0, 1, 2])['hits']).not_to be_empty
+    expect(new_index.search(vector: [9, 9, 9])['hits']).to be_empty
+    expect(new_index.search('All Things Must Pass')['hits']).not_to be_empty
   end
 end

spec/meilisearch/models/task_spec.rb

@@ -1,19 +1,20 @@
 # frozen_string_literal: true
 
 describe MeiliSearch::Models::Task do
+  subject { described_class.new task_hash, endpoint }
+
   let(:new_index_uid) { random_uid }
   let(:task_hash) { client.http_post '/indexes', { 'uid' => new_index_uid } }
   let(:endpoint) { MeiliSearch::Task.new(URL, MASTER_KEY, client.options) }
 
-  subject { described_class.new task_hash, endpoint }
-
   let(:enqueued_endpoint) { instance_double(MeiliSearch::Task, task: task_hash) }
   let(:enqueued_task) { described_class.new task_hash, enqueued_endpoint }
 
   let(:processing_endpoint) { instance_double(MeiliSearch::Task, task: task_hash.update('status' => 'processing')) }
   let(:processing_task) { described_class.new task_hash, processing_endpoint }
 
   let(:logger) { instance_double(Logger, warn: nil) }
+
   before { MeiliSearch::Utils.logger = logger }
   after { MeiliSearch::Utils.logger = nil }
 
@@ -362,6 +363,7 @@
 
     context 'when the task is already finished' do
       let(:endpoint) { instance_double(MeiliSearch::Task, task: task_hash, cancel_tasks: nil) }
+
       before { task_hash['status'] = 'succeeded' }
 
       it 'sends no request' do
@@ -374,6 +376,7 @@
 
     context 'when the task is already cancelled' do
       let(:endpoint) { instance_double(MeiliSearch::Task, task: task_hash, cancel_tasks: nil) }
+
       before { task_hash['status'] = 'cancelled' }
 
       it 'sends no request' do

spec/meilisearch/utils_spec.rb

@@ -4,8 +4,8 @@
   let(:logger) { instance_double(Logger, warn: nil) }
 
   describe '.soft_deprecate' do
-    before(:each) { described_class.logger = logger }
-    after(:each) { described_class.logger = nil }
+    before { described_class.logger = logger }
+    after { described_class.logger = nil }
 
     it 'outputs a warning' do
       described_class.soft_deprecate('footballs', 'snowballs')
@@ -45,8 +45,8 @@
   end
 
   describe '.transform_attributes' do
-    before(:each) { described_class.logger = logger }
-    after(:each) { described_class.logger = nil }
+    before { described_class.logger = logger }
+    after { described_class.logger = nil }
 
     it 'transforms snake_case into camelCased keys' do
       data = described_class.transform_attributes({
@@ -143,8 +143,8 @@
     end
 
     describe '.warn_on_non_conforming_attribute_names' do
-      before(:each) { described_class.logger = logger }
-      after(:each) { described_class.logger = nil }
+      before { described_class.logger = logger }
+      after { described_class.logger = nil }
 
       it 'warns when using camelCase attributes' do
         attrs = { attributesToHighlight: ['field'] }

spec/meilisearch_spec.rb

@@ -2,11 +2,11 @@
 
 RSpec.describe MeiliSearch do
   it 'has a version number' do
-    expect(MeiliSearch::VERSION).not_to be nil
+    expect(MeiliSearch::VERSION).not_to be_nil
   end
 
   it 'has a qualified version number' do
-    expect(MeiliSearch.qualified_version).to eq("Meilisearch Ruby (v#{MeiliSearch::VERSION})")
+    expect(described_class.qualified_version).to eq("Meilisearch Ruby (v#{MeiliSearch::VERSION})")
   end
 
   it 'raises an exception when it is impossible to connect' do
@@ -33,6 +33,6 @@
     new_client = MeiliSearch::Client.new(URL, MASTER_KEY)
 
     expect(new_client.headers).to have_key('User-Agent')
-    expect(new_client.headers['User-Agent']).to eq(MeiliSearch.qualified_version)
+    expect(new_client.headers['User-Agent']).to eq(described_class.qualified_version)
   end
 end