Skip to content

Commit c6eb08f

Browse files
Merge #270
270: Add Dir glob to prevent LoadError's again r=curquiza a=brunoocasali Related to #268 The issue was already fixed by #269 PR. But the idea of this PR is to prevent that kind of error from happening again in the future. Actually, I didn’t find a really good way to test this behavior in RSpec, if anyone has an idea, please ping me :) I've builded locally the gem and tested in irb, everything seems to be working fine: ```rb irb(main):001:0> require 'meilisearch' => true irb(main):002:0> MeiliSearch::VERSION => "0.17.2.beta" irb(main):003:0> new_client = MeiliSearch::Client.new('http://localhost:7700', 'masterKey') => #<MeiliSearch::Client:0x00007fa0f586b3c8 `@base_url="http://localhost:7700",` `@api_key="masterKey",` `@options={},` `@headers={"Content-Type"=>"application/json",` "X-Meili-API-Key"=>"masterKey"}, `@hea...` irb(main):004:0> new_client.indexes => [] irb(main):005:0> ``` Co-authored-by: Bruno Casali <[email protected]>
2 parents 59aaf9c + 96fb15e commit c6eb08f

File tree

2 files changed

+2
-19
lines changed

2 files changed

+2
-19
lines changed

.rubocop_todo.yml

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,11 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2021-11-18 03:06:45 UTC using RuboCop version 1.23.0.
3+
# on 2021-11-19 14:59:32 UTC using RuboCop version 1.23.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9-
# Offense count: 1
10-
# Cop supports --auto-correct.
11-
# Configuration parameters: Include.
12-
# Include: **/*.gemspec
13-
Gemspec/DateAssignment:
14-
Exclude:
15-
- 'meilisearch.gemspec'
16-
179
# Offense count: 1
1810
# Cop supports --auto-correct.
1911
# Configuration parameters: Include.

meilisearch.gemspec

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,8 @@ Gem::Specification.new do |s|
1111
s.description = 'An easy-to-use ruby client for Meilisearch API. See https://github.com/meilisearch/MeiliSearch'
1212
s.homepage = 'https://github.com/meilisearch/meilisearch-ruby'
1313
s.licenses = ['MIT']
14-
s.date = Time.now
1514

16-
s.files = [
17-
'lib/meilisearch.rb',
18-
'lib/meilisearch/error.rb',
19-
'lib/meilisearch/http_request.rb',
20-
'lib/meilisearch/client.rb',
21-
'lib/meilisearch/index.rb',
22-
'lib/meilisearch/version.rb',
23-
'lib/meilisearch/utils.rb'
24-
]
15+
s.files = Dir['{lib}/**/*', 'LICENSE', 'README.md']
2516

2617
s.required_ruby_version = '>= 2.6.0'
2718
s.add_dependency 'httparty', '>= 0.17.1', '< 0.21.0'

0 commit comments

Comments
 (0)