Merge #231

231: Handle case when client returns a 500 error without a JSON response r=curquiza a=rafaeelaudibert

When MeiliSearch is running behind any reverse proxy and does not respond to the request in time, the gateway may return a plain HTTP error page. The client tries to parse such a response in order to determine if there are any errors and end up raising JSON::ParseError, because the proxies tend to return an HTML body.

Closes #88

Co-authored-by: RafaAudibert <[email protected]>
Co-authored-by: Clémentine Urquizar <[email protected]>

Author: 3 people

lib/meilisearch/error.rb

@@ -33,6 +33,11 @@ def get_meilisearch_error_info(http_body)
       @ms_message = @http_body['message']
       @ms_type = @http_body['errorType']
       @ms_link = @http_body['errorLink']
+    rescue JSON::ParserError
+      # We might receive a JSON::ParserError when, for example, MeiliSearch is running behind
+      # some proxy (ELB or Nginx, for example), and the request timeouts, returning us
+      # a raw HTML body instead of a JSON as we were expecting
+      @ms_message = "The server has not returned a valid JSON HTTP body: #{http_body}"
     end
 
     def details