Merge #175

175: Adding possibility to send body null and tests r=bidoubiwa a=alallema

**Description**
Adding the possibility for the client to send body null.
Fixing update settings method.
Adding tests to check if nil could be sent properly.

**Issue related**
#121

****
Still not working on `update_synonyms()` and `update_stop_words()` method because the meilisearch API doesn't seem to take null as arguments

Co-authored-by: alallema <[email protected]>
Co-authored-by: Amélie <[email protected]>

Author: bors[bot]

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2021-03-16 11:04:59 UTC using RuboCop version 1.11.0.
+# on 2021-05-05 07:48:22 UTC using RuboCop version 1.13.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -14,11 +14,11 @@ Gemspec/DateAssignment:
   Exclude:
     - 'meilisearch.gemspec'
 
-# Offense count: 30
+# Offense count: 34
 # Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 # IgnoredMethods: refine
 Metrics/BlockLength:
-  Max: 432
+  Max: 445
 
 # Offense count: 1
 # Configuration parameters: CountComments, CountAsOne.
@@ -31,6 +31,7 @@ Naming/AccessorMethodName:
     - 'lib/meilisearch/index.rb'
 
 # Offense count: 7
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Exclude:
     - 'spec/**/*'

lib/meilisearch/http_request.rb

@@ -63,7 +63,7 @@ def send_request(http_method, relative_path, query_params = nil, body = nil)
     end
 
     def http_config(query_params, body)
-      body = body.to_json unless body.nil?
+      body = body.to_json
       {
         headers: @headers,
         query: query_params,

spec/meilisearch/index/settings_spec.rb

@@ -113,6 +113,13 @@
       expect(index.ranking_rules).to eq(ranking_rules)
     end
 
+    it 'updates ranking rules at null' do
+      response = index.update_ranking_rules(nil)
+      expect(response).to have_key('updateId')
+      index.wait_for_pending_update(response['updateId'])
+      expect(index.ranking_rules).to eq(default_ranking_rules)
+    end
+
     it 'fails when updating with wrong ranking rules name' do
       expect do
         index.update_ranking_rules(wrong_ranking_rules)
@@ -150,6 +157,13 @@
       expect(index.distinct_attribute).to eq(distinct_attribute)
     end
 
+    it 'updates distinct attribute at null' do
+      response = index.update_distinct_attribute(nil)
+      expect(response).to have_key('updateId')
+      index.wait_for_pending_update(response['updateId'])
+      expect(index.distinct_attribute).to be_nil
+    end
+
     it 'resets distinct attribute' do
       response = index.reset_distinct_attribute
       expect(response).to have_key('updateId')
@@ -181,6 +195,13 @@
       expect(index.searchable_attributes).to eq(searchable_attributes)
     end
 
+    it 'updates searchable attributes at null' do
+      response = index.update_searchable_attributes(nil)
+      expect(response).to have_key('updateId')
+      index.wait_for_pending_update(response['updateId'])
+      expect(index.searchable_attributes).to eq(default_searchable_attributes)
+    end
+
     it 'resets searchable attributes' do
       response = index.reset_searchable_attributes
       expect(response).to have_key('updateId')
@@ -213,6 +234,13 @@
       expect(index.displayed_attributes).to contain_exactly(*displayed_attributes)
     end
 
+    it 'updates displayed attributes at null' do
+      response = index.update_displayed_attributes(nil)
+      expect(response).to have_key('updateId')
+      index.wait_for_pending_update(response['updateId'])
+      expect(index.displayed_attributes).to eq(default_displayed_attributes)
+    end
+
     it 'resets displayed attributes' do
       response = index.reset_displayed_attributes
       expect(response).to have_key('updateId')
@@ -366,6 +394,13 @@
       expect(index.attributes_for_faceting).to contain_exactly(*attributes_for_faceting)
     end
 
+    it 'updates attributes for faceting at null' do
+      response = index.update_attributes_for_faceting(nil)
+      expect(response).to have_key('updateId')
+      index.wait_for_pending_update(response['updateId'])
+      expect(index.attributes_for_faceting).to be_empty
+    end
+
     it 'resets attributes for faceting' do
       response = index.reset_attributes_for_faceting
       expect(response).to have_key('updateId')