Fix conflicts and update code to work in v1.3

Author: brunoocasali

lib/meilisearch/utils.rb

@@ -5,12 +5,11 @@ module Utils
     SNAKE_CASE = /[^a-zA-Z0-9]+(.)/.freeze
 
     def self.transform_attributes(body)
-      warn_on_non_conforming_attribute_names(body)
-
       case body
       when Array
         body.map { |item| transform_attributes(item) }
       when Hash
+        warn_on_non_conforming_attribute_names(body)
         parse(body)
       else
         body

spec/meilisearch/index/settings_spec.rb

@@ -773,7 +773,8 @@ def update_synonyms(index, synonyms)
       update_task = index.update_faceting({ 'max_values_per_facet' => 333 })
       client.wait_for_task(update_task['taskUid'])
 
-      expect(index.faceting).to eq({ 'maxValuesPerFacet' => 333 })
+      expect(index.faceting['maxValuesPerFacet']).to eq(333)
+      expect(index.faceting.transform_keys(&:to_sym).keys).to include(*default_faceting.keys)
     end
 
     it 'updates faceting at null' do

spec/meilisearch/utils_spec.rb

@@ -45,28 +45,47 @@
         ]
       )
     end
+
+    it 'warns when using camelCase' do
+      attrs = { distinctAttribute: 'title' }
+
+      expect do
+        described_class.transform_attributes(attrs)
+      end.to output(include('Attributes will be expected to be snake_case', 'distinctAttribute')).to_stderr
+    end
+
+    it 'warns when using camelCase in an array' do
+      attrs = [
+        { 'index_uid' => 'movies', 'q' => 'prince' },
+        { 'indexUid' => 'books', 'q' => 'prince' }
+      ]
+
+      expect do
+        described_class.transform_attributes(attrs)
+      end.to output(include('Attributes will be expected to be snake_case', 'indexUid')).to_stderr
+    end
   end
 
   describe '.version_error_handler' do
     it 'spawns same error message' do
       expect do
-        MeiliSearch::Utils.version_error_handler(:my_method) do
+        described_class.version_error_handler(:my_method) do
           raise MeiliSearch::ApiError.new(405, 'I came from Meili server', {})
         end
       end.to raise_error(MeiliSearch::ApiError, /I came from Meili server/)
     end
 
     it 'spawns message with version hint' do
       expect do
-        MeiliSearch::Utils.version_error_handler(:my_method) do
+        described_class.version_error_handler(:my_method) do
           raise MeiliSearch::ApiError.new(405, 'I came from Meili server', {})
         end
       end.to raise_error(MeiliSearch::ApiError, /that `my_method` call requires/)
     end
 
     it 'adds hints to all error types' do
       expect do
-        MeiliSearch::Utils.version_error_handler(:my_method) do
+        described_class.version_error_handler(:my_method) do
           raise MeiliSearch::CommunicationError, 'I am an error'
         end
       end.to raise_error(MeiliSearch::CommunicationError, /that `my_method` call requires/)
@@ -77,23 +96,23 @@
         attrs = { attributesToHighlight: ['field'] }
 
         expect do
-          Utils.warn_on_non_conforming_attribute_names(attrs)
+          described_class.warn_on_non_conforming_attribute_names(attrs)
         end.to output(include('Attributes will be expected to be snake_case', 'attributesToHighlight')).to_stderr
       end
 
       it 'warns when using a mixed case' do
         attrs = { distinct_ATTribute: 'title' }
 
         expect do
-          Utils.warn_on_non_conforming_attribute_names(attrs)
+          described_class.warn_on_non_conforming_attribute_names(attrs)
         end.to output(include('Attributes will be expected to be snake_case', 'distinct_ATTribute')).to_stderr
       end
 
       it 'does not warn when using snake_case' do
         attrs = { q: 'query', attributes_to_highlight: ['field'] }
 
         expect do
-          Utils.warn_on_non_conforming_attribute_names(attrs)
+          described_class.warn_on_non_conforming_attribute_names(attrs)
         end.not_to output.to_stderr
       end
     end