Merge pull request #2 from L-Weisz/fix/indexNames

feat(configuration-validation): test that indexName is an array

Author: L-Weisz

server/__tests__/configuration-validation.test.js

@@ -113,7 +113,7 @@ describe('Test plugin configuration', () => {
     expect(strapiMock.log.error).toHaveBeenCalledTimes(0)
   })
 
-  test('Test indexName with empty string', async () => {
+  test('Test indexName with string', async () => {
     validatePluginConfig({
       restaurant: {
         indexName: '',
@@ -122,14 +122,14 @@ describe('Test plugin configuration', () => {
     expect(strapiMock.log.warn).toHaveBeenCalledTimes(0)
     expect(strapiMock.log.error).toHaveBeenCalledTimes(1)
     expect(strapiMock.log.error).toHaveBeenCalledWith(
-      'The "indexName" option of "restaurant" should be a non-empty string',
+      'The "indexName" option of "restaurant" should be a non-empty array of strings',
     )
   })
 
-  test('Test indexName with non-empty string', async () => {
+  test('Test indexName with non-empty array', async () => {
     validatePluginConfig({
       restaurant: {
-        indexName: 'hello',
+        indexName: ['hello'],
       },
     })
     expect(strapiMock.log.warn).toHaveBeenCalledTimes(0)

server/configuration-validation.js

@@ -182,13 +182,10 @@ function CollectionConfig({ collectionName, configuration }) {
 
   return {
     validateIndexName() {
-      // indexName is either undefined or a none empty string
-      if (
-        (indexName !== undefined && typeof indexName !== 'string') ||
-        indexName === ''
-      ) {
+      // indexName is either undefined or a non empty array of string
+      if (indexName !== undefined && !Array.isArray(indexName)) {
         log.error(
-          `The "indexName" option of "${collectionName}" should be a non-empty string`,
+          `The "indexName" option of "${collectionName}" should be a non-empty array of strings`,
         )
       } else if (indexName !== undefined) {
         options.indexName = indexName