Skip to content

Commit 84d2b81

Browse files
meili-bors[bot]brunoocasalicurquiza
authored
Merge #874
874: Upgrade libraries & push node min version to 18 r=curquiza a=brunoocasali # Pull Request ## Related issue Fixes #<issue_number> ## What does this PR do? - ... ## PR checklist Please check if your PR fulfills the following requirements: - [ ] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [ ] Have you read the contributing guidelines? - [ ] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Bruno Casali <[email protected]> Co-authored-by: Clémentine U. - curqui <[email protected]>
2 parents 40de021 + e098320 commit 84d2b81

File tree

6 files changed

+10
-14
lines changed

6 files changed

+10
-14
lines changed

.github/workflows/beta-tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
# Strapi is not yet compatible with node 18
17-
node: ['16', '18']
16+
node: ['18', '20']
1817
name: integration-tests (Node.js ${{ matrix.node }})
1918
steps:
2019
- uses: actions/checkout@v4
@@ -31,7 +30,7 @@ jobs:
3130
runs-on: ubuntu-latest
3231
strategy:
3332
matrix:
34-
node: ['16', '18']
33+
node: ['18', '20']
3534
name: playground-build (Node.js ${{ matrix.node }})
3635
steps:
3736
- uses: actions/checkout@v4

.github/workflows/pre-release-tests.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,7 @@ jobs:
1313
runs-on: ubuntu-latest
1414
strategy:
1515
matrix:
16-
# Strapi is not yet compatible with node 16
17-
node: ['16', '18']
16+
node: ['18', '20']
1817
name: integration-tests (Node.js ${{ matrix.node }})
1918
steps:
2019
- uses: actions/checkout@v4
@@ -31,7 +30,7 @@ jobs:
3130
runs-on: ubuntu-latest
3231
strategy:
3332
matrix:
34-
node: ['16', '18']
33+
node: ['18', '20']
3534
name: playground-build (Node.js ${{ matrix.node }})
3635
steps:
3736
- uses: actions/checkout@v4

.github/workflows/publish.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@ jobs:
1010
- uses: actions/checkout@v4
1111
- uses: actions/setup-node@v4
1212
with:
13-
node-version: 14
14-
registry-url: https://registry.npmjs.org/
13+
node-version: 20
1514
- name: Check release validity
1615
run: sh .github/scripts/check-release.sh
1716
- name: Check tag format

.github/workflows/tests.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ jobs:
1717
runs-on: ubuntu-latest
1818
strategy:
1919
matrix:
20-
# Strapi is not yet compatible with node 16
2120
node: ['18', '20']
2221
name: integration-tests (Node.js ${{ matrix.node }})
2322
steps:

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -565,10 +565,9 @@ If you are using [Strapi v3](https://github.com/strapi/strapi/tree/v3.6.9), plea
565565

566566
This package guarantees compatibility with [version v1.x of Meilisearch](https://github.com/meilisearch/meilisearch/releases/latest), but some features may not be present. Please check the [issues](https://github.com/meilisearch/strapi-plugin-meilisearch/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+label%3Aenhancement) for more info.
567567

568-
**Node / NPM versions**:
568+
**Node**:
569569

570-
- NodeJS >= 14.10 <= 16
571-
- NPM >= 6.x
570+
- NodeJS >= 18
572571

573572
**We recommend always using the latest version of Strapi to start your new projects**.
574573

package.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@
4242
}
4343
],
4444
"engines": {
45-
"npm": ">=6.0.0"
45+
"npm": ">=6.0.0",
46+
"node": ">=18"
4647
},
4748
"bugs": {
4849
"url": "https://github.com/meilisearch/strapi-plugin-meilisearch/issues"
@@ -74,4 +75,4 @@
7475
"jest": "^27.4.3",
7576
"prettier": "2.2.1"
7677
}
77-
}
78+
}

0 commit comments

Comments
 (0)