Skip to content

Commit d441dba

Browse files
authored
Merge pull request #70 from meisterplan/feature/KNUTH-123154-remove-legacy-prometheus-he
KNUTH-123154 Remove legacy Prometheus Helm tagging on additional resources
2 parents 7595967 + 0aff7ad commit d441dba

File tree

12 files changed

+10
-29
lines changed

12 files changed

+10
-29
lines changed

CHANGELOG.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# spring-service
22

3+
## 5.1.1
4+
5+
- Remove now unnecessary, confusing Helm chart labels on prom resources
6+
37
## 5.1.0
48

59
- Update externalsecrets.io CRDs to v1.
@@ -223,6 +227,10 @@ deployment** with a short 503 service disruption due to a [bug in the ingress co
223227

224228
# cronjob
225229

230+
## 3.1.1
231+
232+
- Remove now unnecessary, confusing Helm chart labels on prom resources
233+
226234
## 3.1.0
227235

228236
- Update externalsecrets.io CRDs to v1.

charts/cronjob/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
apiVersion: v1
22
name: cronjob
33
description: A generalized cronjob that can access secrets.
4-
version: 3.1.0
4+
version: 3.1.1

charts/cronjob/templates/post-deployment/prometheus-rules.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ apiVersion: monitoring.coreos.com/v1
22
kind: PrometheusRule
33
metadata:
44
namespace: "{{ .Values.namespace }}"
5-
labels:
6-
app: kube-prometheus-stack
7-
release: prometheus
85
name: "{{ .Values.cronJobName }}"
96
spec:
107
groups:

charts/spring-service/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
apiVersion: v1
22
name: spring-service
33
description: A generalized deployment for Meisterplan Spring Boot services in Kubernetes.
4-
version: 5.1.0
4+
version: 5.1.1

charts/spring-service/templates/post-deployment/prometheus-rules.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ apiVersion: monitoring.coreos.com/v1
22
kind: PrometheusRule
33
metadata:
44
namespace: "{{ .Values.namespace }}"
5-
labels:
6-
app: kube-prometheus-stack
7-
release: prometheus
85
name: "{{ .Values.serviceName }}"
96
spec:
107
groups:

charts/spring-service/templates/pre-deployment/pod-monitor.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ kind: PodMonitor
44
metadata:
55
name: "{{ .Values.serviceName }}"
66
namespace: "{{ .Values.namespace }}"
7-
labels:
8-
app: kube-prometheus-stack
9-
release: prometheus
107
spec:
118
selector:
129
matchLabels:

tests/cronjob/service-account-cronjob/expected/cronjob/templates/post-deployment/prometheus-rules.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ apiVersion: monitoring.coreos.com/v1
44
kind: PrometheusRule
55
metadata:
66
namespace: "team-superpower"
7-
labels:
8-
app: kube-prometheus-stack
9-
release: prometheus
107
name: "simple-job-staging"
118
spec:
129
groups:

tests/cronjob/simple-cronjob/expected/cronjob/templates/post-deployment/prometheus-rules.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ apiVersion: monitoring.coreos.com/v1
44
kind: PrometheusRule
55
metadata:
66
namespace: "team-superpower"
7-
labels:
8-
app: kube-prometheus-stack
9-
release: prometheus
107
name: "simple-job-staging"
118
spec:
129
groups:

tests/spring-service/complex-service/expected/spring-service/templates/post-deployment/prometheus-rules.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ apiVersion: monitoring.coreos.com/v1
44
kind: PrometheusRule
55
metadata:
66
namespace: "team-supercool"
7-
labels:
8-
app: kube-prometheus-stack
9-
release: prometheus
107
name: "myservice"
118
spec:
129
groups:

tests/spring-service/complex-service/expected/spring-service/templates/pre-deployment/pod-monitor.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ kind: PodMonitor
55
metadata:
66
name: "myservice"
77
namespace: "team-supercool"
8-
labels:
9-
app: kube-prometheus-stack
10-
release: prometheus
118
spec:
129
selector:
1310
matchLabels:

0 commit comments

Comments
 (0)