chore: fix eslint configuration

jsamr · jsamr · commit b9e3dbabee26 · 2021-08-29T17:30:29.000-03:00
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -26,14 +26,6 @@ module.exports = {
           '{}': false
         }
       }
-    ],
-    '@typescript-eslint/member-ordering': [
-      'error',
-      {
-        default: {
-          order: 'alphabetically'
-        }
-      }
     ]
   }
 };
diff --git a/apps/demo/package.json b/apps/demo/package.json
@@ -8,7 +8,8 @@
     "eject": "expo eject",
     "publish": "expo publish",
     "test": "jest --watchAll",
-    "test:ts": "tsc --noEmit"
+    "test:ts": "tsc --noEmit",
+    "test:lint": "eslint --ext ts,tsx src/"
   },
   "jest": {
     "preset": "jest-expo"
diff --git a/apps/demo/src/components/UIColorPickerControlAtom.tsx b/apps/demo/src/components/UIColorPickerControlAtom.tsx
@@ -3,6 +3,7 @@ import Color from 'color';
 import React, { ComponentType, useCallback, useEffect, useState } from 'react';
 import { Dimensions, View } from 'react-native';
 import { NativeViewGestureHandler } from 'react-native-gesture-handler';
+// eslint-disable-next-line @typescript-eslint/no-var-requires
 const HsvColorPicker = require('react-native-hsv-color-picker')
   .default as HsvColorPicker;
 import { SelectorProps, PropsWithStyle } from './nucleons/types';
diff --git a/apps/demo/src/components/UINavResourceTide.tsx b/apps/demo/src/components/UINavResourceTide.tsx
@@ -22,10 +22,10 @@ export default function UINavResourceTideMolecule<R extends ResourceRoute>({
       leftIconName={definition.iconName}
       title={definition.title}
       style={useSurfaceBackgroundStyleNucleon()}
-      onPress={useCallback(() => navigation.navigate(route), [
-        navigation,
-        route
-      ])}
+      onPress={useCallback(
+        () => navigation.navigate(route),
+        [navigation, route]
+      )}
     />
   );
 }
diff --git a/apps/demo/src/components/UINavTideMolecule.tsx b/apps/demo/src/components/UINavTideMolecule.tsx
@@ -33,10 +33,10 @@ export default function UINavTideMolecule<R extends string>({
     <UITideAtom
       {...listProps}
       title={label}
-      onPress={useCallback(() => navigation.navigate(route), [
-        navigation,
-        route
-      ])}
+      onPress={useCallback(
+        () => navigation.navigate(route),
+        [navigation, route]
+      )}
       bottom={bottom}
       leftIconName={leftIconName}
       rightIconName="arrow-right"
diff --git a/apps/demo/src/components/UIRadioItemAtom.tsx b/apps/demo/src/components/UIRadioItemAtom.tsx
@@ -37,10 +37,10 @@ const UIRadioItemAtom = memo(function RadioItem<V extends string>({
   labelStyle?: StyleProp<TextStyle>;
   style?: StyleProp<ViewStyle>;
 }) {
-  const onPress = useCallback(() => onSelectedValueChange(value), [
-    value,
-    onSelectedValueChange
-  ]);
+  const onPress = useCallback(
+    () => onSelectedValueChange(value),
+    [value, onSelectedValueChange]
+  );
   const selected = useContext(selectedRadioItemContextAtom) === value;
   const { pressable, selectable, surface } = useColorRoles();
   const color = selected
diff --git a/apps/demo/src/components/UISliderControlAtom.tsx b/apps/demo/src/components/UISliderControlAtom.tsx
@@ -6,11 +6,11 @@ import { useNuclearContentWidth } from './nucleons/useContentWidthContext';
 import { useColorRoles } from '../theme/colorSystem';
 
 const GestureSlider = Platform.select({
-  android: (createNativeWrapper(Slider, {
+  android: createNativeWrapper(Slider, {
     disallowInterruption: true,
     shouldActivateOnStart: true,
     shouldCancelWhenOutside: false
-  }) as unknown) as typeof Slider,
+  }) as unknown as typeof Slider,
   default: Slider
 });
 
diff --git a/apps/demo/src/components/UISourceDisplayMolecule.tsx b/apps/demo/src/components/UISourceDisplayMolecule.tsx
@@ -41,10 +41,11 @@ export default function UISourceDisplayMolecule({
     role: textRole
   });
   const syntheticPaddingVertical = useSpacing(paddingVertical ?? 0);
-  const lineNumberDisplayWidthComputer: HighlighterProps['lineNumberDisplayWidthComputer'] = useCallback(
-    (fs, maxLineNumberCharLength) => spacing + fs * maxLineNumberCharLength,
-    [spacing]
-  );
+  const lineNumberDisplayWidthComputer: HighlighterProps['lineNumberDisplayWidthComputer'] =
+    useCallback(
+      (fs, maxLineNumberCharLength) => spacing + fs * maxLineNumberCharLength,
+      [spacing]
+    );
   return (
     <Highlighter
       {...otherProps}
diff --git a/apps/demo/src/components/nucleons/useTextRoleNucleon.tsx b/apps/demo/src/components/nucleons/useTextRoleNucleon.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { TextStyle } from 'react-native';
 import { useColorRoles } from '../../theme/colorSystem';
 
@@ -86,11 +87,11 @@ const roleDefs: Record<
   uiMono: { fontSize: BASE_FONT_SIZE * 0.9, fontFamily: FONT_MONO },
   uiHyperlink: { fontSize: 5, fontFamily: FONT_MONO },
   footer: { fontSize: BASE_FONT_SIZE * 0.8, fontFamily: FONT_MONO },
-  //@ts-expect-error
+  //@ts-ignore
   html: { fontSize: BASE_FONT_SIZE * 0.9 },
-  //@ts-expect-error
+  //@ts-ignore
   bodyInlineCode: { fontFamily: FONT_MONO },
-  //@ts-expect-error
+  //@ts-ignore
   bodyAPIRef: { fontFamily: FONT_MONO },
   sectionOutline: {
     fontSize: BASE_FONT_SIZE * 0.8,
diff --git a/apps/demo/src/components/screens/HomeDrawerScreen/VersionDisplay.tsx b/apps/demo/src/components/screens/HomeDrawerScreen/VersionDisplay.tsx
@@ -2,6 +2,7 @@
 import * as React from 'react';
 import { View } from 'react-native';
 import { useSafeAreaInsets } from 'react-native-safe-area-context';
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 // @ts-ignore
 import version from '../../../../version';
 import TextRoleNucleon from '../../nucleons/TextRoleNucleon';
diff --git a/apps/demo/src/components/screens/HomeDrawerScreen/groupBy.ts b/apps/demo/src/components/screens/HomeDrawerScreen/groupBy.ts
@@ -1,5 +1,6 @@
 export default function groupBy<T, K extends keyof T>(xs: Array<T>, key: K) {
   return xs.reduce(function (rv, x) {
+    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     //@ts-ignore
     (rv[x[key]] = rv[x[key]] || []).push(x);
     return rv;
diff --git a/apps/demo/src/components/screens/HomeDrawerScreen/index.tsx b/apps/demo/src/components/screens/HomeDrawerScreen/index.tsx
@@ -102,6 +102,7 @@ function mapGroup({
     <Drawer.Screen
       component={component}
       options={{
+        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
         //@ts-ignore
         group,
         groupLabel,
diff --git a/apps/demo/src/components/templates/ArticleTemplate/index.tsx b/apps/demo/src/components/templates/ArticleTemplate/index.tsx
@@ -178,7 +178,8 @@ export default function ArticleTemplate(
 ) {
   const { params } = useRoute();
   const { height: safeFrameHeight, width: safeFrameWidth } = useSafeAreaFrame();
-  const scrollRef = useRef<Animated.ScrollView>() as RefObject<Animated.ScrollView>;
+  const scrollRef =
+    useRef<Animated.ScrollView>() as RefObject<Animated.ScrollView>;
   const fragment = (params as any)?.fragment;
   return (
     <ScrollerProvider scrollRef={scrollRef}>
diff --git a/apps/demo/src/highlight/createStylesheets.ts b/apps/demo/src/highlight/createStylesheets.ts
@@ -8,7 +8,7 @@ export type HighlighterStylesheets = ReturnType<typeof createStylesheets>;
 
 export default function createStylesheets(hljsStylesheet: HljsStylsheet) {
   const normalizedStyles = normalizeStylesheet(hljsStylesheet);
-  const { backgroundColor, color } = normalizedStyles['hljs'];
+  const { backgroundColor, color } = normalizedStyles.hljs;
   const containerStylesheet = StyleSheet.create({
     container: { backgroundColor: backgroundColor as string },
     text: { color }
diff --git a/apps/demo/src/nav-model.ts b/apps/demo/src/nav-model.ts
@@ -14,13 +14,11 @@ export interface ResourceRouteDefinition {
   iconName: IconName;
 }
 
-const pagesIndex: Record<
-  PageRoute,
-  ResourceRouteDefinition
-> = Object.fromEntries(
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  Object.entries(pagesSpecs).map(([_k, s]) => [`${s.group}-${s.id}`, s])
-) as any;
+const pagesIndex: Record<PageRoute, ResourceRouteDefinition> =
+  Object.fromEntries(
+    // eslint-disable-next-line @typescript-eslint/no-unused-vars
+    Object.entries(pagesSpecs).map(([_k, s]) => [`${s.group}-${s.id}`, s])
+  ) as any;
 
 const resourceRoutesIndex: Record<ResourceRoute, ResourceRouteDefinition> = {
   ...pagesIndex,
diff --git a/apps/demo/src/navigation/StackHeader.tsx b/apps/demo/src/navigation/StackHeader.tsx
@@ -11,9 +11,10 @@ export default function StackHeader(props: StackHeaderProps) {
   const {
     descriptor: { options, navigation }
   } = scene;
-  const onMenuPress = React.useCallback(() => navigation.goBack(), [
-    navigation
-  ]);
+  const onMenuPress = React.useCallback(
+    () => navigation.goBack(),
+    [navigation]
+  );
   return (
     <UIHeaderAtom>
       <UIAppbarActionAtom icon="arrow-left" onPress={onMenuPress} />
diff --git a/apps/demo/src/providers/PageToolkitProvider.tsx b/apps/demo/src/providers/PageToolkitProvider.tsx
@@ -35,6 +35,7 @@ import MaxWidthContainerAtom from '../components/MaxWidthContainerAtom';
 
 const genericOnLinkPress = (uri: string) => Linking.openURL(uri);
 
+// eslint-disable-next-line @typescript-eslint/ban-ts-comment
 //@ts-ignore
 function useOnLinkPress(uri: string): () => void;
 function useOnLinkPress(): (uri: string) => void;
@@ -95,26 +96,23 @@ function RefAPI({
   );
 }
 
-const SourceDisplayInner: UIToolkitConfig['SourceDisplay'] = function SourceDisplayInner({
-  content,
-  lang,
-  showLineNumbers
-}) {
-  return (
-    <ScrollView
-      horizontal
-      style={{ flexGrow: 0 }}
-      contentContainerStyle={{ flexGrow: 1 }}>
-      <UISourceDisplayMolecule
-        content={content}
-        language={lang as any}
-        showLineNumbers={showLineNumbers}
-        paddingVertical={2}
-        style={{ alignSelf: 'stretch' }}
-      />
-    </ScrollView>
-  );
-};
+const SourceDisplayInner: UIToolkitConfig['SourceDisplay'] =
+  function SourceDisplayInner({ content, lang, showLineNumbers }) {
+    return (
+      <ScrollView
+        horizontal
+        style={{ flexGrow: 0 }}
+        contentContainerStyle={{ flexGrow: 1 }}>
+        <UISourceDisplayMolecule
+          content={content}
+          language={lang as any}
+          showLineNumbers={showLineNumbers}
+          paddingVertical={2}
+          style={{ alignSelf: 'stretch' }}
+        />
+      </ScrollView>
+    );
+  };
 
 const SourceDisplay: UIToolkitConfig['SourceDisplay'] = ({
   title,
diff --git a/apps/demo/src/state/ColorSchemeProvider.tsx b/apps/demo/src/state/ColorSchemeProvider.tsx
@@ -24,9 +24,8 @@ export default function ColorSchemeProvider({
 }: PropsWithChildren<{
   initialColorScheme: ColorSchemeState['colorScheme'];
 }>) {
-  const [colorScheme, setColorScheme] = useState<
-    ColorSchemeState['colorScheme']
-  >(initialColorScheme);
+  const [colorScheme, setColorScheme] =
+    useState<ColorSchemeState['colorScheme']>(initialColorScheme);
   return (
     <ColorSchemeContext.Provider value={{ colorScheme, setColorScheme }}>
       {children}
diff --git a/apps/demo/src/substratum/index.tsx b/apps/demo/src/substratum/index.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unused-vars */
 import React, {
   createContext,
   PropsWithChildren,
@@ -50,6 +51,7 @@ export default function createColorSystem<CPD>() {
     return useContext(colorPrimitivesContext);
   }
   const ColorPrimitivesProvider = colorPrimitivesContext.Provider;
+  // eslint-disable-next-line @typescript-eslint/ban-ts-comment
   //@ts-ignore
   ColorPrimitivesProvider.displayName = ColorPrimitivesProvider;
   function createColorRoles<CR>() {
diff --git a/apps/demo/src/theme/alphaMixColor.ts b/apps/demo/src/theme/alphaMixColor.ts
@@ -3,7 +3,7 @@ import Color from 'color';
 export default function alphaMixColor(
   color: string,
   alpha: number,
-  background: string = 'white'
+  background = 'white'
 ) {
   return Color(color).alpha(alpha).mix(Color(background)).hex();
 }
diff --git a/apps/demo/src/theme/colorSystem.ts b/apps/demo/src/theme/colorSystem.ts
@@ -87,11 +87,8 @@ export interface ColorRoles {
   codeBackground: string;
 }
 
-const {
-  ColorPrimitivesProvider,
-  createColorRoles,
-  useColorPrimitives
-} = createColorSystem<ColorPrimitivesDeclaration>();
+const { ColorPrimitivesProvider, createColorRoles, useColorPrimitives } =
+  createColorSystem<ColorPrimitivesDeclaration>();
 
 const { ColorRolesProvider, useColorRoles } = createColorRoles<ColorRoles>();
 
diff --git a/packages/render-html/.eslintrc.js b/packages/render-html/.eslintrc.js
@@ -0,0 +1,16 @@
+// eslint-disable-next-line @typescript-eslint/no-var-requires
+const defaultConf = require('../../.eslintrc.js');
+module.exports = {
+  ...defaultConf,
+  rules: {
+    ...defaultConf.rules,
+    '@typescript-eslint/member-ordering': [
+      'error',
+      {
+        default: {
+          order: 'alphabetically'
+        }
+      }
+    ]
+  }
+};

Original file line number	Diff line number	Diff line change
`@@ -26,14 +26,6 @@ module.exports = {`
`26`	`26`	`'{}': false`
`27`	`27`	`}`
`28`	`28`	`}`
`29`		`- ],`
`30`		`- '@typescript-eslint/member-ordering': [`
`31`		`- 'error',`
`32`		`- {`
`33`		`- default: {`
`34`		`- order: 'alphabetically'`
`35`		`- }`
`36`		`- }`
`37`	`29`	`]`
`38`	`30`	`}`
`39`	`31`	`};`