chore(benchmarking): fix benchmarking app

Author: jsamr

apps/benchmarking/profiles.js

@@ -1,12 +1,13 @@
-import ProfileSimple from './profiles/ProfileSimple';
+// import ProfileSimple from './profiles/ProfileSimple';
 import ProfileV5 from './profiles/ProfileV5';
 import ProfileV6Source from './profiles/ProfileV6Source';
 
 const profiles = [
-  {
-    name: 'Simple implementation',
-    component: ProfileSimple
-  },
+  // Disabled because of htmlparser resolution
+  // {
+  //   name: 'Simple implementation',
+  //   component: ProfileSimple
+  // },
   {
     name: 'V5',
     component: ProfileV5

apps/benchmarking/profiles/ProfileSimple.js

@@ -1,7 +1,7 @@
 import React from 'react';
 import RenderHtmlSimple from './RenderHtmlSimple';
 
-export default function ProfileSimple({running, html, ignoredTags}) {
+export default function ProfileSimple({ running, html, ignoredTags }) {
   return (
     html &&
     running && <RenderHtmlSimple ignoredTags={ignoredTags} html={html} />

apps/benchmarking/profiles/ProfileV5.js

@@ -1,9 +1,9 @@
 import React from 'react';
 import RenderHtmlv5 from 'react-native-render-html-v5';
 
-export default function ProfileV5({running, ignoredTags, html}) {
+export default function ProfileV5({ running, ignoredTags, html }) {
   return (
     html &&
-    running && <RenderHtmlv5 ignoredTags={ignoredTags} source={{html}} />
+    running && <RenderHtmlv5 ignoredTags={ignoredTags} source={{ html }} />
   );
 }

apps/benchmarking/profiles/RenderHtmlSimple.js

@@ -1,26 +1,31 @@
-import {Text, View, Image} from 'react-native';
-import {parseDocument, ElementType} from 'htmlparser2';
-import React, {PureComponent} from 'react';
+import { Text, View, Image } from 'react-native';
+import { parseDocument, ElementType } from 'htmlparser2';
+import React, { PureComponent } from 'react';
 
 export default class RenderHtmlSimple extends PureComponent {
-  ignoredTags = ['head'];
-  textTags = ['span', 'strong', 'em'];
-
   constructor(props) {
     super(props);
     this.ignoredTags = props.ignoredTags || this.ignoredTags;
   }
 
-  renderTextNode(textNode, index) {
-    return <Text key={index}>{textNode.data}</Text>;
+  ignoredTags = ['head'];
+
+  render() {
+    const { html, ...viewProps } = this.props;
+    const document = parseDocument(html);
+    return (
+      <View {...viewProps}>
+        {document.children.map((c, i) => this.renderNode(c, i))}
+      </View>
+    );
   }
 
   renderElement(element, index) {
     if (this.ignoredTags.indexOf(element.name) > -1) {
       return null;
     }
     if (element.name === 'img') {
-      return <Image key={index} source={{uri: element.attribs.src}} />;
+      return <Image key={index} source={{ uri: element.attribs.src }} />;
     }
     const Wrapper = this.textTags.indexOf(element.name) > -1 ? Text : View;
     return (
@@ -40,13 +45,9 @@ export default class RenderHtmlSimple extends PureComponent {
     return null;
   }
 
-  render() {
-    const {html, ...viewProps} = this.props;
-    const document = parseDocument(html);
-    return (
-      <View {...viewProps}>
-        {document.children.map((c, i) => this.renderNode(c, i))}
-      </View>
-    );
+  renderTextNode(textNode, index) {
+    return <Text key={index}>{textNode.data}</Text>;
   }
+
+  textTags = ['span', 'strong', 'em'];
 }

doc-tools/doc-docsusaurus-rfg-plugin/package.json

@@ -6,7 +6,7 @@
     "build": "tsc -p ."
   },
   "dependencies": {
-    "htmlparser2": "^6.1.0",
+    "htmlparser2": "^7.1.1",
     "rfg-api": "^0.5.2"
   },
   "devDependencies": {

packages/render-html/package.json

@@ -54,7 +54,7 @@
     "@types/react-test-renderer": "^17.0.1",
     "babel-jest": "^27.0.2",
     "eslint": "^7.29.0",
-    "htmlparser2": "^6.1.0",
+    "htmlparser2": "^7.1.1",
     "jest": "^27.0.4",
     "metro-react-native-babel-preset": "^0.66.0",
     "prettier": "^2.3.1",

yarn.lock

@@ -9958,7 +9958,7 @@ __metadata:
     "@docusaurus/core": 2.0.0-beta.759298296
     "@docusaurus/plugin-content-docs": 2.0.0-beta.759298296
     "@docusaurus/types": 2.0.0-beta.759298296
-    htmlparser2: ^6.1.0
+    htmlparser2: ^7.1.1
     rfg-api: ^0.5.2
     typescript: ^4.3.2
   languageName: unknown
@@ -12942,6 +12942,18 @@ fsevents@^1.2.7:
   languageName: node
   linkType: hard
 
+"htmlparser2@npm:^7.1.1":
+  version: 7.1.1
+  resolution: "htmlparser2@npm:7.1.1"
+  dependencies:
+    domelementtype: ^2.0.1
+    domhandler: ^4.0.0
+    domutils: ^2.8.0
+    entities: ^3.0.1
+  checksum: f0033544fd359615ad7433cacd5c3ed409590c47142fdd740e7256fa7978f6800662c4519ef9ced47cea13f4eb8df3eeea6c9c2793638a52e5faeaeb54b018c8
+  languageName: node
+  linkType: hard
+
 "http-cache-semantics@npm:^4.0.0, http-cache-semantics@npm:^4.1.0":
   version: 4.1.0
   resolution: "http-cache-semantics@npm:4.1.0"
@@ -19976,7 +19988,7 @@ fsevents@^1.2.7:
     "@types/urijs": ^1.19.15
     babel-jest: ^27.0.2
     eslint: ^7.29.0
-    htmlparser2: ^6.1.0
+    htmlparser2: ^7.1.1
     jest: ^27.0.4
     metro-react-native-babel-preset: ^0.66.0
     prettier: ^2.3.1