Replace PropTypes usage with deprecated-react-native-prop-types #1008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingointo
commented
Apr 8, 2025
Author
ingointo
left a comment
ingointo
left a comment
There was a problem hiding this comment.
Changes Requested:
-
Carousel.js:
- Removed
ViewPropTypesimport fromreact-nativeand added it fromdeprecated-react-native-prop-types.
- Removed
-
Pagination.js:
- Removed
ViewPropTypesimport fromreact-nativeand added it fromdeprecated-react-native-prop-types.
- Removed
-
PaginationDot.js:
- Removed
ViewPropTypesimport fromreact-nativeand added it fromdeprecated-react-native-prop-types.
- Removed
-
ParallaxImage.js:
- Removed
ViewPropTypesimport fromreact-nativeand added it fromdeprecated-react-native-prop-types.
- Removed
| "author": "Meliorence <[email protected]> (github.com/meliorence)", | ||
| "license": "BSD-3-Clause", | ||
| "dependencies": { | ||
| "deprecated-react-native-prop-types": "^5.0.0", |
Author
There was a problem hiding this comment.
Added deprecated-react-native-prop-types to the dependencies in package.json with version ^5.0.0.
| import React, { Component } from 'react'; | ||
| import { Animated, Easing, FlatList, I18nManager, Platform, ScrollView, View, ViewPropTypes } from 'react-native'; | ||
| import { Animated, Easing, FlatList, I18nManager, Platform, ScrollView, View } from 'react-native'; | ||
| import { ViewPropTypes } from 'deprecated-react-native-prop-types'; |
Author
There was a problem hiding this comment.
Removed ViewPropTypes import from react-native and added it from deprecated-react-native-prop-types.
| import React, { PureComponent } from 'react'; | ||
| import { I18nManager, Platform, View, ViewPropTypes } from 'react-native'; | ||
| import { I18nManager, Platform, View } from 'react-native'; | ||
| import { ViewPropTypes } from 'deprecated-react-native-prop-types'; |
Author
There was a problem hiding this comment.
Removed ViewPropTypes import from react-native and added it from deprecated-react-native-prop-types.
| import React, { PureComponent } from 'react'; | ||
| import { View, Animated, Easing, TouchableOpacity, ViewPropTypes } from 'react-native'; | ||
| import { View, Animated, Easing, TouchableOpacity } from 'react-native'; | ||
| import { ViewPropTypes } from 'deprecated-react-native-prop-types'; |
Author
There was a problem hiding this comment.
Removed ViewPropTypes import from react-native and added it from deprecated-react-native-prop-types
| import React, { Component } from 'react'; | ||
| import { View, ViewPropTypes, Image, Animated, Easing, ActivityIndicator, findNodeHandle } from 'react-native'; | ||
| import { View, Image, Animated, Easing, ActivityIndicator, findNodeHandle } from 'react-native'; | ||
| import { ViewPropTypes } from 'deprecated-react-native-prop-types'; |
Author
There was a problem hiding this comment.
Removed ViewPropTypes import from react-native and added it from deprecated-react-native-prop-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
What testing has been done on this change?
Tested features checklist
enableMomentum)vertical)activeSlideAlignment)autoplay)loop)ScrollView/FlatListcarousels (propuseScrollView)ParallaxImagecomponentPaginationcomponent